From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: (qmail 3685 invoked from network); 4 May 2020 08:35:48 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 4 May 2020 08:35:48 -0000 Received: (qmail 24587 invoked by alias); 4 May 2020 08:35:41 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45777 Received: (qmail 8522 invoked by uid 1010); 4 May 2020 08:35:41 -0000 X-Qmail-Scanner-Diagnostics: from smtpq3.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25801. spamassassin: 3.4.4. Clear:RC:0(212.54.57.98):SA:0(-2.7/5.0):. Processed in 2.172393 secs); 04 May 2020 08:35:41 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.98 as permitted sender) X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.133 X-CNFS-Analysis: v=2.3 cv=IPGZ9jnG c=1 sm=1 tr=0 a=ShKnLeKYHz8gHcl3UCxcnw==:117 a=KEnZaF_ea6UA:10 a=IkcTkHD0fZMA:10 a=DoY9bV0jb9AA:10 a=CWfLps--R3J26yB8qcUA:9 a=QEXdDO2ut3YA:10 X-Authenticated-Sender: p.w.stephenson@ntlworld.com Date: Mon, 4 May 2020 09:35:02 +0100 (BST) From: Peter Stephenson To: Daniel Shahaf , zsh-workers@zsh.org Message-ID: <505277422.148264.1588581302888@mail2.virginmedia.com> In-Reply-To: <20200503210618.5c639014@tarpaulin.shahaf.local2> References: <20190518075514.hbygmb5dl5wz23h5@chaz.gmail.com> <20190520103444.qyih7lvoigvf3rfx@chaz.gmail.com> <1563722540.4311.24.camel@samsung.com> <1565710707.5633.11.camel@samsung.com> <309829031.4459446.1587391766024@mail2.virginmedia.com> <20200503000658.6fddb904@tarpaulin.shahaf.local2> <20200503210618.5c639014@tarpaulin.shahaf.local2> Subject: Re: Feature request: ZSH_XTRACEFD variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev69 X-Originating-IP: 165.225.81.56 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4wfIwXN7dMAQz2u0aYHsd/ZxB8CuyZPv9Cw+2/KYqiZbCYXAfAkURUh6OlWwPE0VK96SAS7iWzO/gz0RZuetEDgQyn+bwL1wQXjpVotVHn9hMR+0rgV4U0 x4f72QYnZz4xVDFcCmSJi1qCjJsnCPhbtDgXu6vma2HucHBOcH6JgRkRxdW5+mhU7DtFkVDaebRDMl2enk9W4m0kTTnKgWhEp9nLSiTbs+pSiIG5LInX0u4b kgtDRZxqp7IyurUr/cYMwA== > On 03 May 2020 at 22:06 Daniel Shahaf wrote: > When LC_ALL is unset, the patch calls setlocale() for all known locale > categories (LC_*), not only for the ones that changed, like langsetfn() > and lcsetfn() do. Is this a problem? (I guess there was a reason > langsetfn() and lcsetfn() weren't implemented to begin with via the > if/else/for combination you just wrote.) I don't think it should be a problem as it's just restoring the current values (unless there's some other bug we're not seeing. It didn't seem to me worthwhile tracking the individual variables when the calls to restore the complete state appear straightforward compared with the overall function exit procedure --- but feel free to disagree if you know more about that than I do as I'm basically just treating it as a black box. pws