zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Coredump in test B02 as of 2004-01-13
Date: Thu, 15 Jan 2004 10:51:15 +0000	[thread overview]
Message-ID: <5197.1074163875@csr.com> (raw)
In-Reply-To: "Vin Shelton"'s message of "Wed, 14 Jan 2004 11:05:10 EST." <545y8saseh5.fsf@alumni.princeton.edu>

Vin Shelton wrote:
> Greetings,
> 
> On my SunOS systems at work I'm seeing the following failure in the
> testsuite when running against a build of 2004-01-13:

Reduces to:

  unset argv
  print $#

Right idea, wrong number of ampersands.

Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.75
diff -u -r1.75 params.c
--- Src/params.c	12 Jan 2004 12:09:12 -0000	1.75
+++ Src/params.c	15 Jan 2004 10:50:29 -0000
@@ -2585,7 +2585,7 @@
      * ways which need to be set to NULL.  We can't do this
      * with user tied variables since we can leak memory.
      */
-    if ((pm->flags & PM_SPECIAL) & !x)
+    if ((pm->flags & PM_SPECIAL) && !x)
 	*dptr = mkarray(NULL);
     else
 	*dptr = x;

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************


  parent reply	other threads:[~2004-01-15 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-14 16:05 Vin Shelton
2004-01-15  7:38 ` Bart Schaefer
2004-01-15 10:51 ` Peter Stephenson [this message]
2004-01-15 14:36   ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5197.1074163875@csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).