From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7130 invoked by alias); 11 Oct 2017 18:45:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41866 Received: (qmail 20543 invoked by uid 1010); 11 Oct 2017 18:45:02 -0000 X-Qmail-Scanner-Diagnostics: from kahlil.inlv.org by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(37.59.109.123):SA:0(-1.9/5.0):. Processed in 1.944542 secs); 11 Oct 2017 18:45:02 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: martijn@inlv.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | To: Zsh hackers list From: Martijn Dekker Subject: [PATCH] POSIXBUILTINS: quieten 'unset -f nonexistentfunc' Message-ID: <51c2b43e-a0d3-2e4d-15e8-b368c922beec@inlv.org> Date: Wed, 11 Oct 2017 20:44:54 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------688C370C277C059B130BD430" Content-Language: en-GB --------------688C370C277C059B130BD430 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Doing 'unset -f' on an unset function outputs an error message and causes an unsuccessful exit status. All other shells quietly ignore it. POSIX specifies for 'unset' that "Unsetting a variable or function that was not previously set shall not be considered an error [...]". http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_29_03 If I have figured this out correctly, then the attached patch causes 'unset -f nonexistent_function' to be quiet and return status 0 if POSIXBUILTINS is active, without changing the behaviour of 'unfunction' and 'unhash -f'. - Martijn --------------688C370C277C059B130BD430 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="unset-f-quieten.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="unset-f-quieten.patch" ZGlmZiAtLWdpdCBhL1NyYy9idWlsdGluLmMgYi9TcmMvYnVpbHRpbi5jCmluZGV4IDg0YTJi ZWUuLjBmZjllNGYgMTAwNjQ0Ci0tLSBhL1NyYy9idWlsdGluLmMKKysrIGIvU3JjL2J1aWx0 aW4uYwpAQCAtMTI1LDcgKzEyNSw3IEBAIHN0YXRpYyBzdHJ1Y3QgYnVpbHRpbiBidWlsdGlu c1tdID0KICAgICBCVUlMVElOKCJ1bmFsaWFzIiwgMCwgYmluX3VuaGFzaCwgMCwgLTEsIEJJ Tl9VTkFMSUFTLCAiYW1zIiwgTlVMTCksCiAgICAgQlVJTFRJTigidW5mdW5jdGlvbiIsIDAs IGJpbl91bmhhc2gsIDEsIC0xLCBCSU5fVU5GVU5DVElPTiwgIm0iLCAiZiIpLAogICAgIEJV SUxUSU4oInVuaGFzaCIsIDAsIGJpbl91bmhhc2gsIDEsIC0xLCBCSU5fVU5IQVNILCAiYWRm bXMiLCBOVUxMKSwKLSAgICBCVUlMVElOKCJ1bnNldCIsIEJJTkZfUFNQRUNJQUwsIGJpbl91 bnNldCwgMSwgLTEsIDAsICJmbXYiLCBOVUxMKSwKKyAgICBCVUlMVElOKCJ1bnNldCIsIEJJ TkZfUFNQRUNJQUwsIGJpbl91bnNldCwgMSwgLTEsIEJJTl9VTlNFVCwgImZtdiIsIE5VTEwp LAogICAgIEJVSUxUSU4oInVuc2V0b3B0IiwgMCwgYmluX3NldG9wdCwgMCwgLTEsIEJJTl9V TlNFVE9QVCwgTlVMTCwgTlVMTCksCiAgICAgQlVJTFRJTigid2FpdCIsIDAsIGJpbl9mZywg MCwgLTEsIEJJTl9XQUlULCBOVUxMLCBOVUxMKSwKICAgICBCVUlMVElOKCJ3aGVuY2UiLCAw LCBiaW5fd2hlbmNlLCAwLCAtMSwgMCwgImFjbXB2ZnNTd3g6IiwgTlVMTCksCkBAIC00MTU4 LDYgKzQxNTgsMTAgQEAgYmluX3VuaGFzaChjaGFyICpuYW1lLCBjaGFyICoqYXJndiwgT3B0 aW9ucyBvcHMsIGludCBmdW5jKQogICAgIGZvciAoOyAqYXJndjsgYXJndisrKSB7CiAJaWYg KChobiA9IGh0LT5yZW1vdmVub2RlKGh0LCAqYXJndikpKSB7CiAJICAgIGh0LT5mcmVlbm9k ZShobik7CisJfSBlbHNlIGlmIChmdW5jID09IEJJTl9VTlNFVCAmJiBpc3NldChQT1NJWEJV SUxUSU5TKSkgeworCSAgICAvKiBQT1NJWDogdW5zZXQ6ICJVbnNldHRpbmcgYSB2YXJpYWJs ZSBvciBmdW5jdGlvbiB0aGF0IHdhcyAqCisJICAgICAqIG5vdCBwcmV2aW91c2x5IHNldCBz aGFsbCBub3QgYmUgY29uc2lkZXJlZCBhbiBlcnJvci4iICAgICovCisJICAgIHJldHVybnZh bCA9IDA7CiAJfSBlbHNlIHsKIAkgICAgendhcm5uYW0obmFtZSwgIm5vIHN1Y2ggaGFzaCB0 YWJsZSBlbGVtZW50OiAlcyIsICphcmd2KTsKIAkgICAgcmV0dXJudmFsID0gMTsKZGlmZiAt LWdpdCBhL1NyYy9oYXNodGFibGUuaCBiL1NyYy9oYXNodGFibGUuaAppbmRleCAzNjA2ZTk3 Li4yMTM5OGUxIDEwMDY0NAotLS0gYS9TcmMvaGFzaHRhYmxlLmgKKysrIGIvU3JjL2hhc2h0 YWJsZS5oCkBAIC02Miw2ICs2Miw3IEBACiAjZGVmaW5lIEJJTl9VTkhBU0ggICAyOAogI2Rl ZmluZSBCSU5fVU5BTElBUyAgMjkKICNkZWZpbmUgQklOX1VORlVOQ1RJT04gIDMwCisjZGVm aW5lIEJJTl9VTlNFVCAgICAzMQogCiAvKiBUaGVzZSBjdXJyZW50bHkgZGVwZW5kIG9uIGJl aW5nIDAgYW5kIDEuICovCiAjZGVmaW5lIEJJTl9TRVRPUFQgICAgMAo= --------------688C370C277C059B130BD430--