From: Hong Xu <hong@topbug.net>
To: zsh-workers@zsh.org
Subject: Re: Fix the outdated _npm completion script
Date: Sun, 23 Feb 2014 20:25:04 -0800 [thread overview]
Message-ID: <530AC9A0.1070008@topbug.net> (raw)
In-Reply-To: <530AC44E.5090708@topbug.net>
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On 2/23/14, 8:02 PM, Hong Xu wrote:
> Hi,
>
> The existing npm completion script no longer works. The stdout of `npm
> completion` has become a script to add a completion function. Here is
> the patch to update it.
An update to the patch, handling the case in which the npm command does
not exist.
Hong
[-- Attachment #2: _npm.patch --]
[-- Type: text/plain, Size: 900 bytes --]
diff --git a/Completion/Unix/Command/_npm b/Completion/Unix/Command/_npm
index 24b5361..f5493a3 100644
--- a/Completion/Unix/Command/_npm
+++ b/Completion/Unix/Command/_npm
@@ -1,19 +1,9 @@
#compdef npm
-# Node Package Manager 0.3.15 completion, letting npm do all the completion work
+# Node Package Manager completion, letting npm do all the completion work
-_npm() {
- compadd -- $(_npm_complete $words)
-}
+if type npm > /dev/null; then
+ eval "$(npm completion)"
-# We want to show all errors of any substance, but never the "npm (not )ok" one.
-# (Also doesn't consider "ERR! no match found" worth breaking the terminal for.)
-_npm_complete() {
- local ask_npm
- ask_npm=(npm completion --color false --loglevel error -- $@)
- { _call_program npm $ask_npm 2>&1 >&3 \
- | egrep -v '^(npm (not |)ok|ERR! no match found)$' >&2; \
- } 3>&1
-}
-
-_npm "$@"
+ _npm_completion "$@"
+fi
prev parent reply other threads:[~2014-02-24 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 4:02 Hong Xu
2014-02-24 4:25 ` Hong Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530AC9A0.1070008@topbug.net \
--to=hong@topbug.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).