From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18693 invoked by alias); 14 Jun 2016 09:38:18 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38678 Received: (qmail 22513 invoked from network); 14 Jun 2016 09:38:15 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1465896713; bh=kT9SeNCz3ISsF9qyUFesV18Jjf/uC+WUro2W1I8lENo=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=cIHHJ0/2YQFXZwgkW1aTAn6pUw/O4vucCY/3+WMTMPwwp8UjFiJe0SElAJDxyGdxVoRtCzYporw675r8OE1ZQtYYMVtnHVtHf6CJ+b1f16jKszASmhfvklbZA3v3PBQNKQ47wS5+fR9ieqKh80+xaZ8Y+4uGpeY2kcuhf3RIPBY74oPGTL5zy6NP8YiM48w0SXrD6Yjx/cq64xc2c+zq0lFaesnKU6kmvqtx3L5NvBorM600vDQnhjvFya+srKlBevZS+DcbhVLgFCiQf8zQUi8rAac5ov9ycg4jwiLkyaPR7kulmZKoBDi40PgsXkeYye/YHPzLsnEhaW7FnVFG8w== X-Yahoo-Newman-Id: 586362.47044.bm@smtp149.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: H7DcRxwVM1nuhaSP1B9VBXbjr6r9JHw_Xi6TpY4LER_7l1A ruEYHo8GIskGvQe3Am3FQIIPktMcpCsAVnn7VvZbEua_W_c93OvJQK2ax9vs we3bsJI0OBN8Z0bl_4YxoATaXpVf5d2wpJRkwNm.JIG1jDWl61Kowf537.dm upOFcMhAOtxlkAaVnzHWjAu8T_R1BXnuDPVCmWe4BUJVVSjLcs.pJ8Y4I5bl CGBa4QHKtGU4Cd6VIuBSoQqxIj60UAiW0N9dLe6ZZK_cnQMP7bcVMpQWJ0As vjPxsmGHHjgJlpNTlVM8iERHpOc3EXlfRT2lPjJH4HToW1zYg5zs83UlH0h8 UdBPdLXG4A9ZIUijv9JBUO5GxX9XgAk53h2sZRDOL0A6oA2MM4UkKTBIG3hu sQodbHDK4EooNL9cXZf2lf4qkOaUBsICW1Lec8x9x.81dp.H9b3w5RKtl41y zt3D8LoEJDw2BY5HsXcdDBu8xptA649Rh2EACNIF0sgl2KWL_7CUPpxh0KLf fSzpNjLwDKRXB7nEDOKuFLM.kYVe6ug-- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- In-reply-to: <2aa4c678-6d5e-0614-7aff-e374c3108ba3@gmx.com> From: Oliver Kiddle References: <57504DEC.9000101@redhat.com> <2aa4c678-6d5e-0614-7aff-e374c3108ba3@gmx.com> To: zsh-workers@zsh.org Subject: Re: [PATCH v4] zsh localedef completion MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5310.1465896710.1@thecus.kiddle.eu> Date: Tue, 14 Jun 2016 11:31:52 +0200 Message-ID: <5312.1465896712@thecus.kiddle.eu> Eric Cook wrote: > > > + _wanted values expl charmap compadd "$@" \ The tag should probably be charmaps rather than values and "$@" is superfluous given this is function is not intended to be called from others. > > + -M 'm:{a-zA-Z}={A-Za-z} r:|-=* r:|=*' \ > > + -a - charmaps && ret=0 > > > Also, what is the list's opinion of an completer forcing case insensitivity? > Its a option the user normally have control over but after checking Completion/, > i notice a few non-utility functions also do so. If whatever is being completed is treated case-insensitively by whatever program recieves it then it makes sense for the completion to also be case-sensitive. So as long as localedef is as happy with utF-8 as with UTF-8 then this would seem good. The same argument doesn't quite apply to the r: specs: localedef isn't going to accept U-8 as a shorthand for UTF-8. I would still include it in cases where the matches are composed of - separated components, however, even if for no other reason than to preserve and convey that information in the function definitions. It could perhaps be made easier to disable hard coded match specs with a style. Currently it isn't too easy: compadd will accept multiple -M options and concatenate them so that all apply. In the _wanted example above, you get specs from the matcher style first, then matcher-list, then anything in "$@" and finally the hard coded list. Perhaps we could allow a special token in match specs that would cause subsequent specs to be ignored or filtered? Oliver