From: Nikolas Garofil <nikolas@garofil.be>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 1/6] fix implicit typecast for strict compilers
Date: Sat, 07 Jun 2014 21:13:31 +0200 [thread overview]
Message-ID: <5393645B.7050409@garofil.be> (raw)
In-Reply-To: <140607120439.ZM24985@torch.brasslantern.com>
On 06/07/2014 09:04 PM, Bart Schaefer wrote:
> On Jun 7, 7:18pm, Nikolas Garofil wrote:
> }
> } diff --git a/Src/compat.c b/Src/compat.c
> } index cc4e876..81a95d5 100644
> } --- a/Src/compat.c
> } +++ b/Src/compat.c
> } @@ -40,7 +40,7 @@ strstr(const char *s, const char *t)
> } char *p1, *p2;
> }
> } for (; *s; s++) {
> } - for (p1 = s, p2 = t; *p2; p1++, p2++)
> } + for (p1 = (char*)s, p2 = (char*)t; *p2; p1++, p2++)
> } if (*p1 != *p2)
> } break;
> } if (!*p2)
> } --
>
>
> Wouldn't the right thing here be to declare
>
> const char *p1, *p2;
>
> instead of casting?
>
The p1 and p2 pointers are increased at the end of the line to walk
through the string so that wouldn't work
next prev parent reply other threads:[~2014-06-07 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 17:18 Nikolas Garofil
2014-06-07 17:18 ` [PATCH 2/6] strict compilers expect the number of bytes to be a size_t for bcopy Nikolas Garofil
2014-06-07 19:20 ` Bart Schaefer
2014-06-07 19:29 ` Nikolas Garofil
2014-06-07 17:18 ` [PATCH 3/6] make sure signal_suspend doesn't return a undefined value Nikolas Garofil
2014-06-07 17:18 ` [PATCH 4/6] strict compilers don't like pointers that get set but are never used Nikolas Garofil
2014-06-07 17:18 ` [PATCH 5/6] memmove is expected to return dest Nikolas Garofil
2014-06-07 19:15 ` Bart Schaefer
2014-06-07 17:18 ` [PATCH 6/6] decr and tmp are only used when HAVE_STRFTIME is defined, strict compilers will complain Nikolas Garofil
2014-06-07 19:04 ` [PATCH 1/6] fix implicit typecast for strict compilers Bart Schaefer
2014-06-07 19:13 ` Nikolas Garofil [this message]
2014-06-07 19:36 ` Bart Schaefer
2014-06-07 19:43 ` Nikolas Garofil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5393645B.7050409@garofil.be \
--to=nikolas@garofil.be \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).