From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22601 invoked by alias); 7 Jun 2014 19:36:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32744 Received: (qmail 26094 invoked from network); 7 Jun 2014 19:36:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=fuu7BcLXQk1GGLQ/HOACBKckGVmXowX/eeWB/iZx8dA=; b=amEdgLjE8zxm6kRxsxiinAjVahcdUk4rF+Sl0nRUDT6f3DEgOFo+zz4/1Xse0Dca4t OBXwK46cKJxGmwqy5aD97d/D3dUPKDJl710/0Gb5kDqDb6aL64+QAwkdh5WW+zd4cYJS OeAdMkRwOUhnis2S7QNEi0ufxkPlYDVIs7RiDTgrZEMNxjUugozHw3AmW7CdpAJkcxoG fbe4ZLroOD5UwljT7hOJJ2QUasgdP0uzYNtsy+ZZEfRWEUBnxYTXJXWaUkY7gYAya8KE liuqtZgoMVE0G+hPzem2o+jzdIrAUJyRwqIk/4/D9D6X0KMtAX04BNRoLMON/bt+lxJN fPrA== X-Received: by 10.14.246.68 with SMTP id p44mr2408260eer.8.1402169388237; Sat, 07 Jun 2014 12:29:48 -0700 (PDT) Sender: Nikolas Garofil Message-ID: <5393682A.2030102@garofil.be> Date: Sat, 07 Jun 2014 21:29:46 +0200 From: Nikolas Garofil User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: zsh-workers@zsh.org Subject: Re: [PATCH 2/6] strict compilers expect the number of bytes to be a size_t for bcopy References: <1402161535-20756-1-git-send-email-nikolas@garofil.be> <1402161535-20756-2-git-send-email-nikolas@garofil.be> <140607122058.ZM25045@torch.brasslantern.com> In-Reply-To: <140607122058.ZM25045@torch.brasslantern.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 06/07/2014 09:20 PM, Bart Schaefer wrote: > On Jun 7, 7:18pm, Nikolas Garofil wrote: > } > } --- a/Src/prototypes.h > } +++ b/Src/prototypes.h > } @@ -130,5 +130,5 @@ extern char *strerror _((int errnum)); > } /***************************************************/ > } > } #ifndef HAVE_MEMMOVE > } -extern void bcopy _((const void *, void *, int)); > } +extern void bcopy _((const void *, void *, size_t)); > } #endif > } -- > > Pardon my paranoia, but are we sure that won't itself break somewhere? > A strict compiler that doesn't have size_t declared in scope, or that > does have bcopy() but it doesn't use size_t for it? > > Yes, this is probably pretty unlikely nowadays, but obviously you found > one that doesn't have memmove() which I would have thought less likely. A check could be added to choose between both implementations