From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18956 invoked from network); 18 Jan 2021 05:43:48 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 18 Jan 2021 05:43:48 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1610948628; b=Wt5khi2O0TBTB+4GaTXZlu6w2Zs9E93XA23TPzbDHUVBh0ynvoQqUlo8AleRpBHvkrvPkoE270 kvP1xb7B/LQA1bIIz14uvlB9ZWit6HWrsb/OFj1oSr1y26UyviABnfn6ysXcQdLOZ3ROZzximd Ijn2HUexDXraLGFi1M9B2+pgi3C4uZQbp9cCzKYuekhWh1bsOtRc69VWQ3pCSYsZoU+2Ov3FMd QPlTIrr/4sywMYl7OsWxKiKRaayOr9QSh+CMdcChZqPnzRz8/y75fFWZ2P3Wvu4VIxcHFIsH6Q 65DygWtXIFvMgGsa8AZ+dXX6OI8gsEIik6S0g4Mzdm/DLQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (rcpt-expgw.biglobe.ne.jp) smtp.remote-ip=133.208.98.4; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1610948628; bh=PWviXz3b8PW/NlJSIX4/rr+WvR3qIw6M04PDoApHDi8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:To:References:Message-ID:Content-Transfer-Encoding:Cc:Date: In-Reply-To:From:Subject:MIME-Version:Content-Type:DKIM-Signature; b=c4SXxufria0zuSMpfH8HfllFlGEtBpgdFdJRxLrzJOYADLaVJDTdbTVcP5pJUuralZ0ZB5Y3BN Co40eAtDeIyLVJNEFKPdkoG4ATFsurvJowmgi1QSXRzljLv7XvUBdVuKCaVJl2UrfbHLFURspo RxLq/yDNSPgQXr7mjbFi48gbbQ5s/3pCvhTnfbrPxdOGhFDdYK18U55WldKjpVqNZmCbrKsYYA dXNDyhtEKURo2ihP2C9Q1OXOO0Z7dt45fdbv4Qm+iDgXo+SPakfhp9WwIs6HUXaUdOP3+Hod4O bbJF9Ij5In3MqI9Kc5wFZ5csQzZBSpATg2tVV6jmjNPE4Q==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Egc5Rl5lIH5buh/N68N49iXz4ikyE2PnFdw2mXh5ybs=; b=cHgF2AKGVFOFBIZt3yrFp3yJsK bSe+yunj96IPJBE58o9q5+vR6aWWbWHSY5E9i9At0BGf++79YxHpVEqsVGEjZ6RXgvw2D01OzTzqc ZT5HS1W87S4FhjEUPaqn+yCjbr15qZWNaRvSpmSn0x5OrWY7zR4/U3ngDXl/iyOHEGPetOYdxkagz T0I5eW/NV1FWRnA97dLl4tpjbNOAeDnub9eapQMqZZJU3KlbPavxcVCxjWhtfpUfSXOHibWK/42Fi jNkC3aX0iSDFMC2aPfytXOzX6IvXX4suarApAgNnkc3jHqa4VHDW2jOm86aEfL/F7bCrZmXxFhAXw xTVDWNjA==; Received: from authenticated user by zero.zsh.org with local id 1l1NKL-0002b1-VJ; Mon, 18 Jan 2021 05:43:46 +0000 Authentication-Results: zsh.org; iprev=pass (rcpt-expgw.biglobe.ne.jp) smtp.remote-ip=133.208.98.4; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from rcpt-expgw.biglobe.ne.jp ([133.208.98.4]:49366) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1l1NK1-0002RX-Cj; Mon, 18 Jan 2021 05:43:27 +0000 Received: from vc-gw.biglobe.ne.jp by rcpt-expgw.biglobe.ne.jp (hngd/4514161018) with ESMTP id 10I5hHv4010195; Mon, 18 Jan 2021 14:43:17 +0900 Received: from smtp-gw.biglobe.ne.jp ([192.168.154.160]) by vc-gw.biglobe.ne.jp (shby/1011270619) with ESMTP id 10I5hHoE005559; Mon, 18 Jan 2021 14:43:17 +0900 X-Biglobe-Sender: Received: from tamac1.yz.yamagata-u.ac.jp ([133.24.84.20]) by smtp-gw.biglobe.ne.jp id ON6XC0A89944; Mon, 18 Jan 2021 14:43:17 +0900 (JST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: [PATCH v3] Make zpty module work in the cygwin and msys2 From: Jun T In-Reply-To: Date: Mon, 18 Jan 2021 14:43:16 +0900 Cc: Peiyuan Song Content-Transfer-Encoding: quoted-printable Message-Id: <5444AEBC-5A8F-438E-89C6-21EB5741E22D@kba.biglobe.ne.jp> References: To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.3445.104.17) X-Biglobe-Spnum: 55223 X-Seq: 47841 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Thank you for the patch. It (v3) works fine on my Cygwin (3.1.7). > 2021/01/18 11:28, Peiyuan Song wrote: >=20 > assume cygwin upstream issue will be fixed in version > 3.2.0 Are you sure it will be fixed in 3.2.0 (and also not fixed in 3.1.x) ? Currently, all or part of the following tests are skipped on Cygwin due to the broken zpty: E01, V08, W02, X0{2,3,4} Y0{1,2,3} If these are modified so that they are no skipped on Cygwin, all of them pass except Y01, which fails as follows: ./Y01completion.ztst: starting. --- /tmp/zsh.ztst.60503/ztst.out 2021-01-18 10:07:03.427737000 = +0900 +++ /tmp/zsh.ztst.60503/ztst.tout 2021-01-18 10:07:03.662082600 = +0900 @@ -3,7 +3,7 @@ FI:{\!foo} FI:{\#foo} FI:{Afoo} -FI:{\\foo} FI:{bfoo} +EX:{foo} FI:{\|foo} FI:{\~foo} Test ./Y01completion.ztst failed: output differs from expected as shown = above for: { mkdir sortnobslash touch sortnobslash/{'!foo','#foo','\foo','|foo','~foo',Afoo,bfoo} comptesteval 'old_LC_ALL=3D$LC_ALL; LC_ALL=3DC' comptest $': sortnobslash/\t' } always { comptesteval 'LC_ALL=3D$old_LC_ALL' rm -rf sortnobslash } Was testing: ignore backslashes when sorting completion matches ./Y01completion.ztst: test failed. As you can see, 'sortnobslash/foo' (instead of 'sortnobslash/\foo') is = created by the touch command. I guess '\' is not allowed in a filename on Cygwin.