From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1923 invoked by alias); 7 Sep 2016 08:05:31 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39212 Received: (qmail 1390 invoked from network); 7 Sep 2016 08:05:31 -0000 X-Qmail-Scanner-Diagnostics: from mail-wm0-f48.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.48):SA:0(-0.0/5.0):. Processed in 0.312049 secs); 07 Sep 2016 08:05:31 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: myllynen@redhat.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 74.125.82.48 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:reply-to:subject:references:to:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=yVzpAiz/977tCg2lytVVdXYc/POwJGdmUJoX3G3XJjg=; b=XWcNUFotkGQLgtWbJs/2de4W1vC53RKyhVBrD/zTNUuEFdVHP2iTuktC2CG8cVpWhy V9MeeY8urG5M61O99xGNQaHw9JggrziFs1dsBKx1fO4NsavPbyJy6iKjVyaGruB6i0fI zPNqu5sktmSOlcETUbzOZJEx7BHbxBm4B13d22Rqo0F4E7IYeu5kTerLNqzlaoskP2hj LuSf9Hf8gaRLtGabKMob/mgL2p1QCHvjNfrs0S0owrCFGUYq682XzKLJjRXgnrOEEcea 3iMkoP4Rr+AyGXCRo13h+M//QVbzkhABV8N8SUGKh3V6se92j74ZPnWdou4wZKtN3O7c kb2g== X-Gm-Message-State: AE9vXwPJ6hD1eUR67/CeXzWrPuxy3abM331tZhN0d3K/T/Z85w6h2Kkswi0ckSXwp8NIYz/r X-Received: by 10.28.25.71 with SMTP id 68mr2144159wmz.19.1473232359841; Wed, 07 Sep 2016 00:12:39 -0700 (PDT) Reply-To: Marko Myllynen Subject: Re: Zsh OpenStack completions References: <9361ff20-f0f2-9acd-e43e-4b1e2e203531@redhat.com> To: zsh-workers@zsh.org From: Marko Myllynen Organization: Red Hat Message-ID: <544ddbce-b3aa-3a08-0470-79e3e563d405@redhat.com> Date: Wed, 7 Sep 2016 10:12:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, On 2016-09-07 02:23, Eric Cook wrote: > On 09/06/2016 08:39 AM, Marko Myllynen wrote: >> >> Below is a patch to add completions for several OpenStack related >> command line clients, including the new common client, openstack(1). > > Adding shell completion for openstack seems like something that is > better fit committing to their respective project(s). Since it's a > very active moving target I would imagine by the completer becoming > dated fairly quickly. Committing it there would also (possibly) have > more eyeballs that actually use openstack to help out too. Yes, it is *very* fast moving target, that's why the implementation is client/command agnostic - I'm unaware of any client ever switching from the old style bash-completion command to the new style complete command so that's the reason I think this should be relatively stable approach; I'm sure nobody here wants to / can keep track of the each client supported already (more perhaps to come). Dealing with over dozen OpenStack projects to get completions included (and then later making sure downstream packagers include them as well) also sounds like quite a lot of work. > _systemd would be the most recent example of this. We had a completer > distributed with zsh. It wasn't kept up to date and people started to > maintain completers in the systemd git repo. It actually caused > confusion in #zsh for a few people when they noticed some commands wasn't > showing all of the options expected on some systems and not others. Since > two completers for systemd's utilities were in $fpath where as another > OS decided to delete _systemd from zsh's source when packaging it. I think _systemd completions are a good fit for systemd upstream (like _pcp completions for PCP upstream which I contributed some time earlier this year). However, given the fact that there's nothing OpenStack client/command specific here except for the bash-completion vs complete vs swift divide I think it would be feasible to have _openstack in zsh upstream. Thanks, -- Marko Myllynen