Test Failures

Test Failures

[Vin Shelton]

Recently (starting I think on March 26), this failure appeared in the
test suite:

cd Test ; make check
make[1]: Entering directory `/u/shelton2/software/build/SunOS-5.8/zsh-2003-03-27/Test'
if test -n "/opt/SUNWspro/bin/cc"; then \
  cd .. && DESTDIR= \
  make MODDIR=`pwd`/Test/Modules install.modules > /dev/null; \
fi
mkdir /u/shelton2/software/build/SunOS-5.8/zsh-2003-03-27/Test/Modules
mkdir /u/shelton2/software/build/SunOS-5.8/zsh-2003-03-27/Test/Modules/zsh
mkdir /u/shelton2/software/build/SunOS-5.8/zsh-2003-03-27/Test/Modules/zsh/net
for f in /u/shelton2/software/src/zsh-2003-03-27/Test/*.ztst; do \
  ../Src/zsh +Z -f /u/shelton2/software/src/zsh-2003-03-27/Test/ztst.zsh $f; \
done
/u/shelton2/software/src/zsh-2003-03-27/Test/A01grammar.ztst: starting.
*** /tmp/zsh.ztst.err.4366	Thu Mar 27 04:20:15 2003
--- /tmp/zsh.ztst.terr.4366	Thu Mar 27 04:20:15 2003
***************
*** 1,2 ****
- 1) one     2) two     3) three   
  input> input> 
--- 1 ----
Test /u/shelton2/software/src/zsh-2003-03-27/Test/A01grammar.ztst failed: error output differs from expected as shown above for:
  PS3="input> "
  select name in one two three; do
    print $name
  done
Was testing: `select' loop
/u/shelton2/software/src/zsh-2003-03-27/Test/A01grammar.ztst: test failed.

System info:
  uname -a reports:
    SunOS denver 5.8 Generic_108528-14 sun4u sparc SUNW,Ultra-5_10 Solaris

  Built with:
    cc: WorkShop Compilers 4.2 30 Oct 1996 C 4.2

configuration info:
/u/shelton2/software/src/zsh-2003-03-27/configure '--prefix=/u/shelton2/software/SunOS-5.8/zsh-2003-03-27' '--datadir=/u/shelton2/software/share' '--enable-zsh-mem' '--enable-etcdir=/u/shelton2/software/etc' '--enable-dynamic' '--disable-nls' '--disable-locale' 'CC=/opt/SUNWspro/bin/cc' 'CFLAGS=-xO5 -dalign'

HTH,
  Vin

Re: Test Failures

[Bart Schaefer]

On Mar 28,  3:24pm, Vin Shelton wrote:
}
} Recently (starting I think on March 26), this failure appeared

That would make sense, as the test in question was added on March 26.

} ***************
} *** 1,2 ****
} - 1) one     2) two     3) three   
}   input> input> 
} --- 1 ----
} Was testing: `select' loop

It looks like the test is working correctly (in the sense that it reads
the input and chooses the right item from the list) except that the list
of choices is not being printed to stderr where the test code expects to
see it.

This may be happening because loop.c:selectlist() is still using the global
variable `columns' (usually initialized from the terminal size) to decide
how wide a list to print, even when the input to the select loop is not
coming from a terminal and the output is not to a terminal.

That's only a guess, though, because this test passes on machines to which
I have access.

Re: Test Failures

[Vin Shelton]

"Bart Schaefer" <schaefer@brasslantern.com> writes:
> On Mar 28,  3:24pm, Vin Shelton wrote:
> }
> } Recently (starting I think on March 26), this failure appeared
>
> That would make sense, as the test in question was added on March 26.

Blush.

>
> } ***************
> } *** 1,2 ****
> } - 1) one     2) two     3) three   
> }   input> input> 
> } --- 1 ----
> } Was testing: `select' loop
>
> It looks like the test is working correctly (in the sense that it reads
> the input and chooses the right item from the list) except that the list
> of choices is not being printed to stderr where the test code expects to
> see it.
>
> This may be happening because loop.c:selectlist() is still using the global
> variable `columns' (usually initialized from the terminal size) to decide
> how wide a list to print, even when the input to the select loop is not
> coming from a terminal and the output is not to a terminal.
>
> That's only a guess, though, because this test passes on machines to which
> I have access.

OK, FWIW, I see the failure on both Solaris 5.5 and 5.8 at work, and
on my linux box:

: ~ Sun 30 14:55; uname -a
Linux zion.rcn.com 2.4.21-0.13mdkcustom #4 SMP Sat Mar 8 23:08:38 EST 2003 i686 unknown unknown GNU/Linux

here at home.

  - Vin

Re: Test Failures

[Peter Stephenson]

Vin Shelton wrote:
> > } ***************
> > } *** 1,2 ****
> > } - 1) one     2) two     3) three   
> > }   input> input> 
> > } --- 1 ----
> > } Was testing: `select' loop
> 
> OK, FWIW, I see the failure on both Solaris 5.5 and 5.8 at work, and
> on my linux box:

Does normal select work?  If so, does it non-interactively send messages
to stderr?  Any sign of the missing message appearing on the terminal?

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

Re: Test Failures

[Vin Shelton]

Peter Stephenson <pws@csr.com> writes:
> Vin Shelton wrote:
>> > } ***************
>> > } *** 1,2 ****
>> > } - 1) one     2) two     3) three   
>> > }   input> input> 
>> > } --- 1 ----
>> > } Was testing: `select' loop
>> 
>> OK, FWIW, I see the failure on both Solaris 5.5 and 5.8 at work, and
>> on my linux box:
>
> Does normal select work?
Normal select works.  At least this script:

    #!/bin/sh
 
    # Execute this script under the Z shell
    [ ! -n "$ZSH_VERSION" ] && exec zsh -f "$0" ${1+"$@"}

    progname=${0:t}

    PROMPT3='Select prompt> '

    select choice in one two three
    do
      case $choice in
      (one|two|three)
        echo You chose $choice
        break
        ;;
      esac
    done

does the expected thing.

> If so, does it non-interactively send messages to stderr?
I'm not sure what you mean here.  When I run the script here is what
gets output to stderr:

    1) one    2) two    3) three  
    Select prompt> 


> Any sign of the missing message appearing on the terminal?
No.  I ran:
  ZTST_verbose=1 make TESTNUM=A01 check >out 2>err

Here is the contents of out:
    cd Test ; make check
    make[1]: Entering directory `/u/shelton2/software/build/SunOS-5.8/zsh-2003-03-31-1145/Test'
    if test -n "/opt/SUNWspro/bin/cc"; then \
      cd .. && DESTDIR= \
      make MODDIR=`pwd`/Test/Modules install.modules > /dev/null; \
    fi
    for f in /u/shelton2/software/src/zsh-2003-03-31-1145/Test/A01*.ztst; do \
      ../Src/zsh +Z -f /u/shelton2/software/src/zsh-2003-03-31-1145/Test/ztst.zsh $f; \
    done
    /u/shelton2/software/src/zsh-2003-03-31-1145/Test/A01grammar.ztst: starting.
    Running test: Basic pipeline handling
    Test successful.
    Running test: Exit status of pipeline with builtins (true)
    Test successful.
    Running test: Exit status of pipeline with builtins (false)
    Test successful.
    Running test: Basic coprocess handling
    Test successful.
    Running test: Basic sublist (i)
    Test successful.
    Running test: Basic sublist (ii)
    Test successful.
    Running test: Basic subshell list with error
    Test successful.
    Running test: Basic current shell list with error
    Test successful.
    Running test: `-' precommand modifier
    Test successful.
    Running test: `noglob' precommand modifier
    Test successful.
    Running test: `exec' precommand modifier
    Test successful.
    Running test: `command' precommand modifier
    Test successful.
    Running test: `builtin' precommand modifier
    Test successful.
    Running test: `if ...' (i)
    Test successful.
    Running test: `if ...' (ii)
    Test successful.
    Running test: `if ...' (iii)
    Test successful.
    Running test: `if ...' (iv)
    Test successful.
    Running test: `for' loop
    Test successful.
    Running test: `for' loop with newline before in keyword
    Test successful.
    Running test: arithmetic `for' loop
    Test successful.
    Running test: enhanced `for' syntax with two loop variables
    Test successful.
    Running test: enhanced `for' syntax with three loop variables
    Test successful.
    Running test: compatibility of enhanced `for' syntax with standard syntax
    Test successful.
    Running test: `while' loop
    Test successful.
    Running test: `until' loop
    Test successful.
    Running test: `repeat' loop
    Test successful.
    Running test: `case', old syntax
    Test successful.
    Running test: `case', new syntax
    Test successful.
    Running test: `case', new syntax, cascaded
    Test successful.
    Running test: `select' loop
    *** /tmp/zsh.ztst.err.5558	Mon Mar 31 16:33:24 2003
    --- /tmp/zsh.ztst.terr.5558	Mon Mar 31 16:33:24 2003
    ***************
    *** 1,2 ****
    ! 1) one     2) two     3) three   
      input> input> 
    --- 1,2 ----
    ! 1) one    2) two    3) three  
      input> input> 
    Test /u/shelton2/software/src/zsh-2003-03-31-1145/Test/A01grammar.ztst failed: error output differs from expected as shown above for:
      PS3="input> "
      select name in one two three; do
        print $name
      done
    Was testing: `select' loop
    /u/shelton2/software/src/zsh-2003-03-31-1145/Test/A01grammar.ztst: test failed.
    rm -rf Modules .zcompdump
    make[1]: Leaving directory `/u/shelton2/software/build/SunOS-5.8/zsh-2003-03-31-1145/Test'

Here is the contents of err:
    mkdir /u/shelton2/software/build/SunOS-5.8/zsh-2003-03-31-1145/Test/Modules
    mkdir /u/shelton2/software/build/SunOS-5.8/zsh-2003-03-31-1145/Test/Modules/zsh
    mkdir /u/shelton2/software/build/SunOS-5.8/zsh-2003-03-31-1145/Test/Modules/zsh/net
    make[1]: [check] Error 1 (ignored)

and nothing was printed on the terminal.  It looks to me that the only
difference is that there are extra spaces in the first line:
'one     ' vs. 'one    ',
'two     ' vs. 'two    ' and
'three   ' vs. 'three  '.


  - Vin

Re: Test Failures

[Peter Stephenson]

Vin Shelton wrote:
>     *** /tmp/zsh.ztst.err.5558	Mon Mar 31 16:33:24 2003
>     --- /tmp/zsh.ztst.terr.5558	Mon Mar 31 16:33:24 2003
>     ***************
>     *** 1,2 ****
>     ! 1) one     2) two     3) three   
>       input> input> 
>     --- 1,2 ----
>     ! 1) one    2) two    3) three  
>       input> input> 

Aha!  The last time you sent this the line was missing altogether.  So
we're making progress.  It looks like something to do with the column
spacing, which was what Bart was speculating about.  Now I know what to
look for, I can show it by maximising the window.

Try the following.  It's got an irrelevant additional parameter test
which happened to be lying around tacked on.

Index: Test/A01grammar.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/A01grammar.ztst,v
retrieving revision 1.7
diff -u -r1.7 A01grammar.ztst
--- Test/A01grammar.ztst	26 Mar 2003 14:55:59 -0000	1.7
+++ Test/A01grammar.ztst	1 Apr 2003 09:50:57 -0000
@@ -233,10 +233,11 @@
 
 ## Select now reads from stdin if the shell is not interactive.
 ## Its own output goes to stderr.
+  (COLUMNS=80
   PS3="input> "
   select name in one two three; do
     print $name
-  done
+  done)
 0:`select' loop
 <2
 ?1) one     2) two     3) three   
Index: Test/D04parameter.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/D04parameter.ztst,v
retrieving revision 1.6
diff -u -r1.6 D04parameter.ztst
--- Test/D04parameter.ztst	25 Sep 2001 17:37:55 -0000	1.6
+++ Test/D04parameter.ztst	1 Apr 2003 09:50:57 -0000
@@ -555,3 +555,25 @@
 >/here:/there
 >0
 >/elsewhere /somewhere
+
+  string='look for a match in here'
+  if [[ ${string%%(#b)(match)*} = "look for a " ]]; then
+    print $match[1] $mbegin[1] $mend[1] $string[$mbegin[1],$mend[1]]
+    print $#match $#mbegin $#mend
+  else
+    print That didn\'t work.
+  fi
+0:Parameters associated with backreferences
+>match 12 16 match
+>1 1 1
+
+  string='and look for a MATCH in here'
+  if [[ ${(S)string%%(#m)M*H} = "and look for a  in here" ]]; then
+    print $MATCH $MBEGIN $MEND $string[$MBEGIN,$MEND]
+    print $#MATCH
+  else
+    print Oh, dear.  Back to the drawing board.
+  fi
+0:Parameters associated with (#m) flag
+>MATCH 16 20 MATCH
+>5

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

Re: Test Failures

[Vin Shelton]

Thanks, Peter.  That fixed the test failure.

        - Vin

Peter Stephenson <pws@csr.com> writes:
> Vin Shelton wrote:
>>     *** /tmp/zsh.ztst.err.5558	Mon Mar 31 16:33:24 2003
>>     --- /tmp/zsh.ztst.terr.5558	Mon Mar 31 16:33:24 2003
>>     ***************
>>     *** 1,2 ****
>>     ! 1) one     2) two     3) three   
>>       input> input> 
>>     --- 1,2 ----
>>     ! 1) one    2) two    3) three  
>>       input> input> 
>
> Aha!  The last time you sent this the line was missing altogether.  So
> we're making progress.  It looks like something to do with the column
> spacing, which was what Bart was speculating about.  Now I know what to
> look for, I can show it by maximising the window.
>
> Try the following.  It's got an irrelevant additional parameter test
> which happened to be lying around tacked on.
>
> Index: Test/A01grammar.ztst
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Test/A01grammar.ztst,v
> retrieving revision 1.7
> diff -u -r1.7 A01grammar.ztst
> --- Test/A01grammar.ztst	26 Mar 2003 14:55:59 -0000	1.7
> +++ Test/A01grammar.ztst	1 Apr 2003 09:50:57 -0000
> @@ -233,10 +233,11 @@
>  
>  ## Select now reads from stdin if the shell is not interactive.
>  ## Its own output goes to stderr.
> +  (COLUMNS=80
>    PS3="input> "
>    select name in one two three; do
>      print $name
> -  done
> +  done)
>  0:`select' loop
>  <2
>  ?1) one     2) two     3) three   
> Index: Test/D04parameter.ztst
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Test/D04parameter.ztst,v
> retrieving revision 1.6
> diff -u -r1.6 D04parameter.ztst
> --- Test/D04parameter.ztst	25 Sep 2001 17:37:55 -0000	1.6
> +++ Test/D04parameter.ztst	1 Apr 2003 09:50:57 -0000
> @@ -555,3 +555,25 @@
>  >/here:/there
>  >0
>  >/elsewhere /somewhere
> +
> +  string='look for a match in here'
> +  if [[ ${string%%(#b)(match)*} = "look for a " ]]; then
> +    print $match[1] $mbegin[1] $mend[1] $string[$mbegin[1],$mend[1]]
> +    print $#match $#mbegin $#mend
> +  else
> +    print That didn\'t work.
> +  fi
> +0:Parameters associated with backreferences
> +>match 12 16 match
> +>1 1 1
> +
> +  string='and look for a MATCH in here'
> +  if [[ ${(S)string%%(#m)M*H} = "and look for a  in here" ]]; then
> +    print $MATCH $MBEGIN $MEND $string[$MBEGIN,$MEND]
> +    print $#MATCH
> +  else
> +    print Oh, dear.  Back to the drawing board.
> +  fi
> +0:Parameters associated with (#m) flag
> +>MATCH 16 20 MATCH
> +>5
>
> -- 
> Peter Stephenson <pws@csr.com>                  Software Engineer
> CSR Ltd., Science Park, Milton Road,
> Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070
>
>
> **********************************************************************
> The information transmitted is intended only for the person or
> entity to which it is addressed and may contain confidential 
> and/or privileged material. 
> Any review, retransmission, dissemination or other use of, or
> taking of any action in reliance upon, this information by 
> persons or entities other than the intended recipient is 
> prohibited.  
> If you received this in error, please contact the sender and 
> delete the material from any computer.
> **********************************************************************
>

-- 
In a minute there is time
For decisions and revisions which a minute will reverse.         T.S. Eliot
[URL: http://www.cs.amherst.edu/~ccm/prufrock.html]

Re: Test Failures

[Peter Stephenson]

Wayne Davison wrote:
> Not quite: it might reject any typeset -T without the new separator arg.
> The reason is that it checks if argv[3] is non-NULL, which is not a
> valid thing to do if argv[2] is NULL.  I just checked in a fix.

Thanks, that seems to fix both problems, though I'm not sure why...

Here's a more specific test for the new syntax.

Index: Test/B02typeset.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/B02typeset.ztst,v
retrieving revision 1.4
diff -u -r1.4 B02typeset.ztst
--- Test/B02typeset.ztst	6 Dec 2002 10:23:21 -0000	1.4
+++ Test/B02typeset.ztst	25 Sep 2003 09:36:48 -0000
@@ -195,6 +195,18 @@
 >i:n:n:e:r
 >outer
 
+ typeset -TU MORESTUFF=here-we-go-go-again morestuff '-'
+ print -l $morestuff
+0:Tied arrays with separator specified
+>here
+>we
+>go
+>again
+
+ typeset -T THIS will not work
+1:Tied array syntax
+?(eval):typeset:1: -T requires names of scalar and array
+
  local array[2]=x
 1:Illegal local array element assignment
 ?(eval):local:1: array[2]: can't create local array elements

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

Re: Test Failures

[Wayne Davison]

On Thu, Sep 25, 2003 at 04:06:07AM +0000, Bart Schaefer wrote:
> In the first case, it appears that typset -T now rejects an assignment to
> the scalar variable in the scalar+array pair, which previously was OK.

Not quite: it might reject any typeset -T without the new separator arg.
The reason is that it checks if argv[3] is non-NULL, which is not a
valid thing to do if argv[2] is NULL.  I just checked in a fix.

..wayne..

Re: Test Failures

[Bart Schaefer]

On Sep 24,  9:29pm, Vin Shelton wrote:
}
} ../../../src/zsh-2003-09-24-1942/Test/B02typeset.ztst: test failed.
} ../../../src/zsh-2003-09-24-1942/Test/Y02compmatch.ztst: test failed.

I'm getting the same two failures.  Both were introduced by applying the
patch in 19129.

In the first case, it appears that typset -T now rejects an assignment to
the scalar variable in the scalar+array pair, which previously was OK.

The second one I'd be more inclined to blame on 19105, as it seems to have
something to do with the PS1 prompt being written to the wrong stream;
but it definitely didn't begin happening until I applied 19129 ...

Incidentally, I'm getting these compiler warnings:

Src/init.c:1174: warning: `autoload_zlesetkeymap' defined but not used
Src/utils.c:3300: warning: no previous prototype for `ucs4toutf8'
Src/utils.c: In function `ucs4toutf8':
Src/utils.c:3322: warning: suggest parentheses around arithmetic in operand of |
Src/Zle/zle_main.c: In function `raw_getkey':
Src/Zle/zle_main.c:352: warning: unused variable `ti'

Test Failures

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

I'm getting 2 test failures on a zsh built from the latest CVS sources:

Error output:
(eval):typeset:1: -T requires names of scalar and array
Was testing: Tied parameters and uniquified colon-arrays
../../../src/zsh-2003-09-24-1942/Test/B02typeset.ztst: test failed.

and

Test ../../../src/zsh-2003-09-24-1942/Test/Y02compmatch.ztst failed: output differs from expected as shown above for:
 test_code m: list1
 comptest  $'tst \t'
Was testing: Match Error for "m:"
../../../src/zsh-2003-09-24-1942/Test/Y02compmatch.ztst: test failed.

Here are the entire test results:


[-- Attachment #2: check.out --]
[-- Type: application/octet-stream, Size: 5589 bytes --]

[-- Attachment #3: Type: text/plain, Size: 83 bytes --]


Peter, at least the first one seems to be a result of your changes.

HTH,
  - Vin

Test failures

[Felix Rosencrantz]

I'm seeing a couple test failures.

This is new and might be related to 11058:
*** /tmp/zsh.ztst.out.9344      Tue May  2 10:13:26 2000
--- /tmp/zsh.ztst.tout.9344     Tue May  2 10:13:27 2000
***************
*** 1,2 ****
  line: {tst a }{}
- MESSAGE:{no more arguments}
--- 1 ----
Test ./53completion.ztst failed: output differs from expected as shown above
for:
 comptest -c "$code" $'tst a \t'
Was testing: _arguments
./53completion.ztst: test failed.


The following failure has been around since the test was added April 19th.

*** /tmp/zsh.ztst.out.8907      Tue May  2 10:13:07 2000
--- /tmp/zsh.ztst.tout.8907     Tue May  2 10:13:07 2000
***************
*** 1,4 ****
  be could I I programme recorded that watching
! be could I I programme recorded that watching
! watching that recorded programme I I could be
  watching that recorded programme I I could be
--- 1,4 ----
+ I I be could programme recorded that watching
  be could I I programme recorded that watching
! watching that recorded programme could be I I
  watching that recorded programme I I could be
Test ./13parameter.ztst failed: output differs from expected as shown above
for:
  # it doesn't *say* these are case-insensitive without i...
  # I think this is a bug.
  foo=(I could be watching that programme I recorded)
  print ${(o)foo}
  print ${(oi)foo}
  print ${(O)foo}
  print ${(Oi)foo}
Was testing: ${(o)...}, ${(O)...}
./13parameter.ztst: test failed.


I'm building on Solaris 2.6 with gcc 2.8.1 and static libraries.  Though my
guess is that these might generic bugs or related to environment issues. 
Though
I haven't investigated.

-FR

__________________________________________________
Do You Yahoo!?
Send instant messages & get email alerts with Yahoo! Messenger.
http://im.yahoo.com/