From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33757-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18497 invoked by alias); 22 Nov 2014 18:01:48 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33757
Received: (qmail 4252 invoked from network); 22 Nov 2014 18:01:37 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:message-id:date:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=wxiHV438Z3q0mpiuChFrVog0zVJ5WNdAoOoB1+6Ewz0=;
        b=MkhtwKyGEdlGFigevccXCZ3sASBmg48/M3OsIjlCn+dxoXnUgHsC4lyHbaq8fSbj49
         uFoS5e+7QB9RRPTKdvcdoKBQoAdd0p0muUbAFIze2OJGoT9r68gjRY+LyZbdrrVKHbBd
         lykq2+VpFOfxpp+fxKIKCzDEaLEilhAeC7PFQIyK7pyLc+k7XONOrw0pvd8sjInBGeCj
         XjEPXeqVgbEav/v9/UZckaSh745j8nPrUzI5hMnOl3BvFWd12yCqOP03ihpP8Vvm4oLp
         6SCHJP8B/wdJnhsdIKimtqvUPwzE7PvZ/OlD4OuMRrOamajuIisQuDxKssUPqGpFWSa7
         KC2w==
X-Received: by 10.194.23.10 with SMTP id i10mr18461273wjf.11.1416679294960;
        Sat, 22 Nov 2014 10:01:34 -0800 (PST)
From: Daniel Hahler <dhahler@gmail.com>
X-Google-Original-From: Daniel Hahler <genml+zsh-workers@thequod.de>
Message-ID: <5470CF7C.2000707@thequod.de>
Date: Sat, 22 Nov 2014 19:01:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Mikael Magnusson <mikachu@gmail.com>
CC: zsh workers <zsh-workers@zsh.org>
Subject: Re: BUG: failure in "vcs_info prompt" aborts precmd function
References: <5470C427.4050805@thequod.de> <CAHYJk3S5pBBNnAKqyGRYq7KAstpSAJOPQRdbHjoKrurLKFbOcQ@mail.gmail.com>
In-Reply-To: <CAHYJk3S5pBBNnAKqyGRYq7KAstpSAJOPQRdbHjoKrurLKFbOcQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22.11.2014 18:51, Mikael Magnusson wrote:
>> I am using a precmd hook to setup my prompt and call "vcs_info 'prompt'" from there.
>>
>> When starting an interactive Git rebase, while the editor is still open, it will fail as follows:
>>
>>     VCS_INFO_get_data_git:208: no such file or directory: .git/rebase-merge/done
>>
>> While this bug can be fixed (I'll post a patch), I think it's still a bug that vcs_info aborts the precmd.
>>
>> Why is that?
>>
>> I have tried adding "set +e" and "|| true" before the call to vcs_info, but without success.
> 
> http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=33671 should fix
> this already.

Yes, it's likely to fix this, although it might not be necessary to replace that many occurrences.
Also, I don't know if "$(cat ..)" is as efficient as "$(< ..)". Does it use a subshell, or is it optimized?

Apart from that, I am still wondering why the error in vcs_info causes abortion of the precmd function?!


Thanks,
Daniel.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iD8DBQFUcM98fAK/hT/mPgARAtCqAJ0abLfgdxHjoAfYGYy/Lm1iTHbSjgCfZPWU
e0OaBNs5nttKfMpBinP+A9E=
=vmxC
-----END PGP SIGNATURE-----