zsh-workers
 help / color / mirror / code / Atom feed
From: Bernhard Tittelbach <xro@realraum.at>
To: Bart Schaefer <schaefer@brasslantern.com>,
	"zsh-workers@zsh.org >> Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: zsh history bug ?
Date: Fri, 12 Dec 2014 10:48:36 +0100	[thread overview]
Message-ID: <548AB9F4.9080608@realraum.at> (raw)
In-Reply-To: <141210091937.ZM11958@torch.brasslantern.com>

Am 2014-12-10 um 18:19 schrieb Bart Schaefer:
> On Dec 10,  6:23am, Bernhard Tittelbach wrote:
> } Subject: Re: zsh history bug ?
> }
> } Am 2014-11-14 um 02:51 schrieb Mikael Magnusson:
> } > On Fri, Nov 14, 2014 at 2:34 AM, Bernhard Tittelbach <xro@realraum.at> wrote:
> } >>
> } >> I've been working a few days with 5.0.7 now and can report the following:
> } >>
> } >> 1) I seem to encounter the bug less often
> } >> 2) The bug, or a variant thereof is still present
> } >>
> } >> i.e.:
> } >>
> } >> % mkdir -p libs/jquery
> } >> % cd <Alt>.
> } >> resulted in
> } >> % cd lib/jquuery
>
> I'm not able to reproduce this on MacOS (the platform where the bug
> originally was reported, IIRC).
>
> Here was the patch:
>
> 2013-09-26  Barton E. Schaefer  <schaefer@zsh.org>
>
>         * 31770: Src/hist.c: memmove() instead of memcpy() for overlapping
>         regions.
>
> I've re-checked Src/hist.c and there are no other cases where memcpy() is
> being used except with a newly-allocated buffer as the destination (so, no
> overlapping regions).
>
> } >> When I previously encountered the bug, I believe only the lookup from
> } >> history was garbled, i.e. the contents of .zsh_history were fine.
> } >> I'll have to confirm this on a different system though.
>
> Are you sharing history via a network-mounted home directory from 
> multiple hosts?
The home directories are on local drives only.
I don't share history between computers at all.

>
> } >> Now the .zsh_history definitely holds a garbled version of the executed
> } >> command line:
> } >>
> } >> % ls
> } >> libs/
> } >> % ls libs/
> } >> jquery/
> } >> % tail  ~/.zsh_history | grep mkdir
> } >> : 1415928181:0;mkdir -p lib/jquuery
> } > Check if setopt nohistreduceblanks stops the problem.
> } >
> } Alright, I've not encountered the bug for quite some time now,
> } your suggestion worked!
>
> Can you give us some additional details of the OS and hardware where you
> are seeing this error?  The remaining possibility is that your build of
> zsh does not define HAVE_MEMMOVE *and* the implementation of its
> replacement (which might be bcopy(), or might be a macro in the system
> headers) does not properly handle overlapping pointers.
sure..
There are two running Ubuntu x86_64. One CoreDuo Laptop, one Core i5
Desktop.

I also have an old Pentium4 machine running Gentoo i686 and an Eeebook
running Ubuntu i686 with the same zsh config.
I don't think I've ever encountered the bug on these i686 machines, but
then I don't use these very often.
Thus It's hard to tell if the bug is present there, since it only
appears sporadically and is hard to reproduce.

Originally, on the x86_64 machine, I was running zsh 5.0.3 from the
Ubuntu Package,
but per your suggestion I compiled 5.0.7 from source last month. The bug
persisted until
Mikael suggested setting "nohistreduceblanks" i.e. disabling
"histreduceblanks"

Since then I've not encountered the bug anymore or at least the bug has
become so seldom
I've not encountered it yet again within the last month. Previously It
appeared about once in a day of work on the shell.




  reply	other threads:[~2014-12-12  9:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 23:09 Bernhard Tittelbach
2014-11-05  0:12 ` Bart Schaefer
2014-11-14  1:34   ` Bernhard Tittelbach
2014-11-14  1:51     ` Mikael Magnusson
2014-12-10  5:23       ` Bernhard Tittelbach
2014-12-10 17:19         ` Bart Schaefer
2014-12-12  9:48           ` Bernhard Tittelbach [this message]
2014-12-12 10:01             ` Mikael Magnusson
2014-12-12 10:11               ` Bernhard Tittelbach
2014-12-12 12:24                 ` Mikael Magnusson
2014-12-20  1:54                   ` Bernhard Tittelbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548AB9F4.9080608@realraum.at \
    --to=xro@realraum.at \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).