From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12309 invoked by alias); 9 Jan 2015 21:39:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34190 Received: (qmail 5424 invoked from network); 9 Jan 2015 21:39:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-Authority-Analysis: v=2.1 cv=X+5rdgje c=1 sm=1 tr=0 a=U8x73H08pUQ9rBATJ7Nnpg==:117 a=U8x73H08pUQ9rBATJ7Nnpg==:17 a=Hpgzp-inWqAA:10 a=IkcTkHD0fZMA:10 a=BOiQuH4kUKkTeZeCuBkA:9 a=QEXdDO2ut3YA:10 a=g1XB5UGMEisA:10 a=tyrY1NgniJcA:10 Message-id: <54B04A7A.1010402@eastlink.ca> Date: Fri, 09 Jan 2015 13:39:06 -0800 From: Ray Andrews User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-version: 1.0 To: Mikael Magnusson Cc: zsh workers Subject: Re: PATCH: hist: remove wrong NULL terminator References: <1420807419-9270-1-git-send-email-mikachu@gmail.com> <54B013C5.6090307@eastlink.ca> In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit On 01/09/2015 11:38 AM, Mikael Magnusson wrote: > Yes, but it's actually pretty harmless, most other variables on the > stack in that function are never used if we enter this codepath. I guess so, since otherwise there'd be crashes all over the place. Still, it has a lethal look about it. Trying to understand the culture of the project I find myself wondering how things like that pass unnoticed, given the unquestioned skill level of the people involved.