From: Daniel Hahler <genml+zsh-workers@thequod.de>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: [PATCH] __git_commit_objects_prefer_recent: local ret
Date: Thu, 21 May 2015 20:37:38 +0200 [thread overview]
Message-ID: <555E25F2.5080602@thequod.de> (raw)
In-Reply-To: <150521110516.ZM27844@torch.brasslantern.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 21.05.2015 20:05, Bart Schaefer wrote:
> On May 21, 7:30pm, Daniel Hahler wrote:
> }
> } Without this, `ret` will be set to 1 with `git diff --ex<tab>` and
> } result in duplicate entries:
> }
> } I am not sure if this is the right way to do it.
>
> Wouldn't it make more sense to put "local ret" in _get_recent_commits ?
>
I'm not sure - I've thought it was not used there on purpose, for when it gets called
for --fixup and --squash?
_arguments -w -S -s \
'(-a --all --interactive -o --only -i --include *)'{-a,--all}'[stage all modified and deleted paths]' \
'--fixup=[construct a commit message for use with rebase --autosquash]:commit to be amended:__git_recent_commits' \
'--squash=[construct a commit message for use with rebase --autosquash]:commit to be amended:__git_recent_commits' \
But putting it there appears to work, too.
Regards,
Daniel.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iD8DBQFVXiXyfAK/hT/mPgARAsOXAKD35BaKCpszaRvmQaOygaMa4Pe3TgCgw+PD
ErPUBrNevfJG+46hYtIfx4k=
=zoKe
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-05-21 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 17:30 Daniel Hahler
2015-05-21 18:05 ` Bart Schaefer
2015-05-21 18:37 ` Daniel Hahler [this message]
2015-05-21 21:07 ` Bart Schaefer
2015-05-21 23:04 ` Daniel Hahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E25F2.5080602@thequod.de \
--to=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).