From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 16c055d7 for ; Sat, 12 Jan 2019 19:08:51 +0000 (UTC) Received: (qmail 12729 invoked by alias); 12 Jan 2019 19:08:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43992 Received: (qmail 21924 invoked by uid 1010); 12 Jan 2019 19:08:38 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f194.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.166.194):SA:0(-2.0/5.0):. Processed in 2.592143 secs); 12 Jan 2019 19:08:38 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o0CVJsavnvjXYwO89mK2BdrsVuGd45VO6WeFOCgnbes=; b=wM7tYH965mzeYPDJxi1eNjOAOs5qqiGsxkS9CXBmuW0wVuRrLMQyIBVBtScWSPSu8/ jO86Z9A+9DNjk8Yj6SY2uowQEma0D9Q2Kvr9iX1j30z2+vPJTNbjgZ5MkvsKJjM/TSIX lr+8FlaegNtHf4INq+x/avVplhDXsyjoq2DtJcEcWa80zqao2iJSPi1/VaK9x7Q0IouV RY+hW/zwt9lZ6riNsnD2oA0EqeuskSDnZUA9+ecNrl5IpaQ3ghxZpgBFstEYwGSVlCQ2 0ZuaQpAhJP6md0MIE2t4Ys18O5UXEBCW3eYvMtQBYRa3ec6hSiz/KJV1B+YLi5dW+QnL ZCMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o0CVJsavnvjXYwO89mK2BdrsVuGd45VO6WeFOCgnbes=; b=n1tOvTx5XOC+nIwERtxrnno0Guuqi6U4Sts2aVlAljzYuqdiGRUVL8QIHvK83H5jTh F2coAUGFctUz+rwtq77fiPXK0AXlUMiKwMiWPTPeB60izci7Mvshk1nvovsWtv3M02Kl GMcSfm/06USBCQV2/y9lSNgUSEVhgM1SsIfz9GQJQs3mrl6H75Roxe5W30ddASJh0oRz 94XnHjOHknqxEXamX+aRmzlAU2PWJP8A8gsjaLvCI5LBuOeKVvOP8/aF130NyXnQaD0q +0+QgdIK8KmadjqImBqB6vyyxSs5obpbDSiE2fAvvC6dNZK6M3t46aDsY17jX6UqAUE3 R5tw== X-Gm-Message-State: AJcUukekOyCrgzwvugJIWJHmyOjP1dIoNDcg2Qn6z0jpR2wN90pj/Xsa J3c3vXyjBpwvFduyAmVNlRW74g== X-Google-Smtp-Source: ALg8bN4IsnLTgk8UsIbQDIpNLDPvwr48au/Inkr3mJ3CPZv1ASEJHCVOnEVdzoEyBoPHixT47rsQ7Q== X-Received: by 2002:a02:b381:: with SMTP id p1mr13090028jan.46.1547320112427; Sat, 12 Jan 2019 11:08:32 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: [PATCH] Completion: _opkg: Support gain-privileges From: dana In-Reply-To: <20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2> Date: Sat, 12 Jan 2019 13:08:30 -0600 Cc: Zsh workers Content-Transfer-Encoding: quoted-printable Message-Id: <55BD7A82-303D-4C2A-AF6F-350EF34E5E57@dana.is> References: <20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2> To: Daniel Shahaf X-Mailer: Apple Mail (2.3445.100.39) On 12 Jan 2019, at 11:10, Daniel Shahaf wrote: >I don't think so. Even an "empty" result could be expensive to = compute: >for example, it might require a network round-trip. I think _opkg >shouldn't call _store_cache when _call_program returns non-zero. Well, i think that's effectively the same thing in this case and certain others i'm imagining. (Or at least i assume so; there's not really any documentation for opkg that i'm aware of, so who knows what actually = causes it to return non-zero.) Just felt like it might save some boiler-plate, = which the caching logic is extremely heavy in already, to have a standard option = handle it. I can just add the guard to each _store_cache call myself, though, = obv dana