From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: (qmail 2723 invoked from network); 4 May 2020 08:27:29 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 4 May 2020 08:27:29 -0000 Received: (qmail 735 invoked by alias); 4 May 2020 08:27:16 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45776 Received: (qmail 5743 invoked by uid 1010); 4 May 2020 08:27:16 -0000 X-Qmail-Scanner-Diagnostics: from smtpq2.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25801. spamassassin: 3.4.4. Clear:RC:0(212.54.57.97):SA:0(-2.7/5.0):. Processed in 3.79597 secs); 04 May 2020 08:27:16 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.97 as permitted sender) X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.133 X-CNFS-Analysis: v=2.3 cv=IPGZ9jnG c=1 sm=1 tr=0 a=ShKnLeKYHz8gHcl3UCxcnw==:117 a=KEnZaF_ea6UA:10 a=IkcTkHD0fZMA:10 a=DoY9bV0jb9AA:10 a=4rQ-kO_E8r7l9gNGjsAA:9 a=QEXdDO2ut3YA:10 X-Authenticated-Sender: p.w.stephenson@ntlworld.com Date: Mon, 4 May 2020 09:26:32 +0100 (BST) From: Peter Stephenson To: zsh-workers@zsh.org Message-ID: <565211161.147978.1588580792624@mail2.virginmedia.com> In-Reply-To: <20200503212325.2fda9b66@tarpaulin.shahaf.local2> References: <20190518075514.hbygmb5dl5wz23h5@chaz.gmail.com> <20190520103444.qyih7lvoigvf3rfx@chaz.gmail.com> <1563722540.4311.24.camel@samsung.com> <1565710707.5633.11.camel@samsung.com> <309829031.4459446.1587391766024@mail2.virginmedia.com> <20200503212325.2fda9b66@tarpaulin.shahaf.local2> Subject: Re: Feature request: ZSH_XTRACEFD variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev69 X-Originating-IP: 165.225.81.56 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4wfEKsrN6KLRFg+rRgS9X80z776KdYx11IOKeyX55pLswxkID8HLYSHCcvIK/um10CjWtvqPYzNuj+d6ImPSaCYamhDifNdzkH0efe50VKPWvJmTPTKY2K NAZ2p2l2VUBPMFG1GBVBZGwhrir4B3D0OThrVFkkgRwosR9kdyo3N9YjzuKg9DC1JnLKyKm37/tDENN5y4XitilVe1z+RUIGm8g= > On 03 May 2020 at 22:23 Daniel Shahaf wrote: >=20 >=20 > Peter Stephenson wrote on Sun, 03 May 2020 18:30 +0100: > > On Sat, 2020-05-02 at 20:02 +0200, Timoth=C3=A9e Mazzucotelli wrote: > > > I wrote such a test and noticed that file descriptors were being > > > closed each time ZSH_XTRACEFD was (re)assigned, even as a local > > > variable. So I removed the code lines closing the previous file > > > descriptor in xtracefdsetfn, and it seemed to work well. =20 > >=20 > > This re-introduces the file descriptor leak I was at pains to remove. > > It apparently works because the test isn't sensitive to the leak --- > > that's hard to fix in a standard way, i.e. with1out having some limit y= ou > > can rely on on file descriptors being created. > >=20 >=20 > Which test is that? I'm thinking of 45760, but actually it's explicitly testing for closed file descriptors (rather than looking for a leak), so that should be on the right lines. I'll look a bit more closely to check what's going on when I get a chance --- I'm evidently missing aspects of how this fits together anyway. pws