From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-37557-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 25060 invoked by alias); 10 Jan 2016 22:22:41 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 37557
Received: (qmail 15940 invoked from network); 10 Jan 2016 22:22:39 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=googlemail.com; s=20120113;
        h=subject:to:references:cc:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-type:content-transfer-encoding;
        bh=YwobfEGhko0JQkeE7CLYE+zETDZKbtqxxX5WH7jkZy0=;
        b=cdwTP4PuXPIUi0SLj/AuSDg4hxMK4BGp7R41AlqewV27R3OtuKV66OkIE+15O4SDt7
         VZrbsyS8r8VOe7JCPKkJSUeD8iHPS37jXp4zBS8vIa5crrNOOzfOJrHC7REcGZPywdoX
         esu4iCwVJ9AX20REhse/YwLmIFOFNk8xqOAw2HRiHNSBTOa8Ep8s7LnAXZ1kUpGqCXLW
         18APGkx9pUMxhclN4BpORdnhtU9WkKDlnmpjsB6NEaNoT2Tyv4CZtyeO4meGUL0FXwUI
         FqL2fpDHJJFlamRpk81elmJPhyeAh0VZrHpLZvXoQtkzKlfTdURAaHOGojnRafo43ik9
         NpNw==
X-Received: by 10.28.12.9 with SMTP id 9mr10474440wmm.76.1452464246140;
        Sun, 10 Jan 2016 14:17:26 -0800 (PST)
Subject: Re: PATCH: Add zle-line-pre-redraw hook for highlighting
To: Daniel Shahaf <d.s@daniel.shahaf.name>,
 Bart Schaefer <schaefer@brasslantern.com>
References: <CAHYJk3QvRnYxLMb8XsoWB1hU92Qti_fEKt1JgxkyDARrhf1g7g@mail.gmail.com>
 <1450245754-2760-1-git-send-email-mikachu@gmail.com>
 <CAH+w=7btpFWXkgHFjHwMFWZcrVu-ap5+=PAkeidze8NJsz+SoA@mail.gmail.com>
 <20151219094913.GF2358@tarsus.local2>
Cc: Mikael Magnusson <mikachu@gmail.com>,
 Zsh hackers list <zsh-workers@zsh.org>
From: m0viefreak <m0viefreak.cm@googlemail.com>
X-Enigmail-Draft-Status: N1110
Message-ID: <5692D87E.20304@googlemail.com>
Date: Sun, 10 Jan 2016 23:17:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20151219094913.GF2358@tarsus.local2>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit



On 19.12.2015 10:49, Daniel Shahaf wrote:
> Bart Schaefer wrote on Wed, Dec 16, 2015 at 00:05:01 -0800:
>> On Dec 15, 2015 10:27 PM, "Mikael Magnusson" <mikachu@gmail.com> wrote:
>>> I haven't received any complaints about 36650 from testers, so I'll go ahead
>>> and push this.
> 
> Hooray!
> 
> This should fix between 2 and 5 z-sy-h issues:
> https://github.com/zsh-users/zsh-syntax-highlighting/issues/245

One remaining issue with this approach is the fact that this new hook is
not triggered when a minibuffer such as isearch is active and BUFFER
changes.

Is it possible to add support for that, too?

I don't know the zle internals very well, and I couldn't figure out the
right spot to place a call to the hook without causing performance
issues due to multiple (useless) calls.