From: Eric Cook <llua@gmx.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: Bug in completion for git merge
Date: Tue, 16 Feb 2016 09:08:37 -0500 [thread overview]
Message-ID: <56C32D65.4070902@gmx.com> (raw)
In-Reply-To: <20160216104941.GA16066@tarsus.local2>
On 02/16/2016 05:49 AM, Daniel Shahaf wrote:
> I don't have a strong opinion regarding the specific patch. It's
> obviously correct.
>
> However, what should we do with the other instances of the
> backwards-incompatible syntax that are currently in Completion/ and
> Functions/?
>
> If we want to make $fpath backwards-compatible, we'd need to change all
> of them and stop adding new instances of backwards-incompatible
> syntaxes... which effectively means we'd stop eating our own dogfood.
I wasn't trying to imply that fpath should be backwards compatible indefinitely
or that using completers from master with older shells is the smartest of ideas*.
Just that in this particular instance, since the completer has already long used
typeset in the old way; that reverting this one would make typeset's usage consistent
throughout this sole function.
* Even i've picked individual completers from master that i knew fixed bugs like
users/20219, discarding them once i have a newer release on that machine.
next prev parent reply other threads:[~2016-02-16 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 15:41 Thomas Becker
2016-02-15 16:58 ` Bart Schaefer
2016-02-15 17:20 ` Thomas Becker
2016-02-16 3:02 ` Eric Cook
2016-02-16 10:49 ` Daniel Shahaf
2016-02-16 14:08 ` Eric Cook [this message]
2016-02-16 10:49 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C32D65.4070902@gmx.com \
--to=llua@gmx.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).