From: Marlon Richert <marlon.richert@gmail.com>
To: dana <dana@dana.is>
Cc: Bart Schaefer <schaefer@brasslantern.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH][RFC] Improve completion of Gradle tasks
Date: Sat, 7 May 2022 09:03:40 +0300 [thread overview]
Message-ID: <56E0F77E-5855-465F-8B78-7876B0898FB4@gmail.com> (raw)
In-Reply-To: <e288b6d0-c76e-482d-92e2-630b971ff49b@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
> On 7 May 2022, at 07:24, dana <dana@dana.is> wrote:
>
> On Fri 6 May 2022, at 21:57, Bart Schaefer wrote:
>> Any objections to this sneaking into 5.9, despite .3-test already spun?
>
> I don't know anything about Gradle, so i'm not sure if the way it handles
> task completion is desirable.
The old task completion logic was too strict: There were many real-world task names that it did not complete. Also, the logic was actually incorrect: There were some forms of names that it did not allow, but which are explicitly allowed in Gradle’s spec.
> But i didn't see anything obviously wrong
> with the patch, and it's not a critical component, so i don't object in
> principle
Great! :)
> I did note these pre-existing issues which might be fixed in a future
> revision:
Yes, I noticed these, too. I will have a look at fixings them sometime in a future patch.
[-- Attachment #2: Type: text/html, Size: 1708 bytes --]
prev parent reply other threads:[~2022-05-07 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 6:19 Marlon Richert
2022-05-06 5:51 ` Marlon Richert
2022-05-07 2:57 ` Bart Schaefer
2022-05-07 4:24 ` dana
2022-05-07 6:03 ` Marlon Richert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E0F77E-5855-465F-8B78-7876B0898FB4@gmail.com \
--to=marlon.richert@gmail.com \
--cc=dana@dana.is \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).