From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, MIME_QP_LONG_LINE,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4604 invoked from network); 7 May 2022 06:04:21 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 May 2022 06:04:21 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1651903461; b=kPXDW14aaqaay1uI8L15EMoOUsmzEUZanLpPPPe6CtZJkgvEc/qi98Ae17aNhD0NWRD7Jfzzb2 iWUbv6QGRzRF95ry54SUoknzqW0EPYt8Tb9x6ulQmMZt7CksRU7OxpzNW0LE7Q5GQ6xvEZS/0h dymXg6OfX6iSNqbiwubuHpGvz4dgh/T3/1t9ISaKZ0oHcSRcbpZmnjbm9v5DMMHooNqQ2Gi+ZG MAg1ruo9TirekzJ8sQanzDV36wdwGw6vqjl36gQwMQiN4jyKi6VTdhIykCNiDxtaW4v5Pc3tct WkrQ2T6XI3dM+NPqKfb72UuQtQvjeuaxiaRKZpmDuErS7w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f45.google.com) smtp.remote-ip=209.85.167.45; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1651903461; bh=gMM5WJ5sFkpj2m1DmT5+lC0PckIPuVuxEX2S1RTbH+k=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:To:In-Reply-To:Cc:References:Message-ID:Date:Subject: MIME-Version:From:Content-Transfer-Encoding:Content-Type:DKIM-Signature: DKIM-Signature; b=c3UOGkVc76m4BNFQ1grxhErxgpUBI86sjSonVlkO9ozeqIA6tqmaNkz5riP3PiD3xXqIh0yxA6 NoFlFGvPfpS48wG2rTok59TvXsvxAo60ALqgQN3qb2xiInERNSfesyy1luICXuozQRnYKo6Bwn vkvNRRDhSIS3Lv8OuXP7RpITzHdo9ZljCNGywi7C6/2XVN0zDRi9BSY5izADXx/+yYx/63/0t1 lgY08V8gJsVVkIFzFWwvExErN8WGUS9o3EwkxRcoFmFdZ5hCE63Z7PdFYxAeOvXUvvt4Rk/uEI JeA92+r8H8kfEM7j4Zyfnm8Nbr9A0xDKttNJHn7iP0p+9Q==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:To:In-Reply-To:Cc:References: Message-Id:Date:Subject:Mime-Version:From:Content-Transfer-Encoding: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=H9OlDj4frwEPMN0rXg2QiTGlFT6C0ZCzMU+uoEUkcPs=; b=E6h40TFFCWX2hVT9Obg8ectZ9U DWVCLbBoPfNSR/YoAXYC6NHtskmy+H1RwVYHNiXHHYNzbKoMM+X66GwkO75GVrwEtXrpXJUeiwElF j4mv8dOIkwk5m162dMWzhauB9J701OLd08cBpsrKFanLoIu+f4Qh7yTEDPyMEvECqHi9ISpdVu6HJ lsCGtmsUZydhlPrzww/asogkP8KDLfL5qF+FTTA0LADhnSGwOM2CBn2PdayvWRO/9IDhrIAsIB60i JD9Oe1c+GESoBwGUcNv2jbkNQMkZ9CkEYPyduWjpPkTWw7Q80Y+SV4FZ90elbSnak1lsLhN6ZH+Xh +o2uEylQ==; Received: from authenticated user by zero.zsh.org with local id 1nnDYB-000BYh-8o; Sat, 07 May 2022 06:04:19 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f45.google.com) smtp.remote-ip=209.85.167.45; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f45.google.com ([209.85.167.45]:37593) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nnDXc-000BEb-EA; Sat, 07 May 2022 06:03:45 +0000 Received: by mail-lf1-f45.google.com with SMTP id w1so15749966lfa.4 for ; Fri, 06 May 2022 23:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=H9OlDj4frwEPMN0rXg2QiTGlFT6C0ZCzMU+uoEUkcPs=; b=UrVxFp7fesRtcXshvXOEVNg32/cxefR8mXExWBdr/qgCYSfI0veEkrmoET1tUb8nzY 0jYafpTbFXarCcn1Pf2aviSTTbYnd14X72l80Ho1EXv9dWNTdZnBKNuKsurWQL0gsRuQ H5XKDwUCaYUgKBkIf3+ClzuqMUhKzU+20Vk3lqBCmCH8X7XPW6ZTd09NBpJm+Ol8CfhZ WQucMoWOUtEqPczIcthMTvZhLus/qaqPR/RWaRv8x7GBtvR/A0FYcfNINxCIyNYj64QB RRZHPCfGWxd3lVN12soUKprG0jxeduTJ9iAkPD1yXZBsOUUJwdJHXVZO4bwdxb/SYuHm gIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=H9OlDj4frwEPMN0rXg2QiTGlFT6C0ZCzMU+uoEUkcPs=; b=vfaOWAVRfQwDkgtoR8YmfogGQX53uSZ5CCelJWyVvbztb357jbQfbJ2U6gjrhY0EHW nAJd2R+gthE0c7CDmcGQiYW5vHaGGbqOs1U5BPBCjqqz8uz324yISNymzWCEk4qGgwRY 6T0pGxGyxHr4INr3L1t9W6O/tylfMLjnXF/SBz0YCmOIyFlCkgfv/J40VHvh+olPRnp1 0zTxEbcFvyvLgOsLjpgPbmjDzlMMNAtJdzqFxsq+dPPGq/yd5ObwjkKMZZsB1sP44Sjx gjqvQkSMnh64iTWtoGmilX4G9urEJTt/7c7QBfd6vLRZA+Cxi3+HZ2xO+ZpORCHlukUE vimg== X-Gm-Message-State: AOAM531Ih1jmnWI5KDj0IXM+YXeIdKQAJeWl7sLqQOOXAbCKBpZdMp62 7F6/J1JLELLG7wLGmdsqRJGdNPVEfMI= X-Google-Smtp-Source: ABdhPJxbcvpYZ+lbqxCP409fq7PoPTl1dMNvyRg19bD5cdoPgJihPcTZaGJwiFM881n1pjJyACQgow== X-Received: by 2002:a05:6512:118f:b0:473:b226:b832 with SMTP id g15-20020a056512118f00b00473b226b832mr5080272lfr.5.1651903423026; Fri, 06 May 2022 23:03:43 -0700 (PDT) Received: from smtpclient.apple (178-55-190-91.bb.dnainternet.fi. [178.55.190.91]) by smtp.gmail.com with ESMTPSA id f7-20020a19dc47000000b0047255d21143sm967162lfj.114.2022.05.06.23.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 May 2022 23:03:41 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-D6104379-F4DA-404A-867B-FB792D20E8F8 Content-Transfer-Encoding: 7bit From: Marlon Richert Mime-Version: 1.0 (1.0) Subject: Re: [PATCH][RFC] Improve completion of Gradle tasks Date: Sat, 7 May 2022 09:03:40 +0300 Message-Id: <56E0F77E-5855-465F-8B78-7876B0898FB4@gmail.com> References: Cc: Bart Schaefer , Zsh hackers list In-Reply-To: To: dana X-Mailer: iPhone Mail (19E258) X-Seq: 50182 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --Apple-Mail-D6104379-F4DA-404A-867B-FB792D20E8F8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > On 7 May 2022, at 07:24, dana wrote: >=20 > =EF=BB=BFOn Fri 6 May 2022, at 21:57, Bart Schaefer wrote: >> Any objections to this sneaking into 5.9, despite .3-test already spun? >=20 > I don't know anything about Gradle, so i'm not sure if the way it handles > task completion is desirable. The old task completion logic was too strict: There were many real-world tas= k names that it did not complete. Also, the logic was actually incorrect: Th= ere were some forms of names that it did not allow, but which are explicitly= allowed in Gradle=E2=80=99s spec. > But i didn't see anything obviously wrong > with the patch, and it's not a critical component, so i don't object in > principle Great! :) > I did note these pre-existing issues which might be fixed in a future > revision: Yes, I noticed these, too. I will have a look at fixings them sometime in a f= uture patch. --Apple-Mail-D6104379-F4DA-404A-867B-FB792D20E8F8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On 7 May 2022, at 07:2= 4, dana <dana@dana.is> wrote:

=EF=BB=BFOn Fri 6 May 2022, at 21:57, Bar= t Schaefer wrote:
Any objections t= o this sneaking into 5.9, despite .3-test already spun?

I don't know anything about Gradle, so i'm not sur= e if the way it handles
task completion is desirable.

The old task completion logic was too strict: There w= ere many real-world task names that it did not complete. Also, the logic was= actually incorrect: There were some forms of names that it did not allow, b= ut which are explicitly allowed in Gradle=E2=80=99s spec.

But i didn't see anything= obviously wrong
with the patch, and it's not a critical com= ponent, so i don't object in
principle

Great! :)

I did note these pre-existing issues which mig= ht be fixed in a future
revision:

Yes, I noticed these, too. I will have a look at fixings them so= metime in a future patch.


= --Apple-Mail-D6104379-F4DA-404A-867B-FB792D20E8F8--