From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh workers <zsh-workers@sunsite.dk>
Subject: Re: Completion in pwd before subdirecories
Date: Mon, 15 Dec 2003 19:56:04 +0100 [thread overview]
Message-ID: <5719.1071514564@gmcs3.local> (raw)
In-Reply-To: <1031215170258.ZM12804@candle.brasslantern.com>
Bart wrote:
> On Dec 15, 12:49pm, Oliver Kiddle wrote:
> }
> } zstyle ':completion:*' file-patterns \
> } '*(-/):directories %p(^-/):globbed-files' '*:all-files'
> }
> } Unfortunately, that will now break for any completion which specifies a
> } glob qualifier such as _chown.
>
> Are you sure about that?
No. Sorry, didn't test it so based on what you say below, I'm probably
wrong.
> There's code in _files to attempt to merge together any trailing stuff
> that looks like glob qualifiers, because _files predates the #q flag.
> In fact, I'm suspicious that adding #q might actually break things.
I'll have to test. I seem to remember it not working once in the past.
> } I'm not quite sure whether the default file-patterns style shouldn't
> } use %p(^-/) for globbed-files anyway.
>
> I don't think I understand the question.
For that you need to look back at the original question on -users and
look at why the file-patterns style above was needed. Patterns like *
match directories so the directories were completed twice. This meant
the directory got completed in the globbed-files group before the
directories group was reached. Working out that the file-patterns style
is needed and why is not obvious. So I wondered whether the default
file-patterns style shouldn't be this.
> Are you suggesting that we should split the existing globbed-files default
> into globbed-files and globbed-directories? I.e., so that instead of the
I wasn't suggesting that but it is an idea that may be worth thinking
about.
> } What if we want to glob directory names from a completion function?
>
> I'm not making the connection between that question and the previous one.
>
> However, nothing stops any completion function from doing something like
>
> zstyle -m ":completion:${curcontext}:" file-patterns '*' ||
> zstyle ":completion:${curcontext}:" file-patterns \
> '%p(-/):directories %p(^-/):globbed-files' '*:all-files'
>
Doing that from every completion function which just wants to glob for
a certain file extension is not pleasant.
It has never seemed ideal to me that, for example, gunzip completion
will complete a directory called dir.gz even if the user has
directories after files in their file-patterns style. Ideally we should
tidy things up from the completion functions and not expect user's to
set the file-patterns style for every command.
For the majority of commands we use something like _files -g '*.gz' to
specify a filename extension. These should ideally not match
directories. For some commands like chown, we use a more complex glob
where it is valid to match directories (though some user's may still
want directory completion deferred).
One option might be for _files to add the (^-/) when substituting
%p and to add a -/g option to suppress this when the glob should also
match directories. We could even have other escapes in addition to %p
which give the user more control. A user who relies on _next_tags to
get at directories may want explicitly globbed directories first for
commands like chown.
Oliver
next prev parent reply other threads:[~2003-12-15 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031213154651.GR18859@strindberg.dsv.su.se>
[not found] ` <1031213191918.ZM5325@candle.brasslantern.com>
[not found] ` <20031213233905.GW18859@strindberg.dsv.su.se>
[not found] ` <3213.1071488991@gmcs3.local>
2003-12-15 17:02 ` Bart Schaefer
2003-12-15 17:09 ` Peter Stephenson
2003-12-15 19:13 ` Bart Schaefer
2003-12-15 18:56 ` Oliver Kiddle [this message]
2003-12-15 19:37 ` Bart Schaefer
2003-12-15 20:07 ` Oliver Kiddle
2003-12-15 21:41 ` Bart Schaefer
2003-12-16 11:23 ` Oliver Kiddle
2003-12-17 15:57 ` Oliver Kiddle
2003-12-17 18:38 ` Bart Schaefer
2003-12-18 9:47 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5719.1071514564@gmcs3.local \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).