zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <opk@zsh.org>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Remove redundancies from `git` completion
Date: Thu, 02 Sep 2021 23:17:27 +0200	[thread overview]
Message-ID: <57435-1630617447.454477@LS39.frll.UgLV> (raw)
In-Reply-To: <CAH+w=7ZiZFeJXV_G0RYQqMPB9BzQLEgJKtC0azftX-fM2Oy+0w@mail.gmail.com>

Bart Schaefer wrote:
> On Thu, Sep 2, 2021 at 1:51 PM Oliver Kiddle <opk@zsh.org> wrote:
> >
> > This particular test was rather annoying before $functions_source
> > existed because it made it more difficult to fully reload all _git
> > functions.
>
> I can't tell if you're arguing for simply removing the test, or for
> exploding all the functions into their own files (which I think would
> necessitate another layer of subdirectory, just for sanity).

For the sake of sanity (and consistency), I'd keep it in the single
file.

I wouldn't object to removing the tests, either wholesale or selectively.
But I'm not inclined to be proactive about removing them either.

Oliver


  reply	other threads:[~2021-09-02 21:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 11:17 Marlon Richert
2021-08-30 11:41 ` Mikael Magnusson
2021-08-30 12:34   ` Marlon Richert
2021-08-30 12:42     ` Mikael Magnusson
2021-08-31  5:52       ` Marlon Richert
2021-09-01 14:03         ` Daniel Shahaf
2021-09-01 18:22           ` Bart Schaefer
2021-09-02  6:17             ` Marlon Richert
2021-09-02 20:51               ` Oliver Kiddle
2021-09-02 20:54                 ` Bart Schaefer
2021-09-02 21:17                   ` Oliver Kiddle [this message]
2021-09-01 13:56 ` Daniel Shahaf
2021-09-02  8:57   ` Marlon Richert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57435-1630617447.454477@LS39.frll.UgLV \
    --to=opk@zsh.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).