From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 6756 invoked from network); 2 Sep 2021 21:17:43 -0000
Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368)
  by inbox.vuxu.org with ESMTPUTF8; 2 Sep 2021 21:17:43 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org;
	s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:
	List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID:
	Content-Type:MIME-Version:Subject:To:References:From:In-reply-to:Reply-To:Cc:
	Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From:
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID;
	bh=I1txtvoqeAL5LhU1iDi3NsemR2DOFpvBf+U7ld8io5Y=; b=LIjCCNvrX96ysYmvl84VGPB2u3
	QVcVRT99VJRHwhU2w2cY9ThGcinEkFme9WZYUKR6n18SseFJWqGnRzdpXeO0+RPA6kLTQraswACpn
	fsIpOR9sK6pw5m+fJSAf21ebgQwInsJ2IdqACrjwofEBke3ev1bpEE2rGEn0oQ6vZ5aRgjgLYEh9o
	V8sEaXdtHezn/60ussZCujBToiK32Qn6Psh+uZpM1kM0MI4CaqJVtyKkCwyyVAEy446K/4ugKUrN1
	K+EXCdHXMhNnyqjOEYjnuroq/E45uUhI1pzZ0xtKnDaCDCpjJ/46q8q/2ExfN+GacqU7uQfk/tCDs
	2SPwQWBg==;
Received: from authenticated user by zero.zsh.org with local 
	id 1mLu5f-0009cr-0K; Thu, 02 Sep 2021 21:17:43 +0000
Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)
	id 1mLu5Q-0009Lc-H9; Thu, 02 Sep 2021 21:17:28 +0000
Received: from [192.168.178.21] (helo=hydra)
	by mail.kiddle.eu with esmtp(Exim 4.94.2)
	(envelope-from <opk@zsh.org>)
	id 1mLu5P-000EwO-El
	for zsh-workers@zsh.org; Thu, 02 Sep 2021 23:17:27 +0200
In-reply-to: <CAH+w=7ZiZFeJXV_G0RYQqMPB9BzQLEgJKtC0azftX-fM2Oy+0w@mail.gmail.com>
From: Oliver Kiddle <opk@zsh.org>
References: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com> <CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com> <CAHLkEDtu9ABHKC4JXn9s3DkKvh7me=s1x=EBV3ibr+dnUwbj9w@mail.gmail.com> <CAHYJk3Qf5W2TY0u03bS7wUzR9Q8iXtwmpDRG8o8nTRCaBgMT1g@mail.gmail.com> <CAHLkEDu=hm77q1idtFg5PhPeh9FmxrvPOgrutz-Eaz0UBM_g9Q@mail.gmail.com> <20210901140327.GB27958@tarpaulin.shahaf.local2> <CAH+w=7aB4QALHV0X5Q0fHeQQw=q+a9yP5-Kv7rRn5iOd131xhg@mail.gmail.com> <CAHLkEDvnETmxUWen-o=oZtxDpfsZc3zNH2940j_6=7r4w=L+Fw@mail.gmail.com> <55401-1630615867.120247@EZKa.ra6F.k6mM> <CAH+w=7ZiZFeJXV_G0RYQqMPB9BzQLEgJKtC0azftX-fM2Oy+0w@mail.gmail.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Remove redundancies from `git` completion
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <57434.1630617447.1@hydra>
Date: Thu, 02 Sep 2021 23:17:27 +0200
Message-ID: <57435-1630617447.454477@LS39.frll.UgLV>
X-Seq: 49373
Archived-At: <https://zsh.org/workers/49373>
X-Loop: zsh-workers@zsh.org
Errors-To: zsh-workers-owner@zsh.org
Precedence: list
Precedence: bulk
Sender: zsh-workers-request@zsh.org
X-no-archive: yes
List-Id: <zsh-workers.zsh.org>
List-Help: <mailto:sympa@zsh.org?subject=help>
List-Subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
List-Unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
List-Post: <mailto:zsh-workers@zsh.org>
List-Owner: <mailto:zsh-workers-request@zsh.org>
List-Archive: <http://www.zsh.org/sympa/arc/zsh-workers>

Bart Schaefer wrote:
> On Thu, Sep 2, 2021 at 1:51 PM Oliver Kiddle <opk@zsh.org> wrote:
> >
> > This particular test was rather annoying before $functions_source
> > existed because it made it more difficult to fully reload all _git
> > functions.
>
> I can't tell if you're arguing for simply removing the test, or for
> exploding all the functions into their own files (which I think would
> necessitate another layer of subdirectory, just for sanity).

For the sake of sanity (and consistency), I'd keep it in the single
file.

I wouldn't object to removing the tests, either wholesale or selectively.
But I'm not inclined to be proactive about removing them either.

Oliver