From: Marko Myllynen <myllynen@redhat.com>
To: zsh-workers@zsh.org
Subject: Re: _values and end of options
Date: Thu, 9 Jun 2016 21:11:55 +0300 [thread overview]
Message-ID: <5759B16B.9010800@redhat.com> (raw)
In-Reply-To: <2450.1465487023@thecus.kiddle.eu>
Hi,
On 2016-06-09 18:43, Oliver Kiddle wrote:
> Marko Myllynen wrote:
>>
>> Otherwise this works nicely (each of the options is completed only once)
>> but -1 -2 are missing from offered options (see _values). I can use --
>> to have them included as well (_values -w opts -- $opts) but then -- is
>> also offered.
>
> _values starts with a call to zparseopts to remove normal compadd
> style options such as -1 and -2. In general these shouldn't occur after
> (or mixed with) the values. It mostly occurs when _values is used
> within an _arguments spec. In that case the unwanted options only appear
> at the beginning. The following patch makes it only remove compadd style
> options that occur at the beginning.
>
> -zparseopts -D -E -a garbage C=usecc O:=subopts M: J: V: 1 2 n F: X:
> +zparseopts -D -a garbage C=usecc O:=subopts M: J: V: 1 2 n F: X:
>
With this change all works here now as I hoped, thanks!
Cheers,
--
Marko Myllynen
prev parent reply other threads:[~2016-06-09 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 12:24 Marko Myllynen
2016-06-09 15:43 ` Oliver Kiddle
2016-06-09 18:11 ` Marko Myllynen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759B16B.9010800@redhat.com \
--to=myllynen@redhat.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).