From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "İsmail Dönmez" <ismail@i10z.com>
Cc: zsh-workers@zsh.org
Subject: Re: W02jobs.ztst hangs with zsh 5.6.1
Date: Mon, 10 Sep 2018 13:46:39 +0100 (BST) [thread overview]
Message-ID: <578964708.1160352.1536583599266@mail2.virginmedia.com> (raw)
In-Reply-To: <CAMAzfThesK53c-qPEe39THJx=3k4MGx23Wwn84cg1V20J9uvjw@mail.gmail.com>
> On 10 September 2018 at 12:32 İsmail Dönmez <ismail@i10z.com> wrote:
> Inded that doesn't fail when I manually run it. I put the W02 under a
> loop to see if I can get it to fail more but surprisingly it failed
> elsewhere:
>
> Running test: suspended job with check_jobs + check_running_jobs
> ZTST_test: expecting status: 0
> Input: /tmp/zsh.ztst.8136/ztst.in, output:
> /tmp/zsh.ztst.8136/ztst.out, error: /tmp/zsh.ztst.8136/ztst.terr
>
> So indeed this could be a zpty problem in the end.
Thanks for that.
I'll disable the tests that attempt to test suspended jobs and see where that
gets us.
diff --git a/Test/W02jobs.ztst b/Test/W02jobs.ztst
index 1e7ac76..fe12f97 100644
--- a/Test/W02jobs.ztst
+++ b/Test/W02jobs.ztst
@@ -85,27 +85,29 @@
*>zsh:*running jobs*
*>zsh:*SIGHUPed*
- zpty_start
- zpty_input 'setopt check_jobs no_check_running_jobs'
- zpty_input 'sleep 3'
- sleep 0.1
- zpty_input $'\C-z'
- zpty_stop
-0:suspended job with check_jobs + no_check_running_jobs
-*>zsh:*(stopped|suspended)*sleep*
-*>zsh:*(stopped|suspended) jobs*
-# no 'SIGHUPed' message for suspended jobs
-
- zpty_start
- zpty_input 'setopt check_jobs check_running_jobs'
- zpty_input 'sleep 3'
- sleep 0.1
- zpty_input $'\C-z'
- zpty_stop
-0:suspended job with check_jobs + check_running_jobs
-*>zsh:*(stopped|suspended)*sleep*
-*>zsh:*(stopped|suspended) jobs*
-# no 'SIGHUPed' message for suspended jobs
+#### Races presumed to be associated with zpty mean that
+#### tests involving suspending jobs are not safe.
+## zpty_start
+## zpty_input 'setopt check_jobs no_check_running_jobs'
+## zpty_input 'sleep 3'
+## sleep 0.1
+## zpty_input $'\C-z'
+## zpty_stop
+## 0:suspended job with check_jobs + no_check_running_jobs
+## *>zsh:*(stopped|suspended)*sleep*
+## *>zsh:*(stopped|suspended) jobs*
+## # no 'SIGHUPed' message for suspended jobs
+##
+## zpty_start
+## zpty_input 'setopt check_jobs check_running_jobs'
+## zpty_input 'sleep 3'
+## sleep 0.1
+## zpty_input $'\C-z'
+## zpty_stop
+## 0:suspended job with check_jobs + check_running_jobs
+## *>zsh:*(stopped|suspended)*sleep*
+## *>zsh:*(stopped|suspended) jobs*
+## # no 'SIGHUPed' message for suspended jobs
zpty_start
zpty_input 'sleep 5 & sleep 4 & sleep 3 &'
@@ -153,19 +155,19 @@
*>-
*>zsh:*SIGHUPed*
- zpty_start
- zpty_input 'sleep 5'
- sleep 0.1
- zpty_input $'\C-z'
- zpty_input 'jobs -r'
- zpty_input 'print -- -'
- zpty_input 'jobs -s'
- zpty_stop
-0:`jobs -r` and `jobs -s` with suspended job
-*>zsh:*(stopped|suspended)*sleep*
-*>-
-*>\[1] + (stopped|suspended)*sleep*
-# no 'SIGHUPed' message for suspended jobs
+## zpty_start
+## zpty_input 'sleep 5'
+## sleep 0.1
+## zpty_input $'\C-z'
+## zpty_input 'jobs -r'
+## zpty_input 'print -- -'
+## zpty_input 'jobs -s'
+## zpty_stop
+## 0:`jobs -r` and `jobs -s` with suspended job
+## *>zsh:*(stopped|suspended)*sleep*
+## *>-
+## *>\[1] + (stopped|suspended)*sleep*
+## # no 'SIGHUPed' message for suspended jobs
zpty_start
zpty_input 'sleep 10 & sleep 9 & sleep 8 & sleep 7 &'
next prev parent reply other threads:[~2018-09-10 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180910102119epcas5p384cea9ba5749eb81be99c4f4d85a954e@epcas5p3.samsung.com>
2018-09-10 10:20 ` İsmail Dönmez
2018-09-10 10:32 ` Peter Stephenson
2018-09-10 10:39 ` İsmail Dönmez
2018-09-10 11:19 ` Peter Stephenson
2018-09-10 11:32 ` İsmail Dönmez
2018-09-10 12:46 ` Peter Stephenson [this message]
2018-09-10 13:07 ` İsmail Dönmez
2018-09-10 15:14 ` Peter Stephenson
2018-09-10 15:50 ` Daniel Shahaf
2018-09-10 16:22 ` Peter Stephenson
2018-09-10 16:55 ` Bart Schaefer
2018-09-10 17:40 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578964708.1160352.1536583599266@mail2.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=ismail@i10z.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).