From: dana <dana@dana.is>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: zsh-workers@zsh.org
Subject: Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:"
Date: Sun, 24 Feb 2019 13:46:40 -0600 [thread overview]
Message-ID: <57F7B086-B935-4E12-8FEA-A2F232EEDB43@dana.is> (raw)
In-Reply-To: <20190224135854.3905-1-genml+zsh-workers@thequod.de>
On 24 Feb 2019, at 07:58, Daniel Hahler <genml+zsh-workers@thequod.de> wrote:
>This patch changes some of the "*::" to "*:", but is not really tested
>in detail. Mostly based on trying if "--help" worked after any arg.
Some of these do look like they were just erroneously copied and pasted, but
in other cases it's actually necessary, at least with the way it's written
now. For example, the commit-range-or-file state checks to see if $CURRENT is
1, which can only ever be true if the *:: syntax (or equivalent) is used.
I didn't look at it much harder than that, but, in general, anywhere you're
thinking about removing *:: or *:::, you need to check the corresponding state
code to see if it does anything with $words or $CURRENT, or calls another
function that does.
dana
next prev parent reply other threads:[~2019-02-24 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 13:58 Daniel Hahler
2019-02-24 19:46 ` dana [this message]
2019-02-25 9:46 ` Daniel Hahler
2019-02-25 10:04 ` Daniel Hahler
2019-02-25 19:14 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F7B086-B935-4E12-8FEA-A2F232EEDB43@dana.is \
--to=dana@dana.is \
--cc=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).