From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 58d14050 for ; Sun, 24 Feb 2019 19:47:35 +0000 (UTC) Received: (qmail 25720 invoked by alias); 24 Feb 2019 19:47:19 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44079 Received: (qmail 27190 invoked by uid 1010); 24 Feb 2019 19:47:19 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f193.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.166.193):SA:0(-1.9/5.0):. Processed in 2.428938 secs); 24 Feb 2019 19:47:19 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.193 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k3jgz4hTKbSCCakzsEyI5NK7TH+fGK+/pLJegwzeT9I=; b=g5SGPtboueo6U8959CHwGFHqQrP3DLcWzDIk+Fe2icdMsG96TtXrKQnA9oS+3Kk6Jb PY8LvqYXFM8zM8EwpDnpEdMFv67zvnz0i8+JloGt0gg1CO2bwqm8CsmOrB8ZDsF0ftti eAuQ5dhl5cI84d9/163NAhuhJJpEedKexknp+Ava0OvFd/fFLrgwgy2UvRF4yNrw5xn5 S7dnw3lguCbSiFpDLXx5igH1Kufodw8vKIO1pJOK7kYu4IaioP4o13uime9aMDocDkDS iSqPMeV38YvNi4W8UtbG9NQwsInD5B607Nwnjs7ANJsxkxaO5+B6LN3UzF+zcwuTzpT8 DLYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k3jgz4hTKbSCCakzsEyI5NK7TH+fGK+/pLJegwzeT9I=; b=U1GTVsIvJ/L/KDX5Hhqi3Zi9RHK3rM2yb7uxW0cOd2culPG/08W5lfWl6DIRw6wjNl JkpzzZKhYgvz/mSO9sNb42sCeCzmJcXIzUqR8NAy2D3+lMJ0p3VgfmuP5uR37WSHMMxj AqMWc9j6ks29gmbLd9Cd22lZ7N7qprGHggbnnhRlAv7Jdc2BZQLphmG/VSkCGRAYge2A USQAZW2Lluzts2A53z1Kqhq5dpcpD4oXT4NTed06wHdy/WoZvoEK6FVzhs/gHp7irv+E UI+8aOWgbcHX4fQdxNM8B8/WCLIqtGQ/daIr1RUbmeNiDYhq59pcghmRXFSjK3FNjmE4 3m1A== X-Gm-Message-State: AHQUAub3qZGOBdnAS/5fCUIfXfO6OAy8ZpT6e9WHNaGbaL26sjBdxqE6 ULBYK2Tsy5lYmTe7S1WV9h+Y9leWouV+MA== X-Google-Smtp-Source: AHgI3IaJXa2tccSd48wT07wSRZUGix3OtEdfUIoPez85q5TddQBADSGoCrI3j3YbvvfLyeC2Rf8pEg== X-Received: by 2002:a24:b143:: with SMTP id c3mr8086381itj.79.1551037603817; Sun, 24 Feb 2019 11:46:43 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:" From: dana In-Reply-To: <20190224135854.3905-1-genml+zsh-workers@thequod.de> Date: Sun, 24 Feb 2019 13:46:40 -0600 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: <57F7B086-B935-4E12-8FEA-A2F232EEDB43@dana.is> References: <20190224135854.3905-1-genml+zsh-workers@thequod.de> To: Daniel Hahler X-Mailer: Apple Mail (2.3445.100.39) On 24 Feb 2019, at 07:58, Daniel Hahler = wrote: >This patch changes some of the "*::" to "*:", but is not really tested >in detail. Mostly based on trying if "--help" worked after any arg. Some of these do look like they were just erroneously copied and pasted, = but in other cases it's actually necessary, at least with the way it's = written now. For example, the commit-range-or-file state checks to see if = $CURRENT is 1, which can only ever be true if the *:: syntax (or equivalent) is = used. I didn't look at it much harder than that, but, in general, anywhere = you're thinking about removing *:: or *:::, you need to check the corresponding = state code to see if it does anything with $words or $CURRENT, or calls = another function that does. dana