From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: Test release: 5.8.1.2-test
Date: Tue, 12 Apr 2022 10:16:21 +0100 (BST) [thread overview]
Message-ID: <581742430.2100989.1649754981506@mail2.virginmedia.com> (raw)
In-Reply-To: <7eecde054c5ef96a5a45b568866aff02881ff50d.camel@ntlworld.com>
> On 10 April 2022 at 21:07 Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> On Sat, 2022-04-09 at 15:07 -0500, dana wrote:
> > I've tagged 5.8.1.2-test (test release for the upcoming zsh 5.9) and
> > uploaded the artefacts to:
> >
> > https://sourceforge.net/projects/zsh/files/zsh-test/5.8.1.2-test/
> >
> > If you have the time, please test and report any issues found.
>
> Thanks very much for this, fine on my Ubuntu system. I'll be able to
> try out on RedHat and Cygwin tomorrow.
Seems entirely clean on Ubuntu 16.04 and 18.04 and RedHat EL7.
Compiles on Cygwin but the test system is a bit sick on my laptop ---
not actually that unusual. Unlikely to have time to look at this.
A couple of fixes will remove compilation warnings; it looks like
POSIX systems are pretty safe about signed characters these days
so Cygwin is about the only place where they still cause issues.
pws
diff --git a/Src/exec.c b/Src/exec.c
index 27d49e005..47753da48 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -561,7 +561,7 @@ zexecve(char *pth, char **argv, char **newenvp)
isbinary = 1;
hasletter = 0;
for (ptr = execvebuf; ptr < ptr2; ptr++) {
- if (islower(*ptr) || *ptr == '$' || *ptr == '`')
+ if (islower(STOUC(*ptr)) || *ptr == '$' || *ptr == '`')
hasletter = 1;
if (hasletter && *ptr == '\n') {
isbinary = 0;
diff --git a/Src/prompt.c b/Src/prompt.c
index 738c7fc7a..092de63a4 100644
--- a/Src/prompt.c
+++ b/Src/prompt.c
@@ -1666,7 +1666,7 @@ match_colour(const char **teststrp, int is_fg, int colour)
tc = TCBGCOLOUR;
}
if (teststrp) {
- if (**teststrp == '#' && isxdigit((*teststrp)[1])) {
+ if (**teststrp == '#' && isxdigit(STOUC((*teststrp)[1]))) {
struct color_rgb color;
char *end;
zlong col = zstrtol(*teststrp+1, &end, 16);
next prev parent reply other threads:[~2022-04-12 9:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 20:07 dana
2022-04-09 20:18 ` Bart Schaefer
2022-04-10 20:07 ` Peter Stephenson
2022-04-12 9:16 ` Peter Stephenson [this message]
2022-04-10 20:21 ` Luna Jernberg
2022-04-11 0:32 ` Axel Beckert
2022-04-11 8:30 ` Axel Beckert
2022-04-11 19:54 ` Bart Schaefer
2022-04-12 2:39 ` Jun T
2022-04-12 3:58 ` Bart Schaefer
2022-04-12 6:30 ` Jun T
2022-04-12 7:17 ` Jun T
2022-04-12 9:05 ` Axel Beckert
2022-04-12 17:55 ` [PATCH] " Axel Beckert
2022-04-12 18:40 ` Axel Beckert
2022-04-13 1:17 ` [PATCH] " Jun T
2022-04-13 9:34 ` Axel Beckert
2022-04-11 10:44 ` Kamil Dudka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581742430.2100989.1649754981506@mail2.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).