From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 31251 invoked from network); 12 Apr 2022 09:16:39 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 12 Apr 2022 09:16:39 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1649754999; b=AMUXwkgTnAApPG6LX6/szdrD5N+Ytn/kWutbwG7hRzot4AOTvGigNOHZwtX3f2ZIOsfElB6yyt h2U5/FiGIJF0lXstxbjaBBxcbACbTqyqwpl8H8j605euyufzVbPr06D6pGMPsP0OUhaoF6pzQx PPBw/FxlRW5krFLC+XQFNCwKLFVgiDSBLg3Xoj5eDHsOyll7yHYnYuLbvX6MLsa7cfesCYj5Qp 1B9thUDmXTmpMSzY5Oca6TEJEjJMWZ647BWXg/BIpK5WO/BBeKmL3gnzQXwYZr+BSbsBQZuoWG ZdN60xxluFG170TpPExP2nucOvZIwsi5lOI8x1Br4PhagA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq2.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.97; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1649754999; bh=XxnyiTMcbW38YCN/UZYscHMomPkrOconBZuW+eZchxs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=iXcnXcK6h3q9P5OziC9/yN0oaYgHeneeAWizSLNJtv1zQcIwzOAS9Lc2dXtL/c0GH3kU0ohYMj set6ORZWTuVD7mJWRP6sF63pUTgxj4ZYKehON2stRvji9bfzxWV0AaptDFRJIGX0iDr91gj677 WXvaCNTBiSaQPpacOqPi6V1Ws3J7UggSmLtegS6NagzukAPzq42Zoo2mIh7d35uabWCZk5Q+zD Y7G4yIc3WnQq0hFgAFq50ngm0cqSQKbXaIyRcNP3pZOUex+tDWeBGlxbja703mi8yKRFgw+gkf u18/+32PJAO0lIHymZBJKha8tJpAXgWtsO5Bd72AkS1HEQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=CNf5AGOy8Y3E4tkzexsjNj9AthG9i4XkGRbbUKarysA=; b=Icz/fLUXSHhEv9fszq7rX3MX2a A5WQ1q//mfTEBEP8V6SPFG6DeED86tLOH00uZVhL084UnzasZxL9TsrjiQFJfijsuFIZ/iLL2n1UJ L9rDS+0KF5BgGgKj44wo9yU/l/KeBPZxYBnDNEtbjMvqbUzkiQFKcPXBoddiytkOw++HsN77MVck/ 3VH7YGLCEs0Od95BpOp249o2OPasHfsqJmhZ4JkE9UgCshZwJYUUTQtExIhurTTtY72hWRKe8guS4 K98lOK1lyp6d15kqmgDxjce0VuuKv4YYPPWIurU4Ms14DvuujoHz3SsGNvq4HniwekVnqMv8fbcV9 KHMmPCsg==; Received: from authenticated user by zero.zsh.org with local id 1neCdb-000CnU-26; Tue, 12 Apr 2022 09:16:39 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq2.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.97; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq2.tb.ukmail.iss.as9143.net ([212.54.57.97]:38744) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1neCdK-000CSV-A9; Tue, 12 Apr 2022 09:16:22 +0000 Received: from [212.54.57.82] (helo=smtp3.tb.ukmail.iss.as9143.net) by smtpq2.tb.ukmail.iss.as9143.net with esmtp (Exim 4.90_1) (envelope-from ) id 1neCdJ-0005FB-PU for zsh-workers@zsh.org; Tue, 12 Apr 2022 11:16:22 +0200 Received: from oxbe13.tb.ukmail.iss.as9143.net ([172.25.160.144]) by smtp3.tb.ukmail.iss.as9143.net with ESMTP id eCdJnngHfEKeCeCdJn6XDf; Tue, 12 Apr 2022 11:16:21 +0200 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.144 X-CNFS-Analysis: v=2.4 cv=JqLiEe0C c=1 sm=1 tr=0 ts=62554365 cx=a_exe a=wuFMYA7voKp1dZz7Z+vj5Q==:117 a=wbvTLvLwOfMA:10 a=IkcTkHD0fZMA:10 a=7H6ixmLU1AQA:10 a=NLZqzBF-AAAA:8 a=FP58Ms26AAAA:8 a=uXGZ2eV93kZc-JeLaowA:9 a=QEXdDO2ut3YA:10 a=wW_WBVUImv98JQXhvVPZ:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1649754981; bh=XxnyiTMcbW38YCN/UZYscHMomPkrOconBZuW+eZchxs=; h=Date:From:To:In-Reply-To:References:Subject; b=YqmrwSQ79tE2MWJnoT0RBdkX82FVZPT85ZmApm4sbMu74uHzXg8xXqXl8TSyg7ITQ BCIneQeHksbID3ok4KXNEIoCPLaqdzTXpVow3/oZgDI8WI6qMVBfTZqaCr8qaA2Uwl AGMNuJjOFNZoxWyYzx09Zj6Pv/Est9DDoC1PDVuyRYv23zvCm+W7awN6O+3vI4y6Bv U3GJz0MnHdP8QQV5WyRdDUP6E44PVp85cFN3xgdaVrBGBtFhuFEYf/IqhnjESlpDs4 7Ia4IGa5KR16Q3hfw34cdA4z56kJp9v+pkL+5jWiJ6ifDnziceFnmN/ZuM/Q1eWVJE fHsWbjffoJHlw== Date: Tue, 12 Apr 2022 10:16:21 +0100 (BST) From: Peter Stephenson To: zsh-workers@zsh.org Message-ID: <581742430.2100989.1649754981506@mail2.virginmedia.com> In-Reply-To: <7eecde054c5ef96a5a45b568866aff02881ff50d.camel@ntlworld.com> References: <92daf80d-aa83-497b-8ec5-a8543ea736da@www.fastmail.com> <7eecde054c5ef96a5a45b568866aff02881ff50d.camel@ntlworld.com> Subject: Re: Test release: 5.8.1.2-test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev72 X-Originating-IP: 147.161.167.85 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfHHP5zhzyLSI2gHR7UojXqT9exl2juLBHuIiCcPXOp5clFjfcA7gJIyt4bs7WU9Jo9In3J/GxfhOpMRylupe3R6qLCyzXO+tYczNcRiEO7LN30sto62D 65C4thZddpY2GTs9erfpYUo8l2tEIBo7m6c+k8LyB+toV+ZQ8xmLUYh6M92o0yc1zUIAWsl1XhhFUcvlvxnNViPkb3cp/sWn17djGSh60yWe7Js6mE/tViiN X-Seq: 50049 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > On 10 April 2022 at 21:07 Peter Stephenson wrote: > On Sat, 2022-04-09 at 15:07 -0500, dana wrote: > > I've tagged 5.8.1.2-test (test release for the upcoming zsh 5.9) and > > uploaded the artefacts to: > > > > https://sourceforge.net/projects/zsh/files/zsh-test/5.8.1.2-test/ > > > > If you have the time, please test and report any issues found. > > Thanks very much for this, fine on my Ubuntu system. I'll be able to > try out on RedHat and Cygwin tomorrow. Seems entirely clean on Ubuntu 16.04 and 18.04 and RedHat EL7. Compiles on Cygwin but the test system is a bit sick on my laptop --- not actually that unusual. Unlikely to have time to look at this. A couple of fixes will remove compilation warnings; it looks like POSIX systems are pretty safe about signed characters these days so Cygwin is about the only place where they still cause issues. pws diff --git a/Src/exec.c b/Src/exec.c index 27d49e005..47753da48 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -561,7 +561,7 @@ zexecve(char *pth, char **argv, char **newenvp) isbinary = 1; hasletter = 0; for (ptr = execvebuf; ptr < ptr2; ptr++) { - if (islower(*ptr) || *ptr == '$' || *ptr == '`') + if (islower(STOUC(*ptr)) || *ptr == '$' || *ptr == '`') hasletter = 1; if (hasletter && *ptr == '\n') { isbinary = 0; diff --git a/Src/prompt.c b/Src/prompt.c index 738c7fc7a..092de63a4 100644 --- a/Src/prompt.c +++ b/Src/prompt.c @@ -1666,7 +1666,7 @@ match_colour(const char **teststrp, int is_fg, int colour) tc = TCBGCOLOUR; } if (teststrp) { - if (**teststrp == '#' && isxdigit((*teststrp)[1])) { + if (**teststrp == '#' && isxdigit(STOUC((*teststrp)[1]))) { struct color_rgb color; char *end; zlong col = zstrtol(*teststrp+1, &end, 16);