From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,MALFORMED_FREEMAIL,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 8181eba7 for ; Mon, 16 Dec 2019 11:21:39 +0000 (UTC) Received: (qmail 10262 invoked by alias); 16 Dec 2019 11:21:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45049 Received: (qmail 4690 invoked by uid 1010); 16 Dec 2019 11:21:32 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25663. spamassassin: 3.4.2. Clear:RC:0(205.235.26.22):SA:0(-0.3/5.0):. Processed in 2.821689 secs); 16 Dec 2019 11:21:32 -0000 X-Envelope-From: SRS0=JajR=2G=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at bounces.park01.gkg.net designates 205.235.26.22 as permitted sender) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 X-YMail-OSG: lZAUsxoVM1nE_oixNBqsM2hE7yso0iV4JtqiuipPmtrMAQJzQqSrBfp8ExkBimN JfPAThwRg9dvX4H8sjSXaJF4CPjyE.PCGZ5ka96HbBkalTmPKbDTm2BTej764yDGk2x27.rjH0kD wUZOqKj93NLW1H7XHsQhepog46CixSMYYotO4OrTgGISitzqFrhHsSXv_hTVt4lw8gkM4qpqLLnM dKJLdlvrS3.SFC_FJzeJJWyNuUNAbYejdvuZFX.Rb53wzF0.U9cymTHLJTd34nrbeDPUYP.zuyxz d7szNEemnSqipmkasxcZg3C.shGEqVnezxGtvs27G1o4z9UE.vMrs3YKtw0kowRam8YiEa9NMXJN Aj7ef1FMq5RCPOE2UuUiMTP38Ik.dMHIjOLbD2jHQh04Z9xWpzZSG4wjIz5vcPIF2A4BGTQs2Pgs 2YDjZsLLcAr4.By2b0IveMyVxPbBxxyHCRMwEWB7zUZMqga9N01Hn_nDMrdlOqvV6DlobGOCw1k7 N1JpFRuiR2qmGxYDUiUixdD2Nc4UCyx9dqya2G5GY1Ao8m6r1MOZd74XylEYbyfAZwxAhCjpRPY8 .ubXER5yHDG5YuXDIX7HgcctIbnyTGGC7mBCtMq2KCBshWN19VJ9EyjZ7aAzN1WrkZpi5LHwbCUM 5_AKbho1eZgsx2GULxidBcAoNt1E20XYMvu.dv0Kpr4o5bCzez.URa5d4M_RvXp9QnA_8VjXOOgw tFKMGJ0JdMmCh.jiukxu6pWZRneErj5s_ud_fYe4saJ0YG7AHaWpHy2sfnEkPDXPTyw5PpO1Tilf h4xMZnsWieBA11hNyPsTiIICM7tQWrAGeEvqekUoEQp24DZrRW3wrE7Cy3nSJyPfI3HCXj8Z.Cyq krP4AmPdBUdTyk8rMthRYS4VPdH2TlNhq4.kE4ZZ_9Wh6QE1scjdZ15qXRm7IyEwcppv3SyA9she 170cwperpxXN9zpzQJISQ16dNPVZySE0IIhlGOk1aPjCm1ayn4Ji6hRsKP9WjxwYPE9r9Hrq7rFh r.ApFK5qOVImzT5q15KK_iLJ0mKktfETcQF7bPU8.ZLUzZmRQbnUkq_1_h3iH6ZS9RVSu.eqHPuD YYTxlYfN5l3aDGLtS3GHxpjsYDZcgqOjRUmke8k9jM4AeFD.I2JQLExDoJiIPJOXuXBA.X9_RBMs QBw2DtUC.sNRshofcrD7851650B9QmpQZ8XZ1zSh3eIMjzCLvCW.1BGtzjZrBOv5AQfQThJUDn5R ufO43fDDd6ZNTe12VTkUki_JmR9OibWR0i_f_o.Po2E9h_.7u2SSaKd6Hxi6qbFwDmmWlZ0EMS4d 8CXa7pi7r31v3sgGDppnCJxTAS0l3lP3iGh1TyoLvpkA.iPQGDRJ6o_194u9.BEegoFI38sJDlie D5vCt4RtiOybhBo.Jc1aCWI8- cc: zsh-workers@zsh.org In-reply-to: <583f56f7-9d85-faf9-61f9-e07b6b40e07c@cilg.org> From: Oliver Kiddle References: <68254402-c6c6-2579-1675-df637ee1127a@cilg.org> <20190823044039.sk2uiatlvacpcifl@tarpaulin.shahaf.local2> <583f56f7-9d85-faf9-61f9-e07b6b40e07c@cilg.org> To: Baptiste BEAUPLAT Subject: Re: [PATCH] Completion for sbuild MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5872.1576495243.1@hydra> Date: Mon, 16 Dec 2019 12:20:43 +0100 Message-ID: <5873-1576495243.685540@E5gB.6FIY.i_D2> X-Mailer: WebService/1.1.14728 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) On 10 Dec, Baptiste BEAUPLAT wrote: > Thanks a lot for taking the time to review this patch, that greatly > appreciated. I'll try to fix as much as I can do. I don't know if Daniel had any further comments on this but it looked good to me so I've merged it with a couple of very minor tweaks. Anything else can always be handled with patches. > + if [[ -n "${DEBFULLNAME}" ]]; then > + identity = "${DEBFULLNAME} <${DEBEMAIL}>" > + else > + identity = "${DEBEMAIL}" > + fi I removed the spaces either side of the = in these assignments as this will attempt to run an `identity' command instead. Thanks for the contribution and for taking the time to go over the feedback and revise it. Oliver