From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 24E9B21BD6 for ; Sun, 21 Jul 2024 21:30:39 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1721590239; b=dnr9DgaABfSEa/3RbwDSmJixbbtPF4vobv2oLmnnCJCyrPm+2xgR0ptnvuiqSe1Vn2/Ovyeiya gMXQARmm/BRbrJX9iaNb4ib9cZLqRFXt1hUtsrHKFaCMJUKDcjkyacvyM5CJOGbBWLWwkvyyqZ fFL2jljBJH9ySo7+DdFAkWp2MhomwBqTmvPqeV682g6XOfzvmXXe8WeOqGLsXIEd7+oXiR4xNs IvSxCFDUf0AY6VQFm4ur6WZ7qhsZnVs8fiJ8Su6OUUDREs+g1sRcRaRiAAU2nc2yow9GEh9rO5 RlTPH33qC193SjDPL7XtvR7BJZPA5Ej0+sK0pgB25vJt5Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (csmtpq4-prd-nl1-vmo.edge.unified.services) smtp.remote-ip=84.116.50.41; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1721590239; bh=2+VU3xgfbPCuOWhq8m1i0vSKhzwyfpV3Hf+uSvvp2iQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=nBz0b/fLePqx/kVkBJpVHFAEYuv3nw7RCNkvbfr0GTZEplNeM5xSYjZoxekcGRBh0hNeMAWCxR Tx12wIGbhLS3g5foGENU5q4Vgod0cAN/GnLsio29GCDt3EcV3RIYrOCdUKOroSi+1aKzbiVYSc DCnUOPhQJBIb18PAsWMPtvIVY6rs4/EBy5MBFJMz9HJBMClNEaoKfO3qJyFf2hwFKQUPsNo5yn oziueF5YKpf2RAV7t5kTZLIv3wIs2dhNRhVXVwwUiBMf8U6W+GZYidiAgANIetWetLdNFBhhaX Nopt+UIWNBqCjmNo//X3asdgTo9uBZNgR2ppmvKpyGqlqQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=UQwz3Uw7+6U+DSmS1JvVKneYpkqzRA1TNKdRrEm8rWk=; b=iBOfrsQQ/vd/2ktOIFFESZhSNy JfO3I5O689cl0dU6byfHjEQraFP+ZjXZ+BYKr3yK6gDzm9A3Db+r/Gusl4rOi5MM1nTDwavq00o6+ aCgw5csnuKMvrJlgcLh7sTOHiy8G1MV6AkRWosP+abMz1agQmXUEeBkBLgEEbDKg99OkPG3H0Lgmm PrKBjn+q0FsydVAkZ4qfHVgzghVGFLCUjQQhW8PnvpQX7PRHsiZ0cg7P8VBbcJXOgjAaE6X/U5ynB z2B6ZLeQ43XfF6pY6Je/V69ptiRsISmPVbqEu8e2ITaCBGCTeIz5O2E28xPFB/9Xhwaa9cuPByWDS ymjrM06g==; Received: by zero.zsh.org with local id 1sVcGU-00028L-1B; Sun, 21 Jul 2024 19:30:38 +0000 Authentication-Results: zsh.org; iprev=pass (csmtpq4-prd-nl1-vmo.edge.unified.services) smtp.remote-ip=84.116.50.41; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from csmtpq4-prd-nl1-vmo.edge.unified.services ([84.116.50.41]:62635) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1sVcGA-0001pm-9E; Sun, 21 Jul 2024 19:30:19 +0000 Received: from oxsmtp2-prd-nl1-vmo.nl1.unified.services ([100.107.83.137]) by csmtpq4-prd-nl1-vmo.edge.unified.services with esmtp (Exim 4.93) (envelope-from ) id 1sVcG9-00Aw3H-9D for zsh-workers@zsh.org; Sun, 21 Jul 2024 21:30:17 +0200 Received: from oxbe6-prd-nl1-vmo.nl1.unified.services ([100.107.83.10]) by oxsmtp2-prd-nl1-vmo.nl1.unified.services with ESMTP id VcG9sJydG5XiHVcG9s1Znx; Sun, 21 Jul 2024 21:30:17 +0200 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 100.107.83.10 X-CNFS-Analysis: v=2.4 cv=da/S3mXe c=1 sm=1 tr=0 ts=669d61c9 cx=a_exe a=BaxG2yfOxHMHApbdv9TgGQ==:117 a=xbpq84Xq3O0A:10 a=IkcTkHD0fZMA:10 a=69EAbJreAAAA:8 a=u1N7MGw-nTiT75ZrHfwA:9 a=QEXdDO2ut3YA:10 a=0FLe7Enw6tHXXJK_LEbo:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1721590217; bh=2+VU3xgfbPCuOWhq8m1i0vSKhzwyfpV3Hf+uSvvp2iQ=; h=Date:From:To:In-Reply-To:References:Subject; b=u07Ks86A+bh5jqUK9ozZf6zFD4FCxXIo0Jj3ki+6Kk9xArB5pdRil+esexGVzeX+6 aTn22K6Jotrq+OvTvwKZKMgSssz4vPYuD+s9PaJ+JLHYhZuFaJHB1ste7VcNgPq7EU nF0iOytbhNMoaPq73trKCZeZ2nn/j6BM3d7H5rK5I71YYIxS9Dvu1QCv/rtOJvvNEE DQBKldKTykyCTUuRLOKr3zhxEFY3g1PCcK9rSNFnPsJ4kHuGD+jjuywLS2x1qZ/iU3 JIcGQwiHiri/8qYMHhUbum8E+rqE6JFhmhoKit/gfRA+5HbkJSy+uQ791DHjuJpuFv qOm47zETyesRQ== Date: Sun, 21 Jul 2024 20:30:17 +0100 (BST) From: Peter Stephenson To: "zsh-workers@zsh.org" Message-ID: <597238192.4880487.1721590217246@mail2.virginmedia.com> In-Reply-To: References: <910a3a7e-ea58-4f2f-b26e-a2fff7d5c0c3@app.fastmail.com> Subject: Re: inherit OLDPWD from environment variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer X-Originating-IP: 82.1.229.248 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfCePI+p4uqVjcgio3ZbUywkyOX3FY6i5FB+oq/RN7Q783Sl4PwOohnhq6i5e2DKjVAGpStFg3vK2t1HG0CjJh5SoPoSL6YIGGBzIJT7DaNEoAAY6DTln Hs+x+8hndlYaUoDDg1hWkWPfMbSBCKHSG/ncOdd3hbnhnitrD0yctV8IJjsPu9IS/cC9+ot9fmZRkljc/Ak7fwkpuRMRJk2nJ2sYnCmjgSJ4FS608dr+t4DV X-Seq: 52998 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > On 20/07/2024 08:56 BST Franklin Yu wrote: > Good catch. Indeed Bash accepts empty value. Then it becomes > > diff --git a/Src/init.c b/Src/init.c > index ec21521b1..092273228 100644 > --- a/Src/init.c > +++ b/Src/init.c > @@ -1245,7 +1245,9 @@ setupvals(char *cmd, char *runscript, char *zsh_name) > pwd = metafy(zgetcwd(), -1, META_DUP); > } > > - oldpwd = ztrdup(pwd); /* initialize `OLDPWD' = `PWD' */ > + oldpwd = zgetenv("OLDPWD"); > + if (oldpwd == NULL) > + oldpwd = ztrdup(pwd); /* initialize `OLDPWD' = `PWD' */ > > inittyptab(); /* initialize the ztypes table */ > initlextabs(); /* initialize lexing tables */ > Looks fine to me, I'll commit it assuming nobody comes up with any gotchas. pws