From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Aleksandr Mezin" <mezin.alexander@gmail.com>, zsh-workers@zsh.org
Cc: "Daniel Shahaf" <d.s@daniel.shahaf.name>
Subject: Re: [PATCH v4] vcs_info: choose backend by basedir
Date: Sat, 10 Apr 2021 16:49:14 -0400 [thread overview]
Message-ID: <59d34afe-a1b2-4870-aa86-9851eaf28e3f@www.fastmail.com> (raw)
In-Reply-To: <20210329165629.GA2761@tarpaulin.shahaf.local2>
On Mon, Mar 29, 2021, at 12:56 PM, Daniel Shahaf wrote:
> Let me first summarize the previous threads:
>
> - The current default is that backends are used in order of the «enable»
> style: first detected, wins.
>
> - Frank prefers this remain the default. (workers/47488, workers/47509)
>
> - Aleksandr implemented a mode in which the backend whose worktree root
> directory is closest to $PWD would be used.
>
> - Bart's use-case (workers/44931) wouldn't be served by choosing the
> "deepest" worktree but by choosing whichever one has local mods.
> (workers/47490)
>
> - It was proposed to address Bart's use-case by calling vcs_info twice
> with different user-context strings and corresponding zstyle settings.
>
> - Oliver proposed some independent improvements in workers/47492.
>
> If any of that is inaccurate, speak up. The named people are Bcc'd.
>
> The patch being replied to contained some git- and cvs-specific changes
> which have been committed. Aleksandr expressed concerns about those in
> workers/44929, but as far as I can see, the part that has been committed
> is a no-op, other than the fact that vcs_comm[basedir] will be populated
> earlier.
>
> So, first things first: Does implementing a "choose the VCS whose root
> is deepest" mode that's off by default sound like a reasonable way
> forward? Any concerns with that? Any concerns with the algorithm
> described in Aleksandr's log message (just the log message,
> independently of the unidiff)?
>
> Below a couple of review points on my account. Not a full review; just
> what I spotted from reading the diff.
bump
vq
next prev parent reply other threads:[~2021-04-10 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 19:37 Aleksandr Mezin
2020-12-03 4:01 ` Aleksandr Mezin
2020-12-04 15:56 ` Daniel Shahaf
2021-03-27 20:40 ` Lawrence Velázquez
2021-03-29 16:04 ` Daniel Shahaf
2021-03-29 16:56 ` Daniel Shahaf
2021-04-10 20:49 ` Lawrence Velázquez [this message]
2021-04-17 12:17 ` Aleksandr Mezin
2021-04-17 13:16 ` Daniel Shahaf
2021-05-09 20:28 ` Lawrence Velázquez
2021-05-31 1:13 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59d34afe-a1b2-4870-aa86-9851eaf28e3f@www.fastmail.com \
--to=larryv@zsh.org \
--cc=d.s@daniel.shahaf.name \
--cc=mezin.alexander@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).