From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23571 invoked from network); 10 Apr 2021 20:49:50 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 10 Apr 2021 20:49:50 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To:Message-Id: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=KUJkA7YBvHRWn59E/0gKSCrnC/8aX3zzqD3S9P/1NTo=; b=MT6ZlMiIimmRU2qr+pzBVoac9v i639lpYQgVY1o5PAHabeLDSXky95clDfpPClxSD+RBIe7FaOFvq8ewtHOOk8BMwvieMIH9Zi3UAqv YFOa2Sk1+CBScYYODD+wxGEv3k2aZhlxcVJDUIboFpSWRPCbZazpVRzRszMxDIUaxFPMtxzMtr7+e 8iUibll7BQMkn0bcbhZco8eoKcNWB9xwcpW+nUDp4jehm1is79IScehvP088H9yrMK176iNnKCgr2 o2cCivKm4tJZ21K4dU047MiJK6FUMSykdCEE5GD8JKlEuq7k9etc3wvWYILDeK97AwrBVnGHWGVLz 0gjsXR3A==; Received: from authenticated user by zero.zsh.org with local id 1lVKY9-000ATE-OL; Sat, 10 Apr 2021 20:49:49 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lVKXw-000ACs-35; Sat, 10 Apr 2021 20:49:36 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailauth.nyi.internal (Postfix) with ESMTP id DABCD27C0054; Sat, 10 Apr 2021 16:49:34 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Sat, 10 Apr 2021 16:49:34 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekfedgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepnfgr fihrvghntggvpgggvghljoiiqhhuvgiiuceolhgrrhhrhihvseiishhhrdhorhhgqeenuc ggtffrrghtthgvrhhnpeeufeehleeikeeijedtgffgteehheeivddtiedukeejvdejgfej udefkeevlefggeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehlrghrrhihvhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidquddu hedukeejjedtgedqudduledvjeefkeehqdhlrghrrhihvheppeiishhhrdhorhhgsehfrg hsthhmrghilhdrtghomh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 84969A00079; Sat, 10 Apr 2021 16:49:34 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: <59d34afe-a1b2-4870-aa86-9851eaf28e3f@www.fastmail.com> In-Reply-To: <20210329165629.GA2761@tarpaulin.shahaf.local2> References: <20201114193703.1428617-1-mezin.alexander@gmail.com> <20210329165629.GA2761@tarpaulin.shahaf.local2> Date: Sat, 10 Apr 2021 16:49:14 -0400 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: "Aleksandr Mezin" , zsh-workers@zsh.org Cc: "Daniel Shahaf" Subject: Re: [PATCH v4] vcs_info: choose backend by basedir Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 48479 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Mon, Mar 29, 2021, at 12:56 PM, Daniel Shahaf wrote: > Let me first summarize the previous threads: >=20 > - The current default is that backends are used in order of the =C2=AB= enable=C2=BB > style: first detected, wins. >=20 > - Frank prefers this remain the default. (workers/47488, workers/4750= 9) >=20 > - Aleksandr implemented a mode in which the backend whose worktree roo= t > directory is closest to $PWD would be used. >=20 > - Bart's use-case (workers/44931) wouldn't be served by choosing the > "deepest" worktree but by choosing whichever one has local mods. > (workers/47490) >=20 > - It was proposed to address Bart's use-case by calling vcs_info twice= > with different user-context strings and corresponding zstyle setting= s. >=20 > - Oliver proposed some independent improvements in workers/47492. >=20 > If any of that is inaccurate, speak up. The named people are Bcc'd. >=20 > The patch being replied to contained some git- and cvs-specific change= s > which have been committed. Aleksandr expressed concerns about those i= n > workers/44929, but as far as I can see, the part that has been committ= ed > is a no-op, other than the fact that vcs_comm[basedir] will be populat= ed > earlier. >=20 > So, first things first: Does implementing a "choose the VCS whose root= > is deepest" mode that's off by default sound like a reasonable way > forward? Any concerns with that? Any concerns with the algorithm > described in Aleksandr's log message (just the log message, > independently of the unidiff)? >=20 > Below a couple of review points on my account. Not a full review; jus= t > what I spotted from reading the diff. bump vq