From: Jun-ichi Takimoto <takimoto_j@me.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _ssh_hosts: abort early if in a path
Date: Wed, 29 May 2019 22:57:49 +0900 [thread overview]
Message-ID: <5F7BFA16-8F23-438C-A57B-1EB4E82757A4@me.com> (raw)
In-Reply-To: <20190527233331.GA84827@phil-pennock>
> 2019/05/28 8:33、Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>のメール:
>
> +case "$PREFIX" in
> + ( /* | ./* )
> + return
> + ;;
> +esac
Isn't it better to "return 1"?
_ssh_hosts (before your patch) does not return 1 even if it can't
find any matches. Maybe better to fix this also?
next prev parent reply other threads:[~2019-05-29 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 23:33 Phil Pennock
2019-05-29 13:57 ` Jun-ichi Takimoto [this message]
2019-05-29 21:50 ` Phil Pennock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F7BFA16-8F23-438C-A57B-1EB4E82757A4@me.com \
--to=takimoto_j@me.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).