From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2b6073a3 for ; Wed, 29 May 2019 13:58:48 +0000 (UTC) Received: (qmail 28635 invoked by alias); 29 May 2019 13:58:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44378 Received: (qmail 15249 invoked by uid 1010); 29 May 2019 13:58:29 -0000 X-Qmail-Scanner-Diagnostics: from pv50p00im-zteg10011401.me.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25461. spamassassin: 3.4.2. Clear:RC:0(17.58.6.41):SA:0(-4.3/5.0):. Processed in 3.404232 secs); 29 May 2019 13:58:29 -0000 X-Envelope-From: takimoto_j@me.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at me.com designates 17.58.6.41 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1559138271; bh=ZDLNi7b61CiaTLXklUCQw0nQw9TeUIYojWxmTfivDzo=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=QXWffkF7SuC7Xd945ujHJeSRQ5tBe0Iq4I4VWzoQPj6HrwTbfMvpqJHJ0szSXi5Fw 6OhKoKphZJuWRZizE078QiCmRotFID+0sHIkp8wTj6Bi43Xaz2DMtAnF+sX3iCzWkx HF9E4YZTaTIBLnl2pTjYZnGWQpVDDX8dc92vjDzRFWd5h0A/a3YCd4BsB2+WnBtBH2 sJE0i46JPTPi6zCG1L3Stt74o2zTymZh7q0VgkEFsOQ5TcPO7sxWQNBI3tEQZsNRwd U18etZJfLKM/rOtQxZ5n4AHawUhYR/XvJ/yJ0WIyvIUxPYK940shUhH7OceFdWpd5d kEuItfPUYULdg== From: Jun-ichi Takimoto Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: [PATCH] _ssh_hosts: abort early if in a path Date: Wed, 29 May 2019 22:57:49 +0900 References: <20190527233331.GA84827@phil-pennock> To: zsh-workers@zsh.org In-Reply-To: <20190527233331.GA84827@phil-pennock> Message-Id: <5F7BFA16-8F23-438C-A57B-1EB4E82757A4@me.com> X-Mailer: Apple Mail (2.3445.104.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-29_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=428 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1905290092 > 2019/05/28 8:33=E3=80=81Phil Pennock = =E3=81=AE=E3=83=A1=E3=83=BC=E3=83=AB= : >=20 > +case "$PREFIX" in > + ( /* | ./* ) > + return > + ;; > +esac Isn't it better to "return 1"? _ssh_hosts (before your patch) does not return 1 even if it can't=20 find any matches. Maybe better to fix this also?