From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Julian Prein" <druckdev@protonmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Introduce ZCALC_HISTFILE
Date: Fri, 09 Sep 2022 20:49:59 -0400 [thread overview]
Message-ID: <5af4a81c-1c63-4be2-8c76-8f3162a815b0@www.fastmail.com> (raw)
In-Reply-To: <cu_uqi1WBhr8VVDu-7ICNl25mUJPtLbGc7AeyyrQRNXdW59w6rj64ms1NZ4Lx5Ixia9asyaEC2iOvEavfAqNGBIBtIYks7M9P-FVXqnueO4=@protonmail.com>
Hi Julian,
Thanks for the submission! I don't have a particular opinion on
this proposal, but...
On Fri, Sep 9, 2022, at 7:27 PM, Julian Prein wrote:
> +the file tt($ZCALC_HISTFILE). If tt($ZCALC_HISTFILE) is unset,
> +tt($ZDOTDIR/.zcalc_history) is used instead.
This doesn't align with the actual code.
> # We use our own history file with an automatic pop on exit.
> -history -ap "${ZDOTDIR:-$HOME}/.zcalc_history"
> +history -ap "${ZCALC_HISTFILE:-${ZDOTDIR:-$HOME}/.zcalc_history}"
Consider something along the lines of:
Full command line editing, including the history of previous
calculations, is available; the history is saved in the
file specified by $ZCALC_HISTFILE, $ZDOTDIR/.zcalc_history
(if $ZCALC_HISTFILE is unset or empty), or $HOME/.zcalc_history
(if both $ZCALC_HISTFILE and $ZDOTDIR are unset or empty).
--
vq
next prev parent reply other threads:[~2022-09-10 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 23:27 Julian Prein
2022-09-10 0:49 ` Lawrence Velázquez [this message]
2022-09-19 2:02 ` Julian Prein
2022-09-25 17:07 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af4a81c-1c63-4be2-8c76-8f3162a815b0@www.fastmail.com \
--to=larryv@zsh.org \
--cc=druckdev@protonmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).