From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4300 invoked from network); 10 Sep 2022 00:50:39 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 10 Sep 2022 00:50:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=nxCwvb+y6JYNNOoBGiyIorTetKhW7u8faWqcsskHmC4=; b=CuU0SNCiZZfxXP4gEe2l4H6RFz xrJy0SoEor8ROxylHhH8CPm7+EUhs4mLr+RHu08pnXE/I3Xn1dxMhP2WZxhqoEXjv6MSR9+81qbRc VUmd95lQJAZm4zULNkVseI4tBYjYz/lN1Bd03NQ0O11LZUO1WSxmFAVbMLv159C+d3opAsfKCM1To D6W57QWRP9iMWA2OF2F2t7R6nF1PC7Gf26E/kpWZGMYlGMu/cZaNKbPu0ljU2bboUvekd2bGf8lw+ q+kQvYbCt5eROR8KccMkka2G6bU0gme9Quqdn+zXtcCYITL93SBeYoMw4Oir6PyDk9HSdk/TnlN/m HLy8Gjkg==; Received: from authenticated user by zero.zsh.org with local id 1oWohj-000HTe-90; Sat, 10 Sep 2022 00:50:39 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1oWohR-000H8r-QX; Sat, 10 Sep 2022 00:50:22 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 4382427C0054; Fri, 9 Sep 2022 20:50:20 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Fri, 09 Sep 2022 20:50:20 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtiedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvvefutgesth dtredtreerjeenucfhrhhomhepnfgrfihrvghntggvpgggvghljoiiqhhuvgiiuceolhgr rhhrhihvseiishhhrdhorhhgqeenucggtffrrghtthgvrhhnpeehfffhueejheeugffgfe euudffledvleegffeuhedvveekueegiedugfelueefteenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlrghrrhihvhdomhgvshhmthhprghuth hhphgvrhhsohhnrghlihhthidqudduhedukeejjedtgedqudduledvjeefkeehqdhlrghr rhihvheppeiishhhrdhorhhgsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: iaa214773:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0752C31A0062; Fri, 9 Sep 2022 20:50:20 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-927-gf4c98c8499-fm-20220826.002-gf4c98c84 Mime-Version: 1.0 Message-Id: <5af4a81c-1c63-4be2-8c76-8f3162a815b0@www.fastmail.com> In-Reply-To: References: Date: Fri, 09 Sep 2022 20:49:59 -0400 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: "Julian Prein" Cc: zsh-workers@zsh.org Subject: Re: [PATCH] Introduce ZCALC_HISTFILE Content-Type: text/plain X-Seq: 50617 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Hi Julian, Thanks for the submission! I don't have a particular opinion on this proposal, but... On Fri, Sep 9, 2022, at 7:27 PM, Julian Prein wrote: > +the file tt($ZCALC_HISTFILE). If tt($ZCALC_HISTFILE) is unset, > +tt($ZDOTDIR/.zcalc_history) is used instead. This doesn't align with the actual code. > # We use our own history file with an automatic pop on exit. > -history -ap "${ZDOTDIR:-$HOME}/.zcalc_history" > +history -ap "${ZCALC_HISTFILE:-${ZDOTDIR:-$HOME}/.zcalc_history}" Consider something along the lines of: Full command line editing, including the history of previous calculations, is available; the history is saved in the file specified by $ZCALC_HISTFILE, $ZDOTDIR/.zcalc_history (if $ZCALC_HISTFILE is unset or empty), or $HOME/.zcalc_history (if both $ZCALC_HISTFILE and $ZDOTDIR are unset or empty). -- vq