From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43556-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2a97387e for ; Wed, 26 Sep 2018 02:23:02 +0000 (UTC) Received: (qmail 10885 invoked by alias); 26 Sep 2018 02:22:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43556 Received: (qmail 28600 invoked by uid 1010); 26 Sep 2018 02:22:46 -0000 X-Qmail-Scanner-Diagnostics: from mail-wr1-f68.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.221.68):SA:0(-1.9/5.0):. Processed in 2.905989 secs); 26 Sep 2018 02:22:46 -0000 X-Envelope-From: o.freyermuth@googlemail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=subject:to:references:cc:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VLO81sXh7h9SLAiFrV9EaKK5WksHq04C/1ZMMDz/W+8=; b=KXOv3B9KW7YsndChptEBrdpo/h6PKX1E3xI9N+3jUf0pSkJqx/I26YTdEldN0CnsfF 6ZMjUYRoj9nAoCj4/Mn6zJgkqCLcx2LJDdiFtWkW8UijhiBkgZx7WRHId+ZOVWtfphNj NmefUBUoRqJV284cIM4Pfh0SBkCWINrDf6dDlO6/waxpFJcJpW4nki3xYai+cLG+T9Ym +mMEXi96jGRBL3nvepP84ClIAQpvWQCTYZ+hOi+N8J++ubcI/wsXiq5XT2frhOpkJZh2 HotvRhvDlS/oscZ8h21UuX+rY6OkuxTni0QvrOPxR9Ll25lGfJacJNHKb4y3q/B63RCS 8e+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VLO81sXh7h9SLAiFrV9EaKK5WksHq04C/1ZMMDz/W+8=; b=Tns3Tu2K027q2JaPNylKwx5JiDJuw7DTwPGkwHcPvenYmWZkFlESYIT27O/8Ugv0jI eXJfbfIJh/Laq7213bQE+ZMhkKsKEKx5sBza4D92v+hOIv2C7pfDRpT64wX8Ow8wMtve RuzA9cOFBpRergEMgIjc/QXhpFVxF8v4iWJSmgYIB+rxEk74mjnM5ZMcN8fDSMNsAEbZ IaAx1re440Qarp0pryTxQ+zRuJ2nAGhLwj3qJeIuXetwnKOnPBXFFa1flgrhk3kc4F0Z 105GaUZNuQrA2xkNQNEUHz1+Kv0kzziEqfixu/gH2oO6ZFEIqSsNsi2U19mjlzc9HQoA D5mg== X-Gm-Message-State: ABuFfohjakVXVsJ9e/fg8E5fo99Yx0kxe9C1+xwRnAZFm/ZjlTRZq9WI ZFihyJVdbJ0UA0plS2YpBECWvSIS X-Google-Smtp-Source: ACcGV62h6atc0t4dF9EHJWvdM+Qt9rRSu8K9AlOPvtMcVfNG966ifQB4Q8JIB4MYc8QhkIrid8HRYw== X-Received: by 2002:a5d:6209:: with SMTP id y9-v6mr3187775wru.179.1537928558912; Tue, 25 Sep 2018 19:22:38 -0700 (PDT) Subject: Re: zathura conpletion for zsh broken To: Daniel Shahaf References: <057ea9a2-d934-59e6-3109-e5093f0f9878@googlemail.com> <20180925192153.uwitfgrd2yydxtah@tarpaulin.shahaf.local2> <75619dc0-7b02-45bd-7cd9-a5078d6829a5@googlemail.com> <1537907787.166425.1520521784.2C5972A6@webmail.messagingengine.com> <1537916165.201389.1520635144.15A3171F@webmail.messagingengine.com> Cc: zsh-workers@zsh.org From: Oliver Freyermuth Openpgp: preference=signencrypt Autocrypt: addr=o.freyermuth@googlemail.com; prefer-encrypt=mutual; keydata= xsFNBFLcXs0BEACwmdPc7qrtqygq881dUnf0Jtqmb4Ox1c9IuipBXCB+xcL6frDiXMKFg8Kr RZT05KP6mgjecju2v86UfGxs5q9fuVAubNAP187H/LA6Ekn/gSUbkUsA07ZfegKE1tK+Hu4u XrBu8ANp7sU0ALdg13dpOfeMPADL57D+ty2dBktp1/7HR1SU8yLt//6y6rJdqslyIDgnCz7+ SwI00+BszeYmWnMk5bH6Xb/tNAS2jTPaiSVr5OmJVc5SpcfAPDr2EkHOvkDR3e0gvBEzZhIR fqeTxn4+LfvqkWs24+DmYG6+3SWn62v0xw8fxFjhGbToJkTjNCG2+RhpcFN8bwDDW7xXZONv BGab9BhRTaixkyiLI1HbqcKovXsW0FmI8+yW3vxrGUtZb4XFSr4Ad6uWmRoq2+mbE7QpYoyE JQvXzvMxHq5aThLh6aIE3HLunxM6QbbDLj9xhi7aKlikz5eLV5HRAuVcqhBAvh/bDWpG32CE SfQL0yrqMIVbdkDIB90PRcge7jbmGOxm8YVpsvcsSppUZ9Y8j/rju/HXUoqUJHbtcseQ7crg VDuIucLCS57p2CtZWUvTPcv1XJFiMIdfZVHVd2Ebo6ELNaRWgQt8DeN4KwXLHCrVjt0tINR9 zM/k0W26OMPLSD6+wlFDtAZUng2G8WfmsxvqAh8LtJvzhl2cBwARAQABzS9PbGl2ZXIgRnJl eWVybXV0aCA8by5mcmV5ZXJtdXRoQGdvb2dsZW1haWwuY29tPsLBfAQTAQIAJgIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheABQJTHH5/AhkBAAoJECZSCVPW7tQjXfMP/j+WZ1cqg6Ud CUbcWYWm8ih1bD61asdkl8PG55/26QSRPyaR+836+cpY+etMDbd82mIyFnjHlqjGjmO8fr0H h4/SUS1Jut54y4CdJ62xG8O8Mkt/OVgEQnfv1FYKr+9MxhVrd3O1s/bubbj3WEyRwtK5NVpi vBTSdHwpfEPsnwUA+qeFINtp2EovaJaWvtjL+H8CmNXM9H3p4/PSzQGioaJB/qjDfvS6fwZU aUUdgXjtKwYl+9YTPuxVgmfmItNLjncpCXR5ZVA7Nwv3BFZGdbxLZ185yXgN/AjGHoZrjVfr /q+jfuhcR04kiKItugvZ7HhYyeBGcOyPexg6g0BqIxN42KAj4lfAnPOIHEPV0ZG279xUkdA3 TP/aeM8a1rmVoH2vtQT0vAL8y2s7oy0sqVETjG5OmqWzjhzEUJLxuNhXX6dUDrzPB5VeCi2h P1b7Wz3AdskNyCK7zR9fipMi7olL+vAdnylfz404mDYy57OppmVxk19Tqm+DE5SHKG/sLIFi 0+I6CBOLyVRZUob0duauP6V3uv4dkDU6noKV5vr9CJ2DzMCsREOH5DepoTi0QwmVGTISq9pE TRfbsjRNt9rCZq2RSFMmBBOsfsTALqH57oXYdkDcY+54DtZyz1vX1IW60tGtjkGhIdSRktlH /g3WSB6VUHeHwc6y3xaQ5wU/zsFNBFLcXs0BEACU2ylliye1+1foWf9oSkvPSCMZmL1LMBAa d7Jb51rrBMl4h3oRyNQ95w9MXnA9RMk+Y6oKCQc6RS+wMKtglWgYzTw7hdORO5TX1qWri8KI sXinHLtQVKqlTp6lKWVX57rN4WhFkRh7yhN32iVV9d3GBh9H189HqLIVNbS3G8D83VerLO7L H+VIRjHBNd6nakw8AMZnvaIqiWv9SM9Kc7ZixCEcU5r3gzd1YB3N7qyJJyAcYHbGe6obZuov MiygoRQE3Pr7Ks7FWiR/lCFc3z1NPbIWAU2LTkLVk2JosRWuplT7faM5fzg0tLs6q9pFuz/6 htP9c9xwZZFe+eZo247UMBwrptlugg2Yxi/dZirQ3x7KFJmNbmOD1GMe6GDB6JVO4mAhUAN4 xpsRIukj2PMCRAMmbN/KOusCdh2XDrNN0Zr0Xo6fXqxtvLFNV/JLky2dkXtiGGtK27D76w23 3J2Xv/AIdkTOdaZqvk8rP2zoDq8ImOiC05yfsiSEeAS++pVczrGD0OPm3FTwhusbPDsamW42 GWu+KaNSARo0D1r9Mek4HIeErO4gqjuYHjHftNifAWdyFR9IMy4TQguiGrWMFa1jDSbYA/r+ w3mzYbU8m1cy6oiOP1YIVbhVShE6aYzQ4RLx38XAXfbfCum/1LGSSXctcfVIbyWeDixUcKtM rQARAQABwsFfBBgBAgAJBQJS3F7NAhsMAAoJECZSCVPW7tQj8/kP/RHW+RFuz8LXjI0th/Eq RFkO4ZK/ap6n1dZpKxDbsOGWG8pcAk2g7zmwDB9oFjE4sy3O1EvDqyu68nRfBcZf1Xw1kh2Z sMo2D5e7Sn6jkyKTNYNztyL5GBcnXwlG/XIQvAwp4twq/8lB/Mm5OgfXb7OijyYaqnOdn7rO 4P6LgSMdA73ljOn7duazNrr4AGhzE28Qg/S4Jm5hrSn6R/hQGaISsKxXewsKRafQsIny7c97 eDZ3pD4RYVpFOdSVhMGmzcnNq3ETyuDITwtgP0V4v9hJbCNU1zV2oEq5tTQM2h0K8jL3WvPM wZ3eOxet7ljrE7RxaKxfixwxBny9wEm8zQAx1giFL7BbIc7XR2bJ3jMTmONO2mM4lj49Cjge pvL4u227FCG+v+ezbVHDzYPCf9TYo17Ns5tnso/dMKVpP6w5ZtIYXxs1NgPxrSTsBR9I9qE0 /cJpiDJPuwTvg78iM5MvliENLUhYV+5j+Xj+B5v/pyPty/a1EW9G+m4xpQvAyP8jMWI8YJJL 8GIuPyYGiK/w2UUbReRmQ8f1osl6yFplOdvhLLwVyV/miiCYC2RSx1+aUq3kJAr627iOPDBP SVyF8iLJoK9BFHqSrbuGQh5ewEy6gxZMVO8v4D/4nt/vzj5DpmzyqKr58uECqjztoEwXPY+V KB7t2CoZv5xo0STm Message-ID: <5e25b789-3613-6b63-d688-767857395098@googlemail.com> Date: Wed, 26 Sep 2018 04:22:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1537916165.201389.1520635144.15A3171F@webmail.messagingengine.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Am 26.09.18 um 00:56 schrieb Daniel Shahaf: > Oliver Freyermuth wrote on Tue, 25 Sep 2018 23:22 +0200: >> Thanks! Didn't know this is copied as-is, I'll take better care in the >> future. Hopefully the commit message of the attached patch is better. > > Yes, it is, thank you. > > Not all developers copy the message as-is. I happen to use git-am(1) > to apply patches so it's easier for me to consume patches produced > by git-send-email(1) or git-format-patch(1), like yours. Other developers > use other tools and don't care so much about the format so long as it > can be piped to patch(1) or git-apply(1). > > [ Actually, I use a wrapper around git-am(1) that also automatically > adds the mailing list message number to the log message and creates > a ChangeLog entry. You might find it an interesting read: > https://github.com/danielshahaf/zsh-dev/ ] [ That's indeed a good read, many thanks for the link! ] >> The attached patch fixes the second issue, I tested with a dummy .so >> in /usr/local/lib/zathura. Plugin file formats are now also made >> unique. Let me know if this can be simplified, or if it is in any case >> unneeded since the "uniqueness" is implicit in the matching code later >> on - I'm still learning more and more about the wonders of zsh >> expansion, and every bit I learn leaves me wondering how I could ever >> survive without that knowledge up to now. >> > > I've changed: > . > + plugins_files+=( $plugins_dir/*.so ) > . > to: > . > + plugins_files+=( $plugins_dir/*.so(N) ) > . > to avoid an error if one of the directories exists and contains no *.so > files. This was a preëxisting bug in the function (it means the '(( > $#plugin_files ))' check was redundant). Good point! > Regarding uniqueness, another way to achieve uniqueness is to pass -U to > the 'typedef -a' command that declares the variable. That's indeed more beautiful in most cases, and noted down for the future. I hope I can make good use of that with a future contribution which will surely come latest when I start to use a tool for which the completion is lacking or even missing. Many thanks for the helpful advice! Cheers, Oliver > > Also, it's not idiomatic to use [[ -z $array ]], though it will function correctly. > >> Cheers, >> Oliver >> >>> P.S. Our of curiosity, what's that U+0261 LATIN SMALL LETTER SCRIPT G doing there? >> Spotted very well, my font and mail client hid that from me. I did >> accidentally hit the keybinding for SCIM (Smart Common Input >> Method) while typing, and it started to interfere. That created >> some funny characters, and apparently I missed to remove the "g" >> once I noticed it. > > OK :) > > Cheers, > > Daniel >