From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 92dd46de for ; Thu, 28 Nov 2019 11:14:52 +0000 (UTC) Received: (qmail 16794 invoked by alias); 28 Nov 2019 11:14:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44944 Received: (qmail 7350 invoked by uid 1010); 28 Nov 2019 11:14:47 -0000 X-Qmail-Scanner-Diagnostics: from out3-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25642. spamassassin: 3.4.2. Clear:RC:0(66.111.4.27):SA:0(-2.6/5.0):. Processed in 4.497896 secs); 28 Nov 2019 11:14:47 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:cc:subject:content-type; s=fm1; bh=0MDC LkN4yVWHWmUy4cjfpIkPhJdgyz1kW9RcQ4x3ATU=; b=qa/o4ozKXAD45n11DR8v W6EjuP6pp+v3gZzh+SlbS8Pg8TKb8Ph+cSracNbStZ8Vb9A6IJ0l4qjpXMzApbtY dDcH32nbtpDzmdcpb7OCbYUTGZzam11B6kUfIX1AyOzpbl9tIvef47NLRqAI4p+d AArTmqEslL0a/qhwcb2zVV67zMSJa0nB/xubmsOABTKxBVTJLo18DTDigu5fZDFS ZsIjM3gnYht8ISUceZSit+FMcc5pk28sosIHzC4dmZfbDSSD1FrfR9QyKalxhNgu gC77lGaZ/4pOqg5jayOkyif83Uw2RSnGD/u276yQNeSVWvMnOMYd4q09SY3HcIR/ WA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0MDCLk N4yVWHWmUy4cjfpIkPhJdgyz1kW9RcQ4x3ATU=; b=F0YQWD0tT0AK9yfJJ8TvL8 9XGuIsjMjmjK/ssaiejHp6BF6ftkJqM7IQSVI7EorJOs8uCxEv2SgL7alIXvjnPQ 42Tzy58I035Giv+u0uJX+/iglc+R+MMoFc7A/2H2ZkIE43a6HIhT2o3dFMQZaL3q aTgCv3ijR6xLebCDszXMbqfF5ZKswH3gBQpHgrfTOocLzbN6IIML8EmjKU2TeJDc RvPobNqcIMhAVn5AvOSt8Mm4G8zgDpume2ohBovLsjpUJcAAVN2GcQDo3Wyjq27Y SGFlFBte6EpbRvTESAP/xRUrQG24wtf3jW8QhSCV66kt8xytO52vGdoVXDSD5XXQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeijedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdffrghn ihgvlhcuufhhrghhrghffdcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg eqnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghf rdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1 Mime-Version: 1.0 Message-Id: <5edaa985-4ac9-411c-b4c2-415c49a563e3@www.fastmail.com> In-Reply-To: References: <20191123221443.279556-1-mezin.alexander@gmail.com> <20191123221443.279556-3-mezin.alexander@gmail.com> <20191125043525.lcxm532gi6hb7n53@tarpaulin.shahaf.local2> <9438ca11-d0be-4c67-a5b3-a0b900342302@www.fastmail.com> Date: Thu, 28 Nov 2019 11:13:44 +0000 From: "Daniel Shahaf" To: "Aleksandr Mezin" Cc: zsh-workers@zsh.org Subject: =?UTF-8?Q?Re:_[PATCH_2/3]_vcs=5Finfo/cvs:_set_vcs=5Fcomm[basedir]_in_VCS?= =?UTF-8?Q?=5FINFO=5Fdetect=5Fcvs?= Content-Type: text/plain Aleksandr Mezin wrote on Tue, 26 Nov 2019 10:22 +00:00: > On Tue, Nov 26, 2019 at 10:52 AM Daniel Shahaf wrote: > > % cd foo > > [shows hg info] > > % export GIT_WORK_TREE=${PWD/foo/bar} GIT_DIR=${PWD/foo/bar}/.git > > [shows git info] > > % > > Interesting. I didn't notice that GIT_INFO_detect_git checks the exit > code of `git rev-parse --is-inside-work-tree`, not the actual value. I think it should check both the exit code and the output. > You don't even need to set GIT_WORK_TREE, GIT_DIR is enough. I think it's fine to detect git when GIT_DIR is set. After all, git commands would work at that point, so it'll be useful to display git info. [I mean this in the context of "when should git be detected", not in the context of "what to do when multiple VCS's are detected". I think the two questions are independent.] Cheers, Daniel (sorry for late answer; I'm not online much this week)