Re: Zle patch - termok change

Re: Zle patch - termok change

[G C Wing]

Zefram <zefram@dcs.warwick.ac.uk> writes:
:gwing@primenet.com.au wrote:
:Yuck.  issetflag() evaluates Y twice, and there aren't enough parentheses.

Really, give me an non-extremely convoluted example where my macros would fail.

:But why bother with these macros anyway?  We've always been happy with
:the (much clearer) plain bit operations anyway.

Fine.  Zoltan's removed them anyway with his replacement patch.

Zoltan wrote:
:begin 600 termok-patch.gz

BTW, termok-patch.gz gunzips to a file ``f'', unless you turn original
names off.
Also, the line 

oxtabs = (SGTTYFLAG & SGTABTYPE);

needs to be changed to

oxtabs = ((SGTTYFLAG & SGTABTYPE) == SGTABTYPE);

There is absolutely no guarantee that SGTABTYPE contains unique bits.  On
my machine it's  0xc00 
-- 
Geoff Wing [mason@primenet.com.au]   Technical Manager
  Phone    : +61-3-9818 2977         PrimeNet - Internet Consultancy
  Facsimile: +61-3-9819 3788         Web : <URL:http://www.primenet.com.au/>
  Mobile   : 0412 162 441

Zle patch - termok change

[gwing]

[-- Attachment #1: Type: application/pgp, Size: 16418 bytes --]

Re: Zle patch - termok change

[Bart Schaefer]

On Mar 7,  6:23pm, gwing@primenet.com.au wrote:
} Subject: Zle patch - termok change
}
} termok  now is flag based, not value based.
} termok == 0 indicates a `normal' working terminal - this is *opposite* to
}  the previous situation.

In that case, you should never use the form (!termok) because it reads as
if you mean the terminal is not OK.  Use (termok == 0) or make a new macro

#define nosetflag(X)	((X) == 0)

and then write (nosetflag(termok)).

} Flags for termok are defined and explained in zsh.h - currently TERM_NARROW
} is unused.

It looks like it is used in zlevarsetfn() ... you mean nobody explicitly
tests for it, but it is used in the sense that it makes termok != 0 ...

} If a terminal is evaluated as TERM_BAD then that status shouldn't go until
} $TERM is changed.

So that means that init_term() looks for TERM_BAD and doesn't change it?
Or what?

} Bart wrote:
} :Hmm.  Well, I dislike ..... because it presumes that init_term()
} :is independent of the values of "lines" and "columns".
} 
} I can't see why lines/columns should be any way connected to init_term() .

They don't need to be as long as init_term() doesn't reset TERM_SHORT or
TERM_NARROW.  If I do

TERM=vt100
LINES=3
COLUMNS=3
TERM=xterm

Then what happens to termok?  Am I going to get a crash because init_term()
has reset termok to zero?

BTW:

#define issetflag(X, Y)		((X & (Y)) == Y)
#define isanysetflag(X, Y)	(X & (Y))

Is it really necessary for these to be different?  Why risk evaluating Y
twice in issetflag?

-- 
Bart Schaefer                             Brass Lantern Enterprises
http://www.well.com/user/barts            http://www.nbn.com/people/lantern

Re: Zle patch - termok change

[gwing]

Bart Schaefer wrote:
:On Mar 7,  6:23pm, gwing@primenet.com.au wrote:
:} Subject: Zle patch - termok change
:} termok  now is flag based, not value based.
:} termok == 0 indicates a `normal' working terminal - this is *opposite* to
:}  the previous situation.
:In that case, you should never use the form (!termok) because it reads as
:if you mean the terminal is not OK.  Use (termok == 0) or make a new macro
:#define nosetflag(X)	((X) == 0)
:and then write (nosetflag(termok)).

Point taken, though I probably shouldn't be using !termok where I have, but
isanysetflag(termok, TERM_BAD | TERM_UNKNOWN | TERM_NOUP | TERM_SHORT)

:} Flags for termok are defined and explained in zsh.h - currently TERM_NARROW
:} is unused.
:It looks like it is used in zlevarsetfn() ... you mean nobody explicitly
:tests for it, but it is used in the sense that it makes termok != 0 ...

Yes, I meant explicitly, but also if I change as above, then it won't be
used yet.

:} If a terminal is evaluated as TERM_BAD then that status shouldn't go until
:} $TERM is changed.
:So that means that init_term() looks for TERM_BAD and doesn't change it?
:Or what?

Have no idea what I meant, but:
Until $TERM is changed, init_term() is not going to get called.  So your
terminal is TERM_BAD for one combination of $TERM/$TERMCAP/TERMCAP-file.
Yep, I don't know where I was going with this.  Don't worry about it.

:} I can't see why lines/columns should be any way connected to init_term() .
:They don't need to be as long as init_term() doesn't reset TERM_SHORT or
:TERM_NARROW.  If I do
:
:TERM=vt100
:LINES=3
:COLUMNS=3
:TERM=xterm
:
:Then what happens to termok?  Am I going to get a crash because init_term()
:has reset termok to zero?

No, init_term() doesn't touch TERM_SHORT or TERM_NARROW.  termok is flag
based and only set explicitly in  setupvals()

:BTW:
:#define issetflag(X, Y)		((X & (Y)) == Y)
:#define isanysetflag(X, Y)	(X & (Y))
:Is it really necessary for these to be different?  Why risk evaluating Y
:twice in issetflag?

There's no risk I can see or I would have put everything in parentheses.
You can't use the first form if you do something like my example above,
and the first form always evaluates to 1.  Hmmm,  you're right, I should
probably change it to:

#define issetflag(X, Y)		((X & (Y)) != 0)

And replace all isanysetflag()s with issetflag().  Good thinking.

-- 
Geoff Wing [mason@primenet.com.au]   Technical Manager
  Phone    : +61-3-9818 2977         PrimeNet - Internet Consultancy
  Facsimile: +61-3-9819 3788         Web : <URL:http://www.primenet.com.au/>
  Mobile   : 0412 162 441

Re: Zle patch - termok change

[Zoltan T. Hidvegi]

Here is a revised version of Geoff's termok patch.  Use this instead of the
patch in article 2970.  The *setflags() macros are removed from Geoff's
patch, and termok is renamed to termflags since the termok name was
misleading after the patch.  This is for zsh-3.0 and depends on patches
2865, 2956 and 2957.  I also have a 3.1 version of that patch.

Zoltan


begin 600 termok-patch.gz
M'XL(",B@(#,``V8`W5II<]M&$OW,_(J1DY5)&:(!$#P5.24KBJV*3+ITQ#G6
MJP+!(8D(!+#`0!05>W_[=L^!@P1U.))7M2PGPC$SZ.YYT_VZ9[:VML@P<3WF
M^G5GV^RTFMMFM]G"_[4K/T4N>6='A+2)T>J99L_H$*/;;7^SO;V=]2HT:V,S
MRQ3-MHH_O"=6H]G2K$;+)/P1X3_79\1/9AJQHXG#=N"I?!&37;(%#R]?O-CY
M9D.T'9/J!J/1++@@FYNDZL8Q9=7#_NG!\=[^Z>$O!S7RZ1/9<'V7G6.S:JU6
M@]$J$65)Y!-C1P[]<@N'8E-*XI`Z[MBE(X+M'3LD4SLF-DI$(]<AE[:74(V,
MW#CT[`5Q&=EZJ00'8:K0#L1D$\K@JAK7:F1CEVP;-?(7-Y32V")PM_V%&J-D
M8\^>Q&23@*;OSE_O_5B#]SFULL:KK<_Z/_<''_JUIV\QQ`A*LHK&TVDB8-8B
M1K-G6CVKG:%1=%F"HJ[WS.YZ*#:Z'<W2FWD@QLQF(+\SA3%0M6$R_L/4K<['
MG0IHCZHKA>'-F$9"KV^I/W+'.(<YB&YAR_P42<SNIO.7FW48//%A5LBU1[%[
M$KO^A%S'4W@\@L_0F>W$12-NQ"QR9B&?:XT\XRV>P<2A-81F[3S@'EPSF"O0
M+4/:I]T"U'9RFNL*G)\?1>-2-V,T-<MLJ;FM8/]5W'.8X_#7-(JJSQS;?\[(
MV/4S7+O^."#C("+_B)]I1'Q9K^',5:`+:@X3JN_<-LU<>4*]F(+9H*^8!IP#
M0S>MCQK9"D,^*/H%IN\(BU>*8PU^YDU0FBK3^7>A+2Z=T_WS_<%9_Q3O7[RH
MB6_@-\,0UQE\9R?5-!Y'E%:9`\;\@^D?01?NI(PV^"A=(>9KV&L5.MQ8!=C\
M+<M)#[A+_E,8O>15BMG',&\I/"U=LZQ."L_4M4;T>4S\(+4G]5FTX`9UDBB&
M/TFHP5H!%PS+!5:.Y_J4S((1[9$M5([@6G9C`O]0QPFXZ.%"87(^=9TIOJ)7
M]@PZCF"Z</V=1Q2DCJ=UAYN;2X1+;T/@8(,Y,-/5T_VS]S6Y["M"07ST$4S0
M/SLZVA'/"XCM#\[><]/(A7\//3TZ9D+3?P[K*`Q'J65I5C,-I%_#;`(I=['<
MLMGR5N/?@%\)]H2-X+W$N&I9;N#B()\>P<ZE<&V!W=MZ"E<AH$=]$'#_Z&#O
M^&3_^."@CY(:J1S"X0O'7_"-V$(*"G(>0N1V;<^]AED)6$R",9EXP=#V@$5$
MKCWT*#`+\##`,*:$B7L%AS:LHG8KA<.7BF4\B$2EANN:FM7MY"G&T/8GW(GM
MDN<;SY6+P['4TV]S3YEZ^*_G*HBN#3`PHW\&0W@11O127#E!&`4.8%5=!@DC
M2+54'Z!@S)W18#RR%]7->(HWD48V1\ELMCAGUS5.#Y!=D>].#O8'_1]/LJ`<
M1V"&:A7BN#L1:X+5JG*,.KL\CZE#7I#<`X"94ZOMH)%C"AV^.][K_SAXE\XG
MT):F7N#)#V(ML5B6^<G_@='*(-?LZEJSV\Y#SHFHS6AH1_:,P[4*HTD.)EX1
M_@XNHARH2?['Q4="Z(Y'=$Q.#P?[;SX<]D]^EV8&I@"*4/^R^FQ_<'3VKG\"
MX1^48`MD!/6Y"^I>T_H\/G<"3RCSDWL%"T>BF;O-I8&.#OL':X>)@CG7HF0@
MI*W@2Y7R@9?,?)S^3DHHT/WC$],2[*?9;6DMO9$'WM.SV9<8Z)ZV0/QPM>);
MTZ]63V]EZ9?JM)J`6?KZ!,PPK8YFF*W4/T)$!1<+&H[]ZGL<DH3`'[T`,H,K
MY)Y_Y9-(_GBK%LZV7XUL9I/=7<AVI8:2IF"[*_(]:>0XFWP&](ZSV<J5L$8%
ME^Q>-'29'2TT2((8B>T9)9#7BMQ23"<?0EI4]#4+<7G),<,;25[QL\K\(!`F
MXL+RKW;%G>R]D9+]E#3D$G/N6/88H[,0V&X``0Q3*-D57%5((V^1^9K<M\O-
MQ46XI[$`*)FQHANL56J6E.[D9!.&D%911GI4NV1YZ-:*96H@ZI7P"Q*@[30O
M>AR`OB+FC0QQ[_AX\*&,(ZX20=GT4;'^^<O1=8NF)V\'QZ=W4E2V?""8?KX'
M+DH=6;O=THQV)RUJ9D6.PS'0;W\;779D.\R]Q+H8Q:I8C"P"OI"$7#_"7,\C
M<TI\#/(@7+'XP8LEJT6[K,JTEA9R4XH,.5LOG/!RB+?;'10]95W_(]'7%)%N
M4P&M#XNR/KVU6FA:6;CB/9;*VQ;\NZ%8:.@PPX:E)AC,,Z7N9,HP.\`<"KT,
M.A^N^>]'![^"'GU>YO7"D$UY76(;NZ'TK@_)!&23+`@@>`<1]UFC`+**!:2A
MB#H@Q,51>#/L"YY)YBF>'3/B`YY'X%5F,TQ)1@'DM24B0$O>4(B!T\[5,<2D
M2R.>S^S;=P$:[5ZS4["D[+:^79DY&Y"Z-=JM?`'D`P4U$@\R;TC39W:$S(KK
M1,=VXG$3V21>Q.#DP;_;HWI*L"H"K`#`/Q,PR21@6(NF<S1:`MGMS+Z`(9.(
MIG5.-0$8)9*P7BAV\'645KJ6$)=Z"5YFE4KDRA%/0XFU]?_;M"I%OJ%W$2N%
M0CFG,[,1!&T]MU>@Q@)_&T^O.6F6K!6R<EN5_V1A\>SD`$!:R\7XS4WNO56#
MO:,/>[^='.V=G+X_'KQ[?\J;7L_0C!!>C!JZ$>P@'<P-S3>PN1(NC&!)#%U(
MPB[H8IB,-2`@%).]F$5P(9_"Z#\0?-XCABAA\F63VB*_E_.@MMC(3=Z3MD<Y
M5IKH5[+=O25CC!/?&0<)+(C=K+S[I-&"DXM2XR#7D)Q[8TBQ*'AL"&'9<]RS
M&&-=$(Q5DTA1EE#>X1$L\=6Q\B762*.+&SMWV-5;BM.RV_(F<Z=G--9'EW:K
MH;5;707"R\`=P1\&FCIV6,6("'\U'AK1>H*YYW:XTF`K4Z%X[C)G6N5MY3:$
M#8QDV^BE9<<P8;$L^\/8'S5<)?`LLN?2=2B9)!SN+=.J4^<<6*R(]+L/)'"9
M43M&6^N8C7P44+PY!.8S5576-?OTJRR0;R>IWU)$4N4_()XT#&)9?D,[*C%R
M#O@V,6[9#W\(R13(T_V`>^,\[;E<0T%J>@/43:W=64H[)M07;#3.POO<]>>\
MH,G3SQU2H*)S=P2&2VMP:+-L"2!BH'=J6/RIK%`^3S-X$Z,$:-83N9]$/A>Q
MF%X\A(AK%L3?DK?,Q*;9TLRF5:BH!C'CCKO"<TQ1;EC9,8<W_>"2=%L]\OW,
MC@/_%2&GN,WD!<%%3)*)M^#D\)!,[4N*>ZG.E#H7P.>GP1PY?>A11O'XA!O7
MA>+QA#'(OU@R'@,C7)`@XG]\8(OS())UU&_!.M(#5]_N_7)PCM8Y')R<O^69
M5\DK>",-&UPQ>XBHKF951>8&=><\X&%H$\='<Z+><_H<^*C8NA>2I1-4-@YO
M,H0_YW+:^%C<7G!!9)ET[W6#;R5",*O@30V#"E[L\%9\*O%"MA_\"N].9(^*
MN.-=Q*7HI'KQ-EF30HM4CG0&21:":>#)^4X/+J0Y[BR(Z'G,@.Q#$WY#95@O
M-,Z`*T+TR6'_S=$!UG!Y.(>)62EUX<.T.,93Y719KJ![Z:6>#]D<GYB<TY$,
M!X&?S&(G"CPO5HTKF-5+-X?+EL/>,@M%\2^&_2T0EYNO]16`"ZN5HKR(LI,W
MIZ>__72T]P:<`5SOO3[][?U!3<R7!#S?LP4/.TUSKJ\[O>E,XES!?<&!5=/J
M*/F4EG#4I0I7M37EDK0:ED?#^OK:WP!&J7]L-S6S8^3]8_Z7,[`A=VPB^N^$
MQJPGWF%2C";%2HJKZA=I]!WSTQBO\'C8TN"!YSLX)RP]7U0:O/*_2R?.KPUE
M+D%6,JZ-Q?DP9)#N+`]P/8]<1JOXEJ=*LAEG3SQ15XL'V)Z9L;TG8)/UT?*K
M&Z@41%U3,[.=<C"(#PZ"4P(PC`UH5!L#&#%Y')?/Q;(28@B6@&[%CESP/-#+
M]K$6,[-'%-["2QQ24\6[?$OU5KF',BXDV34_1"()F^`O2]F=J*V:'1T61EH?
M>E(ZK<LF[JR@8KPL<IV+Q:UEPVZ:L"G"JSJN;UF*$\."E658W<)AE#&EH903
M;_-YM#@/EBZZ.U85[IU(5^Z32@MTI)KDSZ\\@":K58%'UJ9LGAI-HZDUFF8A
M+'#7Y,_PG`:2;?$05M<<\>9*;I'A](F4@42M-]4GSX<>4I^O6LP1RQ?)T"V'
M_O6>WLRM6^RQG*":-V^<&!TLA&6N/:6*GW=2OBC4QF-I<E;QN#+M06H![A"R
M)%'R!H-BD_F4XLDVU93P(WQD2Y7"\92>'R23:0\)'_:4C@P\(SI,N4T%`?:"
MNV,YFARD4%SGI]I]W.9R[-`>NI[+%G5RPX_S0$PB!.5,B5Q%7WXX^+E2,98?
M(OVKF-^H@VA\YPVTQO1*'>"+P6WZ$WDR6E8:(70:IIEN4I<96'PE+MH/J3.]
M"C'X@#7BT';$2;8OSR"5-AD;5VNB))=4F23ARJ[))6\?<2FKO"&GS(TE\@,Y
MEGJ]/K=<US-KD/+N=4WS+9=2S8W252#NUB/J2C<J^0H)@I5>L8C.**R8H1WC
M<7\%6S>=V?PX,J_`L4R1S."2\+,QV2*D)?TX3J&3M2*`'Q172TEG3C2P=Z>R
MM!V*)T`$\YD"DRG[+C_>`'T-O:RO8E/`F&B:X]UI':&C$F<\8_!OZ,M>ZN9+
MHT/`_S7UGF%5&G6C;M8-ON*66S9>ZFUB-K!49S9*G:#5;6A-W<C5Z>3N+#^P
MR'?"1>[Y'>HIV;X`!;AL71SF!2W%:_!R8&2X36)^Z$QDG_!?;LLW.VHKC<#C
M#F)K_^0M'B=^<S1XK3XD#E\*$;,ZW9U%O$4^C03H;^9NS&M93N`SVX5IXE.J
44*]POJ0"?WE'+?X+RV+TL<PV```Z
`
end

Re: Zle patch - termok change

[Zefram]

gwing@primenet.com.au wrote:
>termok == 0 indicates a `normal' working terminal - this is *opposite* to
> the previous situation.

Perhaps it should be renamed to termbad then.

>+ /* flag defines */
>+ #define issetflag(X, Y)		((X & (Y)) == Y)
>+ #define isanysetflag(X, Y)	(X & (Y))
>+ #define setflag(X, Y)		X |= (Y)
>+ #define unsetflag(X, Y)		X &= ~(Y)

Yuck.  issetflag() evaluates Y twice, and there aren't enough parentheses.
The fully parenthesised forms are:

#define issetflag(X, Y)		(((X) & (Y)) == (Y))
#define isanysetflag(X, Y)	((X) & (Y))
#define setflag(X, Y)		((X) |= (Y))
#define unsetflag(X, Y)		((X) &= ~(Y))

But why bother with these macros anyway?  We've always been happy with
the (much clearer) plain bit operations anyway.

-zefram