> > Looking over the rest it looks fine. The one thing I see that I would > do differently is to have a single tags loop in _urpmi_rpms instead > of the three consecutive _wanted calls. It also adds source and > binary rpms separately which means that directories get added twice. > I think it'd be better to add them together - a user can always > separate them with a file-patterns style. > Right. This also changes indentation (sorry, Sven, I just have 'set sw=4' in .vimrc as I happen to like it the most :-) -andrej