From: Borzenkov Andrey <Andrej.Borsenkow@mow.siemens.ru>
To: "'Hannu Koivisto'" <azure@iki.fi>, zsh-workers@sunsite.dk
Subject: RE: Cygwin 1.3.12/zsh 4.0.6/zftp.c compilation problem
Date: Mon, 14 Oct 2002 12:52:45 +0400 [thread overview]
Message-ID: <6134254DE87BD411908B00A0C99B044F03A0B47D@mowd019a.mow.siemens.ru> (raw)
In-Reply-To: <87y997eslb.fsf@lynx.ionific.com>
> Greetings,
>
> zsh 4.0.6 fails to compile under the latest Cygwin (1.3.12) because
> zftp.c includes netinet/ip.h but not netinet/in_systm.h:
>
> #ifndef __CYGWIN__
> # include <netinet/in_systm.h>
> #endif
> #include <netinet/in.h>
> #include <netinet/ip.h>
>
> netinet/ip.h refers to at least n_long which is defined in
> netinet/in_systm.h (or more precicely, in cygwin/in_systm.h that
> netinet/in_systm.h includes) so netinet/in_systm.h is needed. If I
> comment out the first and the third lines in the above code, zsh
> compiles and seems to work.
>
You sure have heard about "compatibility"? :-)
Does the following patch works?
-andrey
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/zftp.c,v
retrieving revision 1.12.4.2
diff -u -r1.12.4.2 zftp.c
--- Src/Modules/zftp.c 25 Apr 2002 14:48:21 -0000 1.12.4.2
+++ Src/Modules/zftp.c 14 Oct 2002 08:51:50 -0000
@@ -68,9 +68,9 @@
* __USE_LARGEFILE. This means the problem is somewhere in the
* header files where we can't get at it. For now, revert to
* not including this file only on systems where we know it's missing.
- * Currently this is just cygwin.
+ * Currently this is just older versions of cygwin.
*/
-#ifndef __CYGWIN__
+#if HAVE_NETINET_IN_SYSTM_H || !defined( __CYGWIN__)
# include <netinet/in_systm.h>
#endif
#include <netinet/in.h>
prev parent reply other threads:[~2002-10-14 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-09 11:53 Hannu Koivisto
2002-10-14 8:52 ` Borzenkov Andrey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6134254DE87BD411908B00A0C99B044F03A0B47D@mowd019a.mow.siemens.ru \
--to=andrej.borsenkow@mow.siemens.ru \
--cc=azure@iki.fi \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).