From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 08c3d6e4 for ; Mon, 17 Feb 2020 14:34:12 +0000 (UTC) Received: (qmail 13062 invoked by alias); 17 Feb 2020 14:34:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45450 Received: (qmail 12162 invoked by uid 1010); 17 Feb 2020 14:34:06 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25725. spamassassin: 3.4.2. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 3.798019 secs); 17 Feb 2020 14:34:06 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeigdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdffrghn ihgvlhcuufhhrghhrghffdcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg eqnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdr shesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-802-g7a41c81-fmstable-20200203v1 Mime-Version: 1.0 Message-Id: <615babbb-41a3-4954-831c-9a1db9882052@www.fastmail.com> In-Reply-To: <20200217141144.GB20166@chrisdown.name> References: <20200216103954.GC15773@tarpaulin.shahaf.local2> <20200217141144.GB20166@chrisdown.name> Date: Mon, 17 Feb 2020 14:33:04 +0000 From: "Daniel Shahaf" To: "Chris Down" Cc: zsh-workers@zsh.org Subject: =?UTF-8?Q?Re:_[PATCH_v2_2/2]_builtins:_kill:_Do_not_signal_current_proce?= =?UTF-8?Q?ss_group_when_pid_is_empty?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Chris Down wrote on Mon, 17 Feb 2020 14:11 +00:00: > Daniel Shahaf writes: > >Chris Down wrote on Sat, Feb 15, 2020 at 20:21:09 -0400: > >> + trap 'exit 19' TERM > >> + kill '' > >> +1:Plain kill with empty pid should not send signal to current proc= ess group > >> +?(eval):kill:2: illegal pid: > > > >Should this test use a subshell so as not to kill the test suite proc= ess in > >case the bug regresses? > > > >Personally, I'm partial to first adding commits in "expected to fail"= mode > >(using the =C2=ABf=C2=BB flag after the expected exit code) and then = in a separate commit > >fix the bug, since doing so in effect validates the test. However, I= see this > >as a nice-to-hvae, not a blocker. >=20 > For this particular one, the subshell won't help, since we're part of = the same=20 > process group as make and the test runner regardless: >=20 > make: *** [Makefile:263: check] User defined signal 1 > make[1]: *** [Makefile:190: check] User defined signal 1 > make[1]: Leaving directory '/home/cdown/git/zsh/Test' Ah, right, of course. > One possibility to avoid that is to run these few tests in a shell tha= t's a new=20 > session leader, like in W02jobs, I suppose. What do you think about th= at? Making kill's tests use zpty would probably be too complicated for their= purpose. Seeing as even now the bug would fail =C2=ABmake check=C2=BB i= f it recurs, I think we can go with what you have. Thanks, Daniel