zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: (EXT) Re: Using the history expansion modifier 'a' results in excessive lstat calls
Date: Thu, 26 May 2022 09:35:17 +0100 (BST)	[thread overview]
Message-ID: <617849366.397219.1653554117384@mail2.virginmedia.com> (raw)
In-Reply-To: <1468290738.368523.1653474795097@mail2.virginmedia.com>

> On 25 May 2022 at 11:33 Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> > On 25 May 2022 at 11:22 Stefan Radziuk <sradziuk@pdtpartners.com> wrote:
> > > Will it be worth seeing what effects the following has?
> > 
> > This resolves the issue for me -- verified with strace. Thanks.
> >
> >  dnl CHECK FOR SYSTEMS REQUIRING GETCWD
> > +dnl This is now turned on by default, as we expect modern getcwd
> > +dnl implementations to work correctly.  Any exceptions should be added
> > +dnl to the first case.  Currently there are none, hence it is forced
> > +dnl not to match.
> 
> Unless anyone has strong views, I'll commit this --- hoping at the most
> we'll be look at edge effects on older or rarer systems which we're not
> going to track down any other way.

Not hearing comments, so this is committed.  Workers with such systems
are advised to keep watch for any oddities (very likely edge cases) in
getting the current directory.

pws


  reply	other threads:[~2022-05-26  8:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 10:08 Stefan Radziuk
2022-05-20 10:15 ` Peter Stephenson
2022-05-25  9:53   ` Peter Stephenson
2022-05-25 10:22     ` (EXT) " Stefan Radziuk
2022-05-25 10:33       ` Peter Stephenson
2022-05-26  8:35         ` Peter Stephenson [this message]
2022-05-20 10:34 ` Mikael Magnusson
2022-05-23 11:32   ` (EXT) " Stefan Radziuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=617849366.397219.1653554117384@mail2.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    --subject='Re: (EXT) Re: Using the history expansion modifier '\''a'\'' results in excessive lstat calls' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).