From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,MALFORMED_FREEMAIL,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id f3888b04 for ; Sun, 19 Jan 2020 23:10:16 +0000 (UTC) Received: (qmail 17564 invoked by alias); 19 Jan 2020 23:10:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45334 Received: (qmail 3576 invoked by uid 1010); 19 Jan 2020 23:10:10 -0000 X-Qmail-Scanner-Diagnostics: from sonic310-12.consmr.mail.ir2.yahoo.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25699. spamassassin: 3.4.2. Clear:RC:0(77.238.177.33):SA:0(-0.6/5.0):. Processed in 1.912882 secs); 19 Jan 2020 23:10:10 -0000 X-Envelope-From: okiddle@yahoo.co.uk X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.mail.yahoo.com designates 77.238.177.33 as permitted sender) X-YMail-OSG: lYcMdTwVM1k7kBoKR7zjnoJ87q_.0oFnF0qBJQOd.ZiUw_SjKNqeIQLq3VfJ.Iz AqER0qaUgdBvKml.6VgpEd31VV_Od_G8J7xzzPbjvhyQRwc1jq_wbGrL2zNTi3oKiTRNXk1G7AN5 9mb_9cQTNcWv4TNAVv2xv7IiI7u_JCh3FJmdm8A.ga_L9sC5IIkxoZEmx6Py0f2hu0yWgFA_D1Dm VwnmouHMDdlyU3_I2NhwWCA_p_oGU9n5h.gHczoqaYYcl98Oa106Vdkuo5JMAKe2vLolv7jdn2t6 pnHHiV6avAVKIYRFKYCc9Wibto6idhFR_FLLI51J5eZqmBvsgpPimbaQXnZXGBgNupSVNZq28wD1 CVYUcniRRLhFHqMcfdS9UWAd6Jcma6iBb_WYqIRa5D08xsk3YRlkBAiYAGQTS8Vfb6mKPHOVCcbA Uuvh0sJdhz0ZvkC9fpJxJHT0vikIu1zFx1HL4RCf1B0cnb1aE9eo9Er4qN16LfD90iMBgtIqsN9U JIz8T5QrQxGk3mFMtooqbTTH5i5lx4dJtHidlCvPKJvjrjL0ML3UJRTjPsUsUHRkV1TVcr3NDAzb t_OGftkQlqMaUrTWzDU0hGvdoA0qB24Y0Te2OHg9CfTVY37p0g5YOlIZWVuKgXKaQM6Uvwoq9smu kHyLgbqa_iZwEcpnvjCuz72dreQhL43KxHaoZtXmScuJ0e7gUCqQwopkp_nMKergJDH4TKYvwCPq xATyo_VDNkbZbFh7qZt008OCdm5CSB1isBqRGLHEC1tN84OONxLzbkq4DAS6lfwYYMe2QeiLuaBe foGu6dn4OVuE2zOoR9Kev2M0yesxSRuQ3cHT3RhC8N.om4pClODvbEeNrGrGWwlP3olSlvKz9kAO I_x_GRjIZtAUVWPYN5B8s55scw1NpyY7fJp_qukAN76BzHfSeWFxi1oF9IKaaB9.ZpxDPXY.zWeu S4QpKdMxTPuhvs_iGvMGrMiqVC6gB..e7ntd6ntvV1.fIfsgxxjGJfYqr2fpttFBmXB6kfnce4i9 jed_pVisrRloN2FSZ9L5TMug36ErUTFOWyPurw0fc3_CBLEAldYmtIJuaY7qK66ccdul_uKjCw34 NalNbMJpHhGQy7NNBUjrecB7Ifrja7fHaTxOrtqNpRiY71kmxrQoxCwSTzG9asoIf30wWuovDJb2 ozedT6tMj4.zEyWw0w913uaAMCC1CIQlYkEhkGrutxMUTUflpMH8slgPATHKZFJB49pOvjU59jo_ TKvlJv6jIvV40hqzYVtnrrPFrJJR_gf2CS0jxu6BodxUCwPLfDAe3VGiPvQRotslLq7b8IbEyWMQ uumaw9kxBhGSAbepcFkqkJNO0xSdrO.d6lFFCxwORy6XM2HM0fZ4ZqdUCZvC0uGvCZhaJXFOKlgu l6r.pFRGkN86eTgA- cc: "Eitan Adler" , zsh-workers@zsh.org In-reply-to: <8049d524-b7ad-4f45-982e-ddf313b7958b@www.fastmail.com> From: Oliver Kiddle References: <20200119213156.37874-1-lists@eitanadler.com> <8049d524-b7ad-4f45-982e-ddf313b7958b@www.fastmail.com> To: "Daniel Shahaf" Subject: Re: [PATCH] _git: add completion for git-version MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <62020.1579475363.1@hydra> Content-Transfer-Encoding: 8bit Date: Mon, 20 Jan 2020 00:09:23 +0100 Message-ID: <62021-1579475363.693409@694T.IZIu.-Z_U> X-Mailer: WebService/1.1.14873 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) Daniel Shahaf wrote: > This subcommand is undocumented (except one mention in the release > notes); is it a public API? Features being undocumented hasn't necessarily stopped us from including them in completion in the past. I don't think there's any established policy on this and it can depend on specific cases. In some cases you would want completion to understand but not offer the undocumented match (like ! in _arguments specs). This particular patch seems reasonable to me as-is. > «git --version --build-options» also works, but doesn't seem to be > documented, either. The output of git --version -h or git version -h mentions it. I'd say that counts even if the man page omits to mention it. Oliver