From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17726 invoked from network); 27 Dec 1996 10:57:53 -0000 Received: from euclid.skiles.gatech.edu (list@130.207.146.50) by coral.primenet.com.au with SMTP; 27 Dec 1996 10:57:53 -0000 Received: (from list@localhost) by euclid.skiles.gatech.edu (8.7.3/8.7.3) id FAA24197; Fri, 27 Dec 1996 05:58:18 -0500 (EST) Resent-Date: Fri, 27 Dec 1996 05:58:18 -0500 (EST) From: Zefram Message-Id: <6211.199612271059@stone.dcs.warwick.ac.uk> Subject: Re: new module To: hzoli@cs.elte.hu (Zoltan Hidvegi) Date: Fri, 27 Dec 1996 10:59:16 +0000 (GMT) Cc: zefram@dcs.warwick.ac.uk, zsh-workers@math.gatech.edu In-Reply-To: <199612250228.DAA00980@hzoli.ppp.cs.elte.hu> from "Zoltan Hidvegi" at Dec 25, 96 03:28:12 am X-Loop: zefram@dcs.warwick.ac.uk X-Stardate: [-31]8637.28 X-US-Congress: Moronic fuckers Content-Type: text Resent-Message-ID: <"1TE603.0.zv5.9lwmo"@euclid> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/2642 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu Zoltan Hidvegi wrote: >There are two problems with this code. First it cannot remove a directory >hierarchy if it has too deep subdirectories. That's quite bad when you use >it to clean up directories. A user who wants to save his files from >automatic deletion can hide it deeply in a subdirectory. True. This ought to be avoided. >Btw. I've just noticed that rm -r in files.c uses stat() instead of lstat() >hence it follows symlinks happily :-(. Oops. That was not how I intended it. I did consider that particular problem, and other related cases, and deliberately chose lstat() over stat() in several places. This I think needs to be fixed immediately. I'll fix the other problems after the next beta, unless of course you get to them first. -zefram