zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: -o nobanghist -o emacs segfaults
Date: Fri, 3 Apr 2020 11:15:24 +0100 (BST)	[thread overview]
Message-ID: <625822760.3979791.1585908925002@mail2.virginmedia.com> (raw)
In-Reply-To: <20200403081118.7031b5b9@tarpaulin.shahaf.local2>


> On 03 April 2020 at 09:11 Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> % b/Src/zsh -f -o nobanghist -o emacs
> zsh: segmentation fault  b/Src/zsh -f -o nobanghist -o emacs

The option parser is passing the keymap to ZLE, which hasn't been loaded yet.
Attempting to load it doesn't work because at the point of initial option parsing
the basic definitions for the module system aren't set up.

Moving up the initialisation of the module system could possibly expose some hairy
dependencies.

Probably the right thing to do is to detect this condition, remember the keymap,
and pass it in later.  I'm not entirely sure where the best place for this is,
but as it's specific to initialisation and depends on the sequencing of that I
suppose up in that code, rather than down in anything ZLE-specific.  But
at least the option parser needs to be aware this is init rather than run time.

(See my previous ramblings on the theme "ZLE isn't really a self-contained module in
the fullest acceptance of the term".)

pws

  reply	other threads:[~2020-04-03 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03  8:11 Daniel Shahaf
2020-04-03 10:15 ` Peter Stephenson [this message]
2020-04-05 18:34 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=625822760.3979791.1585908925002@mail2.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).