From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 069e6bf2 for ; Mon, 15 Jul 2019 21:26:34 +0000 (UTC) Received: (qmail 2382 invoked by alias); 15 Jul 2019 21:26:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44535 Received: (qmail 28099 invoked by uid 1010); 15 Jul 2019 21:26:29 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-4.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25510. spamassassin: 3.4.2. Clear:RC:0(80.0.253.68):SA:0(-2.0/5.0):. Processed in 1.306087 secs); 15 Jul 2019 21:26:29 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _smtprelay.virginmedia.com designates 80.0.253.68 as permitted sender) X-Originating-IP: [86.16.88.158] X-Authenticated-User: p.w.stephenson@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=CvqRjEwD c=1 sm=1 tr=0 a=MiHCjVqLJ44lE3bxSlffFQ==:117 a=MiHCjVqLJ44lE3bxSlffFQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=NLZqzBF-AAAA:8 a=CHwxZhbiMgLlH3X4cqwA:9 a=QEXdDO2ut3YA:10 a=wW_WBVUImv98JQXhvVPZ:22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com; s=meg.feb2017; t=1563225952; bh=zLjzzYFsw9E5eqL+NwEaKnGuE6ZzHUN7yrO7K0mpmD8=; h=Subject:From:To:Date:In-Reply-To:References; b=bqq2hJK7PUTzjE5TV/oWUB6/4Ns8WKzHvcoQFV3u7O1DkYBNqSpD7TMF1bRAJ2PLD 0TOlgd/YS7YNFqugZdZwW6Tt/Own9QTx8ixF0t3kiQlfZxy3dH3PVuyy9gYG/gVTP5 YhTsEWIuL6NwgNeU5fPBZqp7N+I4k45aXPRCnfiPuJaWn3dobQhLHivHy23iAkJfUK a5MW+dGTWuUKtJDYFWYJS7gQLq+K+0oJzdVeNs5NOiwSm2mBx9k4uAMhKf89fPh7m6 9ZgQvT/076cR2Cdy7JUWgXUtJF52n0NDdugF+Ak0bl3ddYKTZxoEtT8lZJuIXgi9le 4Zur2iiIYba3w== Message-ID: <641de8a0b26f713e1f10203aeccbe8a8b9b3769e.camel@ntlworld.com> Subject: Re: PATCH: function copy From: Peter Stephenson To: Zsh hackers list Date: Mon, 15 Jul 2019 22:25:52 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFNBKN6/n+lhPbb5kcPaRgLo8gxIz203cJUV9JN772jI3ax3xGzlJakWMsJkEa0cY/TY1rFLko/EicHO/dfRK8P4CjsO+cauP1DRBbw9O9y8TDkrE80F tOdsqAiqWqJGNnXrdxHxjQzlmZI7sLL925RysWyiD3cDQ/hbmIqeIXmL On Mon, 2019-07-15 at 22:23 +0200, Sebastian Gniazdowski wrote: > On Mon, 15 Jul 2019 at 22:01, Peter Stephenson > wrote: > > + if (OPT_ISSET(ops,'c')) { > > + Shfunc newsh; > > + if (!*argv || !argv[1] || argv[2]) { > > + zwarnnam(name, "-c: requires two arguments"); > > + return 1; > > + } > > I'm probably wrong, as the tests should caught that up, but should the > "argv[2]" in the line: > > > + if (!*argv || !argv[1] || argv[2]) { > > actually say "!argv[2]"? It it's an error if argument zero is empty, or argument one is empty, or argument two is non-empty. pws