From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 25090 invoked from network); 3 Nov 2023 09:51:15 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Nov 2023 09:51:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date: Content-Transfer-Encoding:Content-ID:Content-Type:MIME-Version:Subject:To: References:From:In-reply-to:cc:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=M4ARmg94vVgoDZRtDnpvl9MxflbK6F+pHgkuPtNuBYw=; b=TzqpW75MHoCAOvX5XvXBbcXOaI iuCZz4RS/uSnY9kMMNsx43QMGIep+BfX6KxM/SG166ybRPno2tKF/E96TsLVNgSvfaGv/HdKj9V1A URcsLfcNqvJbEyTEpd6TtwAl8E9rSsv2Ju2OAHvrvskTyz7ayIhBpBaK8GXPmZF5usFrPJEP9Y311 gAkVsSJKp8+ed1o5M1eT9Xr9MII/VZCYpqpUayYNBsL830sgt85yLzcYCyjhOEtmBfodsaOxrU/i7 jImKHPsmdUPmyZVF63v2E4qOfUhzb+r5ieLe9qFI6lMEGIQorU437sY49+M1XRN1/k8WM1D/7IFJW Z5wT4dZQ==; Received: by zero.zsh.org with local id 1qyqpb-0007Bc-VJ; Fri, 03 Nov 2023 09:51:11 +0000 Received: by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qyqp1-0006s8-Ir; Fri, 03 Nov 2023 09:50:35 +0000 Received: from [192.168.178.21] (helo=hydra) by mail.kiddle.eu with esmtp(Exim 4.95) (envelope-from ) id 1qyqp0-000Gle-Ce; Fri, 03 Nov 2023 10:50:34 +0100 cc: Zsh workers In-reply-to: From: Oliver Kiddle References: <72311-1698710659.978677@cDMN.pAu_.Ex7V> <31963-1698804298.865464@oYlZ.u4GW.p43I> To: Bart Schaefer Subject: Re: PATCH: pcre callouts MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <64456.1699005034.1@hydra> Content-Transfer-Encoding: 8bit Date: Fri, 03 Nov 2023 10:50:34 +0100 Message-ID: <64457-1699005034.369027@7IEn.q_Gt.fe0Q> X-Seq: 52271 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Bart Schaefer wrote: > I didn't try applying the previous patch, but now that this one has > been pushed to sourceforge: I'm less sure on whether to push the later one for setting a scope. And perhaps whether to add a -f option to pcre_match for a fixed callout function that can avoid shell evaluation and handle numeric callouts. > pcre.c: In function ‘pcre_callout’: > pcre.c:132:44: error: parameter name omitted > 132 | pcre_callout(pcre2_callout_block_8 *block, void *) > | ^~~~~~ Sorry, I think the following form should be right. Oliver diff --git a/Src/Modules/pcre.c b/Src/Modules/pcre.c index e6b59831f..e48ae3ae5 100644 --- a/Src/Modules/pcre.c +++ b/Src/Modules/pcre.c @@ -129,7 +129,7 @@ bin_pcre_study(char *nam, UNUSED(char **args), UNUSED(Options ops), UNUSED(int f } static int -pcre_callout(pcre2_callout_block_8 *block, void *) +pcre_callout(pcre2_callout_block_8 *block, UNUSED(void *callout_data)) { Eprog prog; int ret=0;