From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5743 invoked from network); 5 Jun 2020 13:59:09 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 5 Jun 2020 13:59:09 -0000 Received: (qmail 2863 invoked by alias); 5 Jun 2020 13:59:03 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45986 Received: (qmail 16848 invoked by uid 1010); 5 Jun 2020 13:59:03 -0000 X-Qmail-Scanner-Diagnostics: from smtpq2.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25828. spamassassin: 3.4.4. Clear:RC:0(212.54.57.97):SA:0(-2.7/5.0):. Processed in 2.967572 secs); 05 Jun 2020 13:59:03 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.97 as permitted sender) X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.136 X-CNFS-Analysis: v=2.3 cv=T8IXs8CQ c=1 sm=1 tr=0 a=4AIt8OzuWET5BS7mAkvERw==:117 a=KEnZaF_ea6UA:10 a=IkcTkHD0fZMA:10 a=DoY9bV0jb9AA:10 a=pGLkceISAAAA:8 a=B5m7BQRGfy507KPkgiIA:9 a=QEXdDO2ut3YA:10 X-Authenticated-Sender: p.w.stephenson@ntlworld.com Date: Fri, 5 Jun 2020 14:58:19 +0100 (BST) From: Peter Stephenson To: zsh-workers@zsh.org Message-ID: <650622554.469269.1591365499237@mail2.virginmedia.com> In-Reply-To: <20200605134208.32082-1-mikachu@gmail.com> References: <20200605134208.32082-1-mikachu@gmail.com> Subject: Re: PATCH: typeset: Fix leaving corrupted entries in paramtab MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev70 X-Originating-IP: 165.225.81.56 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4wfGZ+Xilsy83JOCAQQj+U+nIJlb77kqG4VrD899KsUCK7PgTIdhtqN3ha1okUiGokhWobDqtJjEq2i/Ucq0lCZjjBE/+UaY3e7kNHoro/xxfRYIr6yt+T 9yTSyH9/aoAnXWQ5Y6hznnbNSklJfcIxI9ZtUUN/drGgTD4dnWTjzVzBQEgyEzYbm//nGzFNM83ZjTaX8SkpBx1CK+FV3oQs74I= > On 05 June 2020 at 14:42 Mikael Magnusson wrote: > This appears to fix the problem in 45984, but I would appreciate someone > checking if it seems sane and/or complete. Looks sane to me --- those are three cases where we've just created a new parameter for some special purpose (which then failed), which isn't typical in that function as it can operate on existing parameters too, so additional action at those specific points is correct. pws